From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 098BBEB64DB for ; Tue, 20 Jun 2023 18:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CYLcKH47xFthUUE0kWYrWRJkR3quyIrJEORwpwWyf+Q=; b=nFL2lkCP/iIiHi pM8BQ8v6UjSjEljOvn4lZ0WYWNNur2qWHXu4MtbQoHLZlxgiX80/CweadpkgT7/qUPmBJh4LhkU0Z 1tcUJClW7Jyoc0TZ+pc8wgB4xzRtAn9EVUwfDAdlcFuCmOUd2GRMOCnJzZezIWmLbOgsyt3o1cRUW waJqyUT06efgOma69pr2DtAgE6FTxmbcRVopeNnEg8utTL9vc7zDN06pT/gdrDdifiHasKnAdKU4d a9KZN9eGwJiuVw4UcwtZmWxlF+dOZncmdEQNyZRe9DSPFd3c5IjapVoKmnRtXdxyIQyy2LyKte9gg UWuRlZigaOw06MFbZDWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBgDB-00C4aD-0U; Tue, 20 Jun 2023 18:36:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBgD9-00C4Zf-0I; Tue, 20 Jun 2023 18:36:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B49C613F9; Tue, 20 Jun 2023 18:36:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19C69C433C8; Tue, 20 Jun 2023 18:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687286173; bh=sX2sSKMvZDgXiv/6djBL9peXikyWYOXmqDdJtUv/Rog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T7P6o2NTmIK/dfUJ2MlqFSWk/HD8zh5kKq3V59rbEkm2W8iBi4+KzYOqRgEsG1c5J Flu1mqP3J/LZuS8od7PS1Rtww2CS7zqpGXwaUGIk5R28w7H0jA5RUWiUC1ryGnCobY QMcza8/waYE7Agv47F27XZUL4+izLIzqvieGqV7c= Date: Tue, 20 Jun 2023 20:36:11 +0200 From: Greg KH To: Laurent Pinchart Cc: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stefan.wahren@i2se.com, f.fainelli@gmail.com, athierry@redhat.com, error27@gmail.com, dave.stevenson@raspberrypi.com, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v7 1/5] staging: vc04_services: vchiq_arm: Add new bus type and device type Message-ID: <2023062030-flattop-jury-e10c@gregkh> References: <20230620134152.383569-1-umang.jain@ideasonboard.com> <20230620134152.383569-2-umang.jain@ideasonboard.com> <2023062022-whimsical-hasty-b012@gregkh> <20230620182054.GA14686@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230620182054.GA14686@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230620_113615_217413_6C9443DB X-CRM114-Status: GOOD ( 31.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 20, 2023 at 09:20:54PM +0300, Laurent Pinchart wrote: > On Tue, Jun 20, 2023 at 04:17:05PM +0200, Greg KH wrote: > > On Tue, Jun 20, 2023 at 07:11:48PM +0530, Umang Jain wrote: > > > The devices that the vchiq interface registers (bcm2835-audio, > > > bcm2835-camera) are implemented and exposed by the VC04 firmware. > > > The device tree describes the VC04 itself with the resources required > > > to communicate with it through a mailbox interface. However, the > > > vchiq interface registers these devices as platform devices. This > > > also means the specific drivers for these devices are getting > > > registered as platform drivers. This is not correct and a blatant > > > abuse of platform device/driver. > > > > > > Add a new bus type, vchiq_bus_type and device type (struct vchiq_device) > > > which will be used to migrate child devices that the vchiq interfaces > > > creates/registers from the platform device/driver. > > > > > > Signed-off-by: Umang Jain > > > --- > > > drivers/staging/vc04_services/Makefile | 1 + > > > .../interface/vchiq_arm/vchiq_device.c | 78 +++++++++++++++++++ > > > .../interface/vchiq_arm/vchiq_device.h | 43 ++++++++++ > > > 3 files changed, 122 insertions(+) > > > create mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_device.c > > > create mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_device.h > > > > > > diff --git a/drivers/staging/vc04_services/Makefile b/drivers/staging/vc04_services/Makefile > > > index 44794bdf6173..2d071e55e175 100644 > > > --- a/drivers/staging/vc04_services/Makefile > > > +++ b/drivers/staging/vc04_services/Makefile > > > @@ -5,6 +5,7 @@ vchiq-objs := \ > > > interface/vchiq_arm/vchiq_core.o \ > > > interface/vchiq_arm/vchiq_arm.o \ > > > interface/vchiq_arm/vchiq_debugfs.o \ > > > + interface/vchiq_arm/vchiq_device.o \ > > > interface/vchiq_arm/vchiq_connected.o \ > > > > > > ifdef CONFIG_VCHIQ_CDEV > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_device.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_device.c > > > new file mode 100644 > > > index 000000000000..e16279a25126 > > > --- /dev/null > > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_device.c > > > @@ -0,0 +1,78 @@ > > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause > > > > Code that directly interacts with the driver core can, for obvious > > reasons, not be BSD-3 licensed, sorry. > > > > Also, why is any of this dual licensed? What good is any of that? In > > order for me to accept new dual-licensed code, it needs to be documented > > in the changelog very very well as to exactly why this is required, as > > the legal issues involved in maintaining dual-licensed code like this is > > tricky and easy to get wrong (as proven here already in this patch...) > > The whole vchiq_arm layer is dual licensed GPL-2.0 + BSD-3. I assume > this is why Umang used the same licensing terms. We can use GPL-2.0 only > if this patch qualifies as original work and not derived work of the > existing code. This is most certainly original work, not related to the original code here, and can never work in a BSD-3 licensed environment. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel