From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E350BEB64D7 for ; Wed, 21 Jun 2023 12:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sJGHHdzFl8UavEw4ihYg+5DXRrzhart9iC/GsOxhpGg=; b=Z2RlbV5J9TZttD SMZ5tx9vXg6UjGQcLflE0P91lfhK+bazsBbI045wVN9eWp+dT6I0jtTOwVlUQw0NMpvDykWvvq4Z1 4TpduJUme1k4zWYxl4ymGJ6p31XmB2k3yTqol7cEeWlw4I5xF15R6Hh0wAq7rKMK7jYMU6yxog+Is tDD+w84noWHaiR4AsDL9GKU/an1UyF5I/SLebVvjucrkLyCeBK4lVIucn8BtSHp9wb0bIh/VGy3Po ozP28lth1SqTDHo43MFzbyyZM2WF0aGoy2u34DroXdJqHq8LzmPmbwmdYAGR4iR30hu4uoA779Y3Q G6lzXnrl4IKJDBHiTHiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBxJS-00Ebbr-2s; Wed, 21 Jun 2023 12:51:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBxJP-00EbaR-25 for linux-arm-kernel@lists.infradead.org; Wed, 21 Jun 2023 12:51:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0244661568; Wed, 21 Jun 2023 12:51:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9261C433C8; Wed, 21 Jun 2023 12:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687351910; bh=/Hkm++/tE6ZrYuLRdKzKly3jNBg1mAMPb2Gv7kJxnN8=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=ROKrPDP5Wd7iusGM/T8CWHoQRVahWjqt5IBGnz7MA7QlY3qToSvCp1OE3rfFXz5o7 0pfgb6Pkl8CxcxPkGp9PupqYJVqYJNRoIWwxDYahtYYnee356/GNVGoNtMFOSpLKDj UTpepZbwzVgF4UatLa0Wfi89711K9xEBVmqKBs3w= Date: Wed, 21 Jun 2023 14:51:44 +0200 From: Greg KH To: Jacky Huang Cc: mturquette@baylibre.com, sboyd@kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, soc@kernel.org, krzysztof.kozlowski+dt@linaro.org, schung@nuvoton.com, Jacky Huang Subject: Re: [PATCH v2 2/2] clk: nuvoton: Use clk_parent_data instead of string for parent clock Message-ID: <2023062103-obtuse-parasitic-e675@gregkh> References: <20230621031605.234149-1-ychuang570808@gmail.com> <20230621031605.234149-3-ychuang570808@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230621031605.234149-3-ychuang570808@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_055151_730023_BE68B142 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 21, 2023 at 03:16:05AM +0000, Jacky Huang wrote: > > - hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0, > - 26, 1, axiclk_sel_clks, > - ARRAY_SIZE(axiclk_sel_clks)); > - hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux", clk_base + REG_CLK_CLKSEL0, > - 2, 1, sysclk0_sel_clks, > - ARRAY_SIZE(sysclk0_sel_clks)); > - hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0, > - 4, 1, sysclk1_sel_clks, > - ARRAY_SIZE(sysclk1_sel_clks)); > + hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0, 26, 1, > + axiclk_sel_clks, ARRAY_SIZE(axiclk_sel_clks)); > + > + hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux", > + clk_base + REG_CLK_CLKSEL0, 2, 1, > + sysclk0_sel_clks, ARRAY_SIZE(sysclk0_sel_clks)); > + > + hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0, 4, 1, > + sysclk1_sel_clks, ARRAY_SIZE(sysclk1_sel_clks)); > + No need to reformat lines that are not actually changing anything, as this makes the patch harder to review for real changes in it :( thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel