From: Conor Dooley <conor.dooley@microchip.com>
To: Lucas Tanure <tanure@linux.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>, Nick <nick@khadas.com>,
Artem <art@khadas.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
Conor Dooley <conor@kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7
Date: Thu, 22 Jun 2023 10:26:18 +0100 [thread overview]
Message-ID: <20230622-unsent-willing-574906af5e1a@wendy> (raw)
In-Reply-To: <20230622084045.519203-3-tanure@linux.com>
[-- Attachment #1.1: Type: text/plain, Size: 1708 bytes --]
Hey Lucas,
On Thu, Jun 22, 2023 at 09:40:44AM +0100, Lucas Tanure wrote:
> Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A.
> There is no need for an extra compatible line in the driver, but
> add T7 compatible line for documentation.
>
> Co-developed-by: Conor Dooley <conor@kernel.org>
You can delete this, I don't need a Co-developed-by tag for review
feedback.
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
> .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> index 01ec45b3b406..4ca4673169aa 100644
> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> @@ -46,6 +46,12 @@ properties:
> - amlogic,meson8b-uart
> - amlogic,meson-gx-uart
> - amlogic,meson-s4-uart
> + - description: Everything-Else power domain UART controller on G12A compatible SoCs
s/Everything-Else/Always-on/
Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Perhaps it can be fixed on application, I don't know how the amlogic
maintainers operate.
Cheers,
Conor.
> + items:
> + - enum:
> + - amlogic,meson-t7-uart
> + - const: amlogic,meson-g12a-uart
> + - const: amlogic,meson-ao-uart
> - description: Everything-Else power domain UART controller on G12A SoCs
> items:
> - const: amlogic,meson-g12a-uart
> --
> 2.41.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-22 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 8:40 [PATCH v4 0/3] Add Amlogic A311D2 and Khadas Vim4 Board Support Lucas Tanure
2023-06-22 8:40 ` [PATCH v4 1/3] dt-bindings: arm: amlogic: add Amlogic A311D2 bindings Lucas Tanure
2023-06-22 8:40 ` [PATCH v4 2/3] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7 Lucas Tanure
2023-06-22 9:26 ` Conor Dooley [this message]
2023-06-22 9:38 ` Neil Armstrong
2023-06-22 10:04 ` Conor Dooley
2023-06-23 7:51 ` Lucas Tanure
2023-06-22 8:40 ` [PATCH v4 3/3] arm64: dts: meson-t7-a311d2-khadas-vim4: add initial device-tree Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622-unsent-willing-574906af5e1a@wendy \
--to=conor.dooley@microchip.com \
--cc=art@khadas.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
--cc=tanure@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox