From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A8BFEB64DA for ; Thu, 22 Jun 2023 07:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dcmjqHrO5vX6r2Ju90/S8jurD/+OS9uESyd/9LmSZaY=; b=z4WNW9ALwnsFMh oCKg3XHLj7/3WsFJlzY/TUm2dE5Zl4OWlS8LRlqZxl+d8dePjsBJRDosOMctmEhqQdpIrABJVDuFg Bs2lUO/6GSJNFd3HBkMUEHJB/WdTpBxcCmGiGprEEhMTLey77BapdCaOtY4SBvHzXG8jPdQXVZXo6 wyuDyzICermixqWewd9ruLmv3HNt7mStlyjF3WCLZ5wVp30WCSPEAvdTSBbtF6bv69tMTbM1lQwo4 11wtHkMHZxEoRGTNBxkc0DDn9pRU9L00i6HP9GEnl5RnlO5DYB9JXjqTvijtBq0rZL0QNd+p9pgPT HePtSv1H4s75/oP6p5Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCF7C-00HJML-2k; Thu, 22 Jun 2023 07:52:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCF7B-00HJLU-0e; Thu, 22 Jun 2023 07:52:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BE3361786; Thu, 22 Jun 2023 07:52:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96C66C433C0; Thu, 22 Jun 2023 07:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687420343; bh=e9NKgW3oClf65wHR4jFOmp3+UsGr7YxDei5mvCWN0/Q=; h=From:To:Cc:Subject:Date:From; b=kqihgs3ppcJWf2G4dcgyCAVIslHMHejpAq+er43v44mJ58HvXOd/87MuZrMNRSIaJ dzZkx9G3J2fMFjvm6JKXjxzR9VSlh894TP6vVMrS0iuxJ6FgejbN1tAOzPbceGORyM TQXU33JRziUcUIooDdCkQcCvRRPqpqAIljhsgY0Fmxtaw6qEZk8dMBtIdAHQWsABfL Sg1DaKrhV17anw+wcLRzrwC3GIfqaA1+OWXRCQQug5TSP5UDryUi9+1/pSgyTRQ6NI Gj4/oyqpS+xezpgHVtaa0SiydAky/D/Q0mRHfSOU0EFH+RR9hSQ1kZ+YB1TrZEITss 1A67IYbfo2hDA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qCF7F-0000Ev-07; Thu, 22 Jun 2023 09:52:29 +0200 From: Johan Hovold To: Sean Wang , Vinod Koul Cc: Matthias Brugger , AngeloGioacchino Del Regno , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] dmaengine: mediatek: drop bogus pm_runtime_set_active() Date: Thu, 22 Jun 2023 09:51:50 +0200 Message-Id: <20230622075150.885-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_005225_304025_88EBC6EB X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The runtime PM state must be updated while runtime PM is disabled for the change to take effect. Drop the bogus pm_runtime_set_active() which left the PM state set to suspended (as it should be or the clock would not be enabled when the device is resumed). Signed-off-by: Johan Hovold --- drivers/dma/mediatek/mtk-uart-apdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c index a1517ef1f4a0..92864c9371a3 100644 --- a/drivers/dma/mediatek/mtk-uart-apdma.c +++ b/drivers/dma/mediatek/mtk-uart-apdma.c @@ -551,7 +551,6 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev) } pm_runtime_enable(&pdev->dev); - pm_runtime_set_active(&pdev->dev); rc = dma_async_device_register(&mtkd->ddev); if (rc) -- 2.39.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel