From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>,
linux-spi@vger.kernel.org,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/3] spi: Helper for deriving timeout values
Date: Thu, 22 Jun 2023 23:18:02 +0200 [thread overview]
Message-ID: <20230622231802.42b38b96@xps-13> (raw)
In-Reply-To: <2686152.mvXUDI8C0e@jernej-laptop>
Hi Jernej,
jernej.skrabec@gmail.com wrote on Thu, 22 Jun 2023 18:46:27 +0200:
> Dne četrtek, 22. junij 2023 ob 11:06:31 CEST je Miquel Raynal napisal(a):
> > Hello,
> >
> > I recently came across an issue with the Atmel spi controller driver
> > which would stop my transfers after a too small timeout when performing
> > big transfers (reading a 4MiB flash in one transfer). My initial idea
> > was to derive a the maximum amount of time a transfer would take
> > depending on its size and use that as value to avoid erroring-out when
> > not relevant. Mark wanted to go further by creating a core helper doing
> > that, based on the heuristics from the sun6i driver.
> >
> > Here is a small series of 3 patches doing exactly that.
> >
> > Cheers,
> > Miquèl
> >
> > Changes in v3:
> > * Collected a tag.
>
> Did you? I don't see my a-b at patch 3.
I thought I did, sorry if I missed it. Do you mind re-sending it?
>
> Best regards,
> Jernej
>
> > * As my platform runs on 6.1 currently, I cherry-picked a mainline patch
> > changing s/master/host/ in the atmel controller driver and modified the
> > series to fit the new naming. I then cherry-picked my three patches and
> > verified it compiled correctly against a v6.4-rc1.
> >
> > Miquel Raynal (3):
> > spi: Create a helper to derive adaptive timeouts
> > spi: atmel: Prevent false timeouts on long transfers
> > spi: sun6i: Use the new helper to derive the xfer timeout value
> >
> > drivers/spi/spi-atmel.c | 18 +++++++++++-------
> > drivers/spi/spi-sun6i.c | 2 +-
> > include/linux/spi/spi.h | 17 +++++++++++++++++
> > 3 files changed, 29 insertions(+), 8 deletions(-)
> >
> >
>
>
>
>
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-22 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 9:06 [PATCH v3 0/3] spi: Helper for deriving timeout values Miquel Raynal
2023-06-22 9:06 ` [PATCH v3 1/3] spi: Create a helper to derive adaptive timeouts Miquel Raynal
2023-06-22 9:06 ` [PATCH v3 2/3] spi: atmel: Prevent false timeouts on long transfers Miquel Raynal
2023-06-22 16:29 ` Ryan.Wanner
2023-06-22 9:06 ` [PATCH v3 3/3] spi: sun6i: Use the new helper to derive the xfer timeout value Miquel Raynal
2023-06-22 16:46 ` [PATCH v3 0/3] spi: Helper for deriving timeout values Jernej Škrabec
2023-06-22 21:18 ` Miquel Raynal [this message]
2023-06-23 0:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622231802.42b38b96@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox