From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66716EB64DA for ; Sat, 24 Jun 2023 09:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ARL8Z+zC50ljCKYdmZB09tNF46u6HGs8HHmjuRLMvC4=; b=gP7N2sVGBSz8ha0lmNOYpOl1ID 1Hw8T97t7eirDzJVIDE+i7uwcyfStcOQ6VY9zJSnlA4bVQfL6yBGP7BwBLGyWybGE7hNN/M6LnIax D+hSZ2kgZGQrfv3ETDkBMsF33KmvVxU+N0ZosXd5mNmFuV0ij1pdpUJ2QiVt3EJWESFJ5IStgFnKZ iALEpMx/3Qe2+k7v02/hOIkCgzx4U81OqdNICKWRpcXFgGbuQTx/Xzt0I8pj2HpK6l5ibbd5ZPnsF llmR8mJ19XfBWDF9RpmzRunyJu3QiG1pEy4zOGgLndmBBuAuOCR5le/PRzngEyeDm6ac8yiUO2CZx DNnL5YQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCzZH-005dmu-0X; Sat, 24 Jun 2023 09:28:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCzZE-005dmL-14 for linux-arm-kernel@lists.infradead.org; Sat, 24 Jun 2023 09:28:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A301C60C4F; Sat, 24 Jun 2023 09:28:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52C97C433C0; Sat, 24 Jun 2023 09:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687598907; bh=LxXDcbLJc1zSmgzEDzBM0Y/eWiAZ7Drimq7fAAeDJRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cd3laRtKsLBk8T2MjxZCLJ93vWD0QNIiyHG64tT0CTReINsyZ2yiZ0cyXYbelvEXR Yy7Wpddh5JYC2AcPazLR/XX/ExQesued1zaY7AOUkmMSLvpaJTAzdkQ2Lqcs3w/4e3 HaPfRgnOpUlF54OSu7jJxPCMKd6CnClu0L1F4CnA5Jvr1R56GC7TL6w0JWlYy5dLVC vXTWGn82lO2qhMBb6gg4EAhrMRVBR0CfkDrhpRL4cz8Man1yc0t9ZGlhedLmkfYqoT VJhLCOSNrcl0nQZiiA7Ed0xLm+rN6XespLxso0ZuIg7pFH8Z4OmtNDGKMsu3uYbchj 13NTqEEAkPG9A== Date: Sat, 24 Jun 2023 10:28:22 +0100 From: Conor Dooley To: Krzysztof Kozlowski Subject: Re: [PATCH] spi: dt-bindings: atmel,at91rm9200-spi: fix broken sam9x7 compatible Message-ID: <20230624-embassy-scuff-9fdc0f150d1a@spud> References: <20230624082054.37697-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 In-Reply-To: <20230624082054.37697-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230624_022828_447078_DC634793 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Conor Dooley , Rob Herring , Tudor Ambarus , Mark Brown , Krzysztof Kozlowski , Varshini Rajendran , linux-spi@vger.kernel.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6953599612086752931==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6953599612086752931== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bwrTTO9opmPzEFoX" Content-Disposition: inline --bwrTTO9opmPzEFoX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 24, 2023 at 10:20:54AM +0200, Krzysztof Kozlowski wrote: > Commit a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 > compatible") adding sam9x7 compatible did not make any sense as it added > new compatible into middle of existing compatible list. The intention > was probably to add new set of compatibles with sam9x7 as first one. >=20 > Fixes: a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 = compatible") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Conor Dooley @Varshini, this is the template to follow for the rest of the series. I know there's a lot of complaints while running dtbs_check for the entire directory, but you can isolate things to a singular binding and check the dts against it using: make dtbs_check DT_SCHEMA_FILES=3Datmel,at91rm9200-spi.yaml That should make it easier to see that you don't break existing dts by modifying the binding. Cheers, Conor. > --- > .../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.y= aml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > index bdc42eeacba4..58367587bfbc 100644 > --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > @@ -19,7 +19,10 @@ properties: > - const: atmel,at91rm9200-spi > - items: > - const: microchip,sam9x60-spi > + - const: atmel,at91rm9200-spi > + - items: > - const: microchip,sam9x7-spi > + - const: microchip,sam9x60-spi > - const: atmel,at91rm9200-spi > =20 > reg: > --=20 > 2.34.1 >=20 --bwrTTO9opmPzEFoX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJa3NQAKCRB4tDGHoIJi 0g0eAP9R9uhyfBlfuOXjh+drak8V4k0CqR/F+9JXOOjXjGIDXAD9FaRriN4gGH6z ykN2QwJ/0oMeGcfsAPeXfFu5o0gzDQw= =tkPS -----END PGP SIGNATURE----- --bwrTTO9opmPzEFoX-- --===============6953599612086752931== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6953599612086752931==--