[PATCH 00/15] PCI: Convert to platform remove callback returning void

Uwe Kleine-König
2023-03-21T19:36:39Z

Hello,

this series adapts the platform drivers below drivers/pci to use the
.remove_new() callback. Compared to the traditional .remove() callback
.remove_new() returns no value. This is a good thing because the driver core
doesn't (and cannot) cope for errors during remove. The only effect of a
non-zero return value in .remove() is that the driver core emits a warning. The
device is removed anyhow and an early return from .remove() usually yields a
resource leak.

By changing the remove callback to return void driver authors cannot
reasonably assume any more that there is some kind of cleanup later.

All drivers were easy to convert as they all returned zero in their
remove callback. Only for iproc the conversion wasn't trivial, the other
were converted using coccinelle.

There are no interdependencies between these patches. So even if there
are some concerns for individual patches, I ask you to apply the
remaining set. Then I only have to care for the review feedback of the
refused patches. (Having said that I don't expect any serious objection,
just things like squashing or separating patches, or maybe I picked a
wrong subject prefix.)

Best regards
Uwe

Uwe Kleine-König (15):
PCI: aardvark: Convert to platform remove callback returning void
PCI: altera: Convert to platform remove callback returning void
PCI: altera-msi: Convert to platform remove callback returning void
PCI: brcmstb: Convert to platform remove callback returning void
PCI: cadence/j721e: Convert to platform remove callback returning void
PCI: dwc/*: Convert to platform remove callback returning void
PCI: hisi-error: Convert to platform remove callback returning void
PCI: iproc: Convert to platform remove callback returning void
PCI: mediatek: Convert to platform remove callback returning void
PCI: mediatek-gen3: Convert to platform remove callback returning void
PCI: mt7621: Convert to platform remove callback returning void
PCI: mvebu: Convert to platform remove callback returning void
PCI: rockchip-host: Convert to platform remove callback returning void
PCI: tegra: Convert to platform remove callback returning void
PCI: xgene-msi: Convert to platform remove callback returning void

drivers/pci/controller/cadence/pci-j721e.c | 6 ++----
drivers/pci/controller/dwc/pcie-bt1.c | 6 ++----
drivers/pci/controller/dwc/pcie-histb.c | 6 ++----
drivers/pci/controller/dwc/pcie-intel-gw.c | 6 ++----
drivers/pci/controller/dwc/pcie-qcom-ep.c | 8 +++-----
drivers/pci/controller/dwc/pcie-tegra194.c | 8 +++-----
drivers/pci/controller/pci-aardvark.c | 6 ++----
drivers/pci/controller/pci-mvebu.c | 6 ++----
drivers/pci/controller/pci-tegra.c | 6 ++----
drivers/pci/controller/pci-xgene-msi.c | 6 ++----
drivers/pci/controller/pcie-altera-msi.c | 5 ++---
drivers/pci/controller/pcie-altera.c | 6 ++----
drivers/pci/controller/pcie-brcmstb.c | 6 ++----
drivers/pci/controller/pcie-hisi-error.c | 6 ++----
drivers/pci/controller/pcie-iproc-platform.c | 6 +++---
drivers/pci/controller/pcie-iproc.c | 4 +---
drivers/pci/controller/pcie-iproc.h | 2 +-
drivers/pci/controller/pcie-mediatek-gen3.c | 6 ++----
drivers/pci/controller/pcie-mediatek.c | 6 ++----
drivers/pci/controller/pcie-mt7621.c | 6 ++----
drivers/pci/controller/pcie-rockchip-host.c | 6 ++----
21 files changed, 43 insertions(+), 80 deletions(-)

base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
--
2.39.2