From: Conor Dooley <conor.dooley@microchip.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Xianwei Zhao <xianwei.zhao@amlogic.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-amlogic@lists.infradead.org>, <devicetree@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400
Date: Tue, 27 Jun 2023 08:25:58 +0100 [thread overview]
Message-ID: <20230627-pledge-recapture-7b17cc1c3c20@wendy> (raw)
In-Reply-To: <9b49e979-4a24-f628-88c4-fd53f53d46e4@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]
On Mon, Jun 26, 2023 at 05:41:05PM +0200, Krzysztof Kozlowski wrote:
> On 26/06/2023 11:52, Xianwei Zhao wrote:
> > +
> > + apb4: bus@fe000000 {
> > + compatible = "simple-bus";
> > + reg = <0x0 0xfe000000 0x0 0x480000>;
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
> > +
> > + uart_a: serial@78000 {
> > + compatible = "amlogic,meson-s4-uart",
> > + "amlogic,meson-ao-uart";
> > + reg = <0x0 0x78000 0x0 0x18>;
> > + interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> > + status = "disabled";
>
> Please, don't put status in the middle of properties...
The serial entry is also missing the soc specific compatible (and
removal of the always-on uart) that was discussed in Lucas Tanure's
series.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-27 7:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 9:52 [PATCH 0/2] Baisc devicetree support for Amlogic T7 Xianwei Zhao
2023-06-26 9:52 ` [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings Xianwei Zhao
2023-06-26 15:38 ` Krzysztof Kozlowski
2023-06-27 2:27 ` Xianwei Zhao
2023-06-27 2:30 ` Xianwei Zhao
2023-06-27 8:56 ` Christian Hewitt
2023-06-27 9:02 ` Xianwei Zhao
2023-06-26 9:52 ` [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400 Xianwei Zhao
2023-06-26 15:41 ` Krzysztof Kozlowski
2023-06-27 2:47 ` Xianwei Zhao
2023-06-27 7:25 ` Conor Dooley [this message]
2023-06-26 10:02 ` [PATCH 0/2] Baisc devicetree support for Amlogic T7 Conor Dooley
2023-06-27 6:13 ` Xianwei Zhao
2023-06-27 7:23 ` Conor Dooley
2023-06-27 7:51 ` Xianwei Zhao
2023-06-29 16:33 ` Lucas Tanure
2023-06-30 2:21 ` Xianwei Zhao
2023-06-30 4:39 ` Lucas Tanure
2023-06-27 7:43 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627-pledge-recapture-7b17cc1c3c20@wendy \
--to=conor.dooley@microchip.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox