From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 841A2EB64D9 for ; Tue, 27 Jun 2023 10:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UOvCLj7hr2hiHECbmYeIGmpu1LwmSaP2N5nFhkAuNv4=; b=ml/tILXzIDcbQ6 R6ZYc+kgWv+aZ+OGYspKm5t1UfQJAiCfhyJqT/+0sPHItGsjoeaYY3zFpfoI1A7xWAa4KXbA/VsQw unK+rANrDQJkIPnhx+/obHBUmyhUdMpp4PRjJL+q1k6Rkyh2H4M8EtnyiH3zhcfdEEmnKdmJl7jjp FnfFD13CAnN7fsBkLtGym3Pk+5LtJrY4KbOYPXBgEVHmw/cpZMgBvYVEVkJcgqAG6wHKWubuV2Byd z9ShYtbfbg7N6g628AZJgJEm/j4jKeojHeK9hSLeQ7IcOfRZ8B8u6oEP5cKUD2HwLGyEWr3iM1KXA 6vNiAzTY0+KoaftOJLjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE5s6-00Cp9L-1N; Tue, 27 Jun 2023 10:24:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qE5s4-00Cp83-0d for linux-arm-kernel@lists.infradead.org; Tue, 27 Jun 2023 10:24:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6982461085; Tue, 27 Jun 2023 10:24:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D5F7C433C9; Tue, 27 Jun 2023 10:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687861466; bh=F1Hg7UsWABbNZA5AQvDBMQsjEQe6h9OaplyEUWz37bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V2NwjqsUMcDX/nRTxfVAJKchvBq0J8/jCjoiPE/BVWSq5g708DSLg16ic9OHGuGIA yuU5bxvGd6YG+SSKFuayAVa/x5wvWepMKMdGGFdgfHwAvR+pb341M0KuWKavjeak5J sma7fq1Z3LAEcoV/YQiR7MTXGlucUZab2xSmpk5M= Date: Tue, 27 Jun 2023 12:24:24 +0200 From: Greg Kroah-Hartman To: Petr Tesarik Cc: Stefano Stabellini , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Andy Shevchenko , Hans de Goede , Jason Gunthorpe , Kees Cook , Saravana Kannan , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" , Roberto Sassu , Kefeng Wang , petr@tesarici.cz Subject: Re: [PATCH v3 1/7] swiotlb: make io_tlb_default_mem local to swiotlb.c Message-ID: <2023062745-routing-palace-d0b4@gregkh> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230627_032428_277005_7643737F X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 27, 2023 at 11:54:23AM +0200, Petr Tesarik wrote: > +/** > + * is_swiotlb_active() - check if the software IO TLB is initialized > + * @dev: Device to check, or %NULL for the default IO TLB. > + */ > bool is_swiotlb_active(struct device *dev) > { > - struct io_tlb_mem *mem = dev->dma_io_tlb_mem; > + struct io_tlb_mem *mem = dev > + ? dev->dma_io_tlb_mem > + : &io_tlb_default_mem; That's impossible to read and maintain over time, sorry. Please use real "if () else" lines, so that it can be maintained over time. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel