Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: Bhavya Kapoor <b-kapoor@ti.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
	<kristo@kernel.org>, <vigneshr@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2-main: Enable support for SDR104 speed mode
Date: Wed, 28 Jun 2023 05:59:11 -0500	[thread overview]
Message-ID: <20230628105911.rdpqwxuhshgaj2ik@kobold> (raw)
In-Reply-To: <7fe4adef-9be2-6dae-d53f-692f9775439c@ti.com>

On 13:50-20230628, Kumar, Udit wrote:
> 
> On 4/12/2023 5:44 PM, Bhavya Kapoor wrote:
> > According to TRM for J721S2, SDR104 speed mode is supported by the SoC
> > but its capabilities were masked in device tree. Remove sdhci-caps-mask
> > to enable support for SDR104 speed mode for SD card in J721S2 SoC.
> > 
> > [+] Refer to : section 12.3.6.1.1 MMCSD Features, in J721S2 TRM
> > - https://www.ti.com/lit/zip/spruj28
> > 
> > Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> > ---
> > Changelog v1->v2:
> > 	- Modified Commit Message and Added Fixes tag
> > 
> > Link to v1 : https://lore.kernel.org/all/20230404091245.336732-1-b-kapoor@ti.com/
> > 
> >   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > index 8915132efcc1..95c6151ed10c 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > @@ -400,8 +400,6 @@ main_sdhci1: mmc@4fb0000 {
> >   		ti,clkbuf-sel = <0x7>;
> >   		ti,trm-icp = <0x8>;
> >   		dma-coherent;
> > -		/* Masking support for SDR104 capability */
> > -		sdhci-caps-mask = <0x00000003 0x00000000>;
> 
> 
> Reviewed-by: Udit Kumar <u-kumar1@ti.com>

Please confirm if there are any changes in *tap-delay attributes.
> 
> >   	};
> >   	main_navss: bus@30000000 {

--
Regards,
Nishanth Menon

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-28 10:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 12:14 [PATCH v2] arm64: dts: ti: k3-j721s2-main: Enable support for SDR104 speed mode Bhavya Kapoor
2023-06-28  8:20 ` Kumar, Udit
2023-06-28 10:59   ` Nishanth Menon [this message]
2023-06-29  5:29     ` Bhavya Kapoor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230628105911.rdpqwxuhshgaj2ik@kobold \
    --to=nm@ti.com \
    --cc=b-kapoor@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox