From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A251BEB64D7 for ; Wed, 28 Jun 2023 16:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FmqtbDfgKSQhHnLaY64XDWjJ6PrE6IEHd0Z2c3C7Bl8=; b=Kha3QTU10G6InY WaiydoHd+KSxC6iRE+wcCDrEbhDN2afo78LG7lVV9MEhwr1mx4mqWecpmYTvUyWapB/LM0pK4NZN2 5AREbX9kjxGZ0rSnmych4ij8eoWtXmrIF72mpnveu14hrBIuYlMdPCPGfJIhz7vGYvIWI4goe2Z2l YzMCvVrE5NKcJ6D6zi0Tk0n8yPeSoOR+Pkgsm2GV6Hk0EyY1InSLGPXBxiqwIaIrj4fVZowa3jTW4 8TrSWXBR8ARpgTvRw/qX+CEjbu9jDyl1pKMvVsg5msjEQdwUV8H+0cmLr7ubnnSTt2XA7BSNGzX8M 35BO2yHjB0PzYiivW/Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEXnp-00G5cu-27; Wed, 28 Jun 2023 16:13:57 +0000 Received: from mail-io1-f51.google.com ([209.85.166.51]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEXnm-00G5bk-1A; Wed, 28 Jun 2023 16:13:56 +0000 Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7836e80b303so4209739f.0; Wed, 28 Jun 2023 09:13:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687968833; x=1690560833; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UNCgrN2Ev9LAjc1TYI8mAnRmahIC/Joz+LgDtYAovIM=; b=DDXUE2S7mmPes7tPYDPVkLgc0SMIHBWyaadr73dw96+b1CzWLTv6ExUNo3BkySE48P 6PaWWfVrX+GZgoxp9Ha8f0CTolXIhZDqtzXKiPHLyZiMMOwW5tX97ng8NQK5FeO+6/wI Kq/BiX4k5VGRbJZMUPpnTWot2G7GCyOHDkZt5lyYvk2g50851lqBQBiRao7dX3HzVRkS gUYNT5uKxn3T3Rw/O8oXXZPHe6YOuhSAc9j1ABloc7xVaSOliUdv9lHIcRKHpn8d/rZ0 zx6GALJP1Tl62EFjm2+ZLn6YlLLKIjwXONktp3t+b8GWijn943186Q34cM9a9FMaM2Hu JMIA== X-Gm-Message-State: AC+VfDxhKiMwaFcil3PVTvnLcZiJQh2I08hfn1aJ1ocXSPy0EQrLN1Dv wt9hjuqizEZpfZ3urJT/k9NdtSpEBA== X-Google-Smtp-Source: ACHHUZ7gIrH8Qif+o4s4mpLJ1PjMye/7thQ3X6jQMeFF1KjdG1/ZUyuwxUHvKk23FRnOol3wT6tXyg== X-Received: by 2002:a05:6602:1310:b0:786:25a3:ef30 with SMTP id h16-20020a056602131000b0078625a3ef30mr1326529iov.7.1687968833203; Wed, 28 Jun 2023 09:13:53 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id dq34-20020a0566384d2200b0042566919376sm3151279jab.30.2023.06.28.09.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 09:13:52 -0700 (PDT) Received: (nullmailer pid 565403 invoked by uid 1000); Wed, 28 Jun 2023 16:13:49 -0000 Date: Wed, 28 Jun 2023 10:13:49 -0600 From: Rob Herring To: Julien Stephan Cc: Louis Kuo , Phi-Bang Nguyen , Laurent Pinchart , Alexander Gordeev , Andy Hsieh , AngeloGioacchino Del Regno , Conor Dooley , daoyuan huang , devicetree@vger.kernel.org, Florian Sylvestre , Hans Verkuil , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, Matthias Brugger , Mauro Carvalho Chehab , Moudy Ho , Ping-Hsun Wu , Vasily Gorbik Subject: Re: [PATCH 1/4] dt-bindings: media: add mediatek ISP3.0 sensor interface Message-ID: <20230628161349.GA557442-robh@kernel.org> References: <20230628145412.1610260-1-jstephan@baylibre.com> <20230628145412.1610260-2-jstephan@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230628145412.1610260-2-jstephan@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_091354_425181_748AFDBD X-CRM114-Status: GOOD ( 26.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 28, 2023 at 04:52:52PM +0200, Julien Stephan wrote: > From: Louis Kuo > > This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > some Mediatek SoC, such as the mt8365 > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-Bang Nguyen > Signed-off-by: Laurent Pinchart > Signed-off-by: Julien Stephan > --- > .../media/mediatek,mt8365-seninf.yaml | 299 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 306 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > new file mode 100644 > index 000000000000..a54f785bb252 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > @@ -0,0 +1,299 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 MediaTek, BayLibre > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Sensor Interface 3.0 > + > +maintainers: > + - Laurent Pinchart > + - Julien Stephan > + - Andy Hsieh > + > +description: > + The ISP3.0 SENINF is the CSI-2 and parallel camera sensor interface found in > + multiple MediaTek SoCs. It can support up to three physical CSI-2 > + input ports, configured in DPHY (2 or 4 data lanes) or CPHY depending on the soc. > + On the output side, SENINF can be connected either to CAMSV instance or > + to the internal ISP. CAMSV is used to bypass the internal ISP processing > + in order to connect either an external ISP, or a sensor (RAW, YUV). > + > +properties: > + compatible: > + const: mediatek,mt8365-seninf > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + clocks: > + items: > + - description: Seninf camsys clock > + - description: Seninf top mux clock > + > + clock-names: > + items: > + - const: cam_seninf _seninf is redundant as that is the block name. 'camsys' perhaps based on the description. > + - const: top_mux_seninf top_mux > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI0 or CSI0A port > + > + properties: > + phys: > + maxItems: 1 > + description: phandle to the PHY connected to CSI0/CSI0A 'port' nodes shouldn't have properties. This goes in the top level. > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI1 port > + > + properties: > + phys: > + maxItems: 1 > + description: phandle to the PHY connected to CSI1 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@2: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI2 port > + > + properties: > + phys: > + maxItems: 1 > + description: phandle to the PHY connected to CSI2 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@3: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI0B port > + > + properties: > + phys: > + maxItems: 1 > + description: phandle to the PHY connected to CSI0B > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 2 > + > + port@4: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: connection point for cam0 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# Are you using any properties from here? If not, you just need to reference graph.yaml#/properties/port. > + unevaluatedProperties: false > + > + port@5: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: connection point for cam1 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + port@6: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: connection point for camsv0 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + port@7: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: connection point for camsv1 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + port@8: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: connection point for camsv2 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + port@9: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: connection point for camsv3 > + > + patternProperties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + required: > + - port@0 > + - port@1 > + - port@2 > + - port@3 > + - port@4 > + - port@5 > + - port@6 > + - port@7 > + - port@8 > + - port@9 > + > +required: > + - compatible > + - interrupts > + - clocks > + - clock-names > + - power-domains > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + seninf: seninf@15040000 { > + compatible = "mediatek,mt8365-seninf"; > + reg = <0 0x15040000 0 0x6000>; > + interrupts = ; > + clocks = <&camsys CLK_CAM_SENIF>, > + <&topckgen CLK_TOP_SENIF_SEL>; > + clock-names = "cam_seninf", "top_mux_seninf"; > + > + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + phys = <&mipi_csi0 PHY_TYPE_DPHY>; > + seninf_in1: endpoint { > + clock-lanes = <2>; > + data-lanes = <1 3 0 4>; > + remote-endpoint = <&isp1_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + }; > + > + port@2 { > + reg = <2>; > + }; > + > + port@3 { > + reg = <3>; > + }; > + > + port@4 { > + reg = <4>; > + seninf_camsv1_endpoint: endpoint { > + remote-endpoint = <&camsv1_endpoint>; > + }; > + }; > + > + port@5 { > + reg = <5>; > + }; > + > + port@6 { > + reg = <6>; > + }; > + > + port@7 { > + reg = <7>; > + }; > + > + port@8 { > + reg = <8>; > + }; > + > + port@9 { > + reg = <9>; > + }; > + > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index e505023ffda1..1248a915a72f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13256,6 +13256,13 @@ M: Sean Wang > S: Maintained > F: drivers/char/hw_random/mtk-rng.c > > +MEDIATEK ISP3.0 DRIVER > +M: Laurent Pinchart > +M: Julien Stephan > +M: Andy Hsieh > +S: Supported > +F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > + > MEDIATEK SMI DRIVER > M: Yong Wu > L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) > -- > 2.41.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel