From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EA40EB64DD for ; Thu, 29 Jun 2023 20:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9RpEMgxuQyLBdok8tZjHiDjretObLfFgoSzadmagUYE=; b=gYmodn7i8EsaQrUCrKj8Kn82qz +taankzpo/8N/RZUNuChjzUH7KvFpXCEohvGVGZjJz4Q+54vR0tg0BqfpwrUo+ol7i1Wjcd/8l6hk jjqGtKZUPybv2Tu4hOr4F1fAiguRvda8HluTOpwmpGtcipsawgadLnUH5Wmqqcxm6pgwawIYnjG7/ zTc3PvvuUqwSx4r69g3Bd4z1SIWx1GEcNLre51of57SHBJokcd94vrZAh53ipW3S1dLg54jo/FPy/ wrxqDRuCPQOxkY2jKo8T0ovT4UtTkf4Y+eY0vLN9apvY7isRQbioF+/hWTnVvqrWCtrkPeWXzMb6f GkFke5aA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEyIF-0025PY-0Z; Thu, 29 Jun 2023 20:31:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEyIC-0025O4-0P; Thu, 29 Jun 2023 20:31:05 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91032615C5; Thu, 29 Jun 2023 20:31:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF2F6C433C0; Thu, 29 Jun 2023 20:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688070661; bh=FCckL39hhcHT57R5uYeNPhUQQwIFbfubCkljbMtdAYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pMFxkZiZLQWOpfqIBlL5paN6vadf1xSqWH3B6cDg6kABJyAg2i8HrcsxL+IhRhc0c IOsoaOZu0zbuIODy6l6FoTHHpq97rmxDSXrvRNyxm/OHUCmVsrMR653cFN6ahVNpTM qUd669BbNdNkLyY3fRbgT5zD0BnZr4hNzl0RoX3x1P6/2OqZpbkQ1d63XJZ/ejlh6p boHl0SpSzSuZt0ysN/UtfNgjKS7v8M5iSNITjGA6KX694kD0PBJgItkHBPOFCxpKfi afmfzOc80had61Fthbtb8M8adSHUjeyO/MtIhmUUkCmPeeKLBVaXgvn6KgA/8ENsPt bHcWmAI5xLtKg== Date: Thu, 29 Jun 2023 21:30:55 +0100 From: Conor Dooley To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Yue Wang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Srikanth Thokala , Daire McNamara , Conor Dooley , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 3/3] PCI: microchip: Remove cast between incompatible function type Message-ID: <20230629-smirk-resample-6741dcf9eac5@spud> References: <20230629165956.237832-1-kwilczynski@kernel.org> <20230629165956.237832-3-kwilczynski@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230629165956.237832-3-kwilczynski@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230629_133104_245553_B59BA6DD X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6160364762718055282==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6160364762718055282== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1tORRD56oX7m24Ur" Content-Disposition: inline --1tORRD56oX7m24Ur Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 29, 2023 at 04:59:56PM +0000, Krzysztof Wilczy=C5=84ski wrote: > Rather than casting void(*)(struct clk *) to void (*)(void *), that > forces conversion to an incompatible function type, replace the cast > with a small local stub function with a signature that matches what > the devm_add_action_or_reset() function expects. >=20 > The sub function takes a void *, then passes it directly to > clk_disable_unprepare(), which handles the more specific type. >=20 > Reported by clang when building with warnings enabled: >=20 > drivers/pci/controller/pcie-microchip-host.c:866:32: warning: cast from= 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible fu= nction type [-Wcast-function-type-strict] > devm_add_action_or_reset(dev, (void (*) (void *))clk_disable_un= prepare, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~ > No functional changes are intended. >=20 > Fixes: 6f15a9c9f941 ("PCI: microchip: Add Microchip PolarFire PCIe contro= ller driver") > Co-developed-by: Daire McNamara > Signed-off-by: Daire McNamara > Co-developed-by: Simon Horman > Signed-off-by: Simon Horman > Signed-off-by: Krzysztof Wilczy=C5=84ski This looks to be the same content wise as the patch I previously acked & effectively the same as the one I previously reviewed - you could have picked up either of those tags from the other submissions tbh. Acked-by: Conor Dooley Cheers, Conor. --1tORRD56oX7m24Ur Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJ3p/wAKCRB4tDGHoIJi 0nbtAP4sy4P0Oru7YzNbLHMrWLhkwYJyOVKPMFqjwd0yIUAjLAD+M46rYMGjK+Se VSqbMkFjW4dHvnCRoYjmNpzWoWvKUAc= =eJrt -----END PGP SIGNATURE----- --1tORRD56oX7m24Ur-- --===============6160364762718055282== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6160364762718055282==--