From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 942ABEB64DA for ; Fri, 30 Jun 2023 21:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=wlFvNRSyFeZERVLrcb/eF+8o+dOZawyFX1r1SOpixOc=; b=wwUjPoRy/LNQkH dQHXj/+DJ+0BSR/z6oLshzbKFT+sUHFOsJdZwDBIsUMgY5gX60eUrHXSklD3zoaAUviHjxByXHbqh jFhb8UzryKNH3nkDOYXSsuItQzkwQ29eUD2yUjk4JwTxhGq3+tJQZUCfpiWwWyX2n4FbgZQlp43HA oq8OIeonuygYexWCcWGzgVxQTLMRGCOYysw+6+Ngik9rL+UDuHMcT4D/LhMmc9XByMBp5unlNwcF1 wjlLvsc3ypjnLX3XUr/c33Hc60IRpjGc7Q4aVcdi8l+qu3w8RHSWCQIqpFxbg5LYjpYAWYWLLu7XP uXEy9XkA+O2qi6BX5dtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qFLzk-004cbk-23; Fri, 30 Jun 2023 21:49:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qFLzh-004cbH-1w for linux-arm-kernel@lists.infradead.org; Fri, 30 Jun 2023 21:49:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4CB76181A; Fri, 30 Jun 2023 21:49:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F231DC433C8; Fri, 30 Jun 2023 21:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688161772; bh=nwvYl376FTCG3QHJncLs4AS9k0pbesWjAIyl6ONM498=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=FVzDJFNo8Kfe1Y9U1al2N/AQc+AcvDWoTkJfYvvhwlm4KmN0lWaaOD6U4CQfg1Ckm ufOPr+9q4bPnek4s1RNLYQbAJ3Imq6sYNOT7RCib1TgHyJ/NnyibnKZ+xw1KgXmpQa b2M7gMU6srNlOzYcdTdRdURlyroyIJqacMBFhRhY9YB8VtFrC5Wi0WlTPQRIhm5pDO QUI2/fftob3UxY/madEfAop+mJzeIJSCyBmAWFXyAE9sApN16sEG5IUaGwAxcd8xDO sQuPB9cJ/GKnAPutMwlldZ59uROXrwGjzjy4+PjCpP+uPJzvpEwSEZlOtEGgKnKKLa 3rEh4Jtx4X56Q== Date: Fri, 30 Jun 2023 16:49:30 -0500 From: Bjorn Helgaas To: Thippeswamy Havalige Cc: krzysztof.kozlowski@linaro.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bhelgaas@google.com, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, bharat.kumar.gogada@amd.com, michals@amd.com Subject: Re: [PATCH V5 1/3] Move and rename error interrupt bits to a common header. Message-ID: <20230630214930.GA496585@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230628092812.1592644-2-thippeswamy.havalige@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230630_144933_704502_6B9D37B3 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The subject line needs to contain "PCI: " and the driver name. The subject line also should not end with a period. It looks like some of these interrupt bits are not errors. Mentioned previously at https://lore.kernel.org/r/ZF6SHJ44s4OqPYj4@bhelgaas Suggest this instead: PCI: xilinx-cpm: Move interrupt bit definitions to common header On Wed, Jun 28, 2023 at 02:58:10PM +0530, Thippeswamy Havalige wrote: > Move and rename error interrupt bit macros to a common header file for > code reusability. Suggest this: Rename Xilinx interrupt bit definitions so they are not CPM-specific. Move the definitions to pcie-xilinx-common.h where they can be shared between pcie-xilinx-cpm and the new xilinx-xdma driver. > Move common linux header files for reusability. This sentence is redundant and should be removed. > Signed-off-by: Thippeswamy Havalige > Signed-off-by: Bharat Kumar Gogada Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel