From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6A28EB64DC for ; Mon, 3 Jul 2023 08:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WGaTzQRWmnhqpznh6UWlIz+1mEVLWx70qj0lITZllEo=; b=F+v3vSo7qFQsie IAiF0Rz0V2ELMjUKZE1QRd7ZK+vmcJWblBRBXmitI0/Q79iEkfJe5WsRb9gpBiNGJjkeW3H0rYbrN bTLLKeNQyW+c83u7DEGejUdd4F+Dt2WWSxTq9JGUIwDsLiy5hqlXZgMeGwJHzzmj6ZjyT3yioNEkY 5tYdDfEVFvIkgZlWoyAH73hORTfgNJx2zdgoM/NgAwt3UI5PfRR7AQPLUqty3l+5tRaTM53YKvZ+z tqNOXmymNcZUoG196da6PR87kUBStYG8ZWSSXR+BpWUfe4XpjwkQnYJ42i52XdIlNjXOvBrycvkmy ZA4oWwDP5v06u4uGAXxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGF51-009mZ8-0a; Mon, 03 Jul 2023 08:38:43 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGF4u-009mWo-05 for linux-arm-kernel@lists.infradead.org; Mon, 03 Jul 2023 08:38:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A70660E04; Mon, 3 Jul 2023 08:38:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1266BC433C7; Mon, 3 Jul 2023 08:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688373514; bh=mfQb+DW2VrDZqRE0Km5SJaxQ6Sjgk4SrBlpqdl7/biw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=beDxIaJ+h2DknpSK6Q+RurzNUcXVv9Y8flyu8inV0wPO/2p0lAZJTStnrQpUdGufV 3Vhaffgui5eF+aEzG21jDN9hiQ8yv4PybrHN5EWA2g8wVN4oTrLB4YzG4ZnNwSwUsn KeXC+DxOkIdrvOzweffkcz6fv1oFEZbZtdYn9mcV+giS5a1UPZLmoicfVpPq47dzl0 oFcnzQdbpj589jwXgYhMMqJsuEueaPOmhu+8jL4jL8OTWDD4umZzNJi2Ju5/A9nIkt cEv50LiXqNPATS4uNVHQxuCw9PGzS5OHcNrcbt9PE545ECKxydD7TZsvFobCddt5XM IQy4E2NFHD2mQ== Date: Mon, 3 Jul 2023 10:38:28 +0200 From: Andi Shyti To: Christophe JAILLET Cc: wsa@kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v2] i2c: busses: i2c-nomadik: Remove a useless call in the remove function Message-ID: <20230703083828.jfylmlylszf2lwpy@intel.intel> References: <62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230703_013836_121070_A3C3B433 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christophe, On Fri, Jun 30, 2023 at 11:23:28PM +0200, Christophe JAILLET wrote: > Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of > git://git.pengutronix.de/git/wsa/linux"), there is no more > request_mem_region() call in this driver. > > So remove the release_mem_region() call from the remove function which is > likely a left over. > > There is no details in the above commit log, but at its end we can read: > Conflicts: > drivers/i2c/busses/i2c-nomadik.c > > This may explain why this call has been left here. > > Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux > Signed-off-by: Christophe JAILLET Reviewed-by: Andi Shyti Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel