From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAAABEB64DD for ; Mon, 3 Jul 2023 10:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PckecxRn54B/GZNr9c0g2Wx/Jo8Uijq1shxd5Bi39OM=; b=kb+bJUCthP4Hwh vPZnqQhDxWA177UEMbTGrM9nY3XXzRuhbY2G1Ou4pdcrLgORWEYRn5AqNjzXERX+Lp9zJK4AaUjc2 3E2GtNl2GU672KWj+jd6ct7BmQ8d9iwaqBYzk1lovp9gglqRru9YdVJRICNcBrrdOs5gL7WNbfzOC lxuZTFU62BBYcz/hrJ+paboHCMZ2PvIPhl9NHnEU6y1AbOevZy6JcQfwsF4GTPcr2VkYI4Rb+KlMp JjSK/d4wmGs0sG9mz8USLqtD1g7kmwhIEehnd561CIQj/H8SqKxKeXwzxozXzRbTCxmMsSsSAWNiO z1hVdycp8ZNNtpZporpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGH0N-00AHUO-33; Mon, 03 Jul 2023 10:42:03 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGH0L-00AHSO-2O for linux-arm-kernel@lists.infradead.org; Mon, 03 Jul 2023 10:42:03 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-313e714342cso4989335f8f.0 for ; Mon, 03 Jul 2023 03:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688380917; x=1690972917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cefly1GwtRhN7DQubvj71xCv2sWrmliQoTLwjdvrN3M=; b=cBGWPSPt4tEcCJ69DxyGXWhm20o6MynGAVzAQmcGnp/avie15eGjwOKb8YAoggbdn5 GzUk6s6q1Y87NyRckVTI4CPPAw+yhParh6uFm1XFoM/jnWFqi3FyrodhIe9EsAODU+HQ YF9XsiPuhSA2Z/nexgJCcuW+2yhHYKGNGIJKxe+VeXQ4R4PthI5iBtXI9DIg3oIOCaoW Hp1C6sFTzL7LXJRHNsj/rwuLdyuIPnphoPwuK3G8Qzvq0teH+c9or6kpntqpUzbW2ucC zb+akqM49N8H5Cf5fykFQEKPRhqTZUikSjxj00LMI38Gj3mAaX05cDVtYI6dNwiEM57D ndow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688380917; x=1690972917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cefly1GwtRhN7DQubvj71xCv2sWrmliQoTLwjdvrN3M=; b=UUbfzHqOcQ0u07SKRE5C/nAjAKjhqex8/mux0G/Pqh3q0PN8imtbj9QsJ0Z0YVGWuC qybusC4ArhwUJj9hkKYSfhDOwZr9b6T0UuP2/GTvG0/kPaIWj5h6UoUbmTnVPc4m6mv+ ds42i+OlcNmDahBNRWSYHqTnO4Uyf8gxp0jIUI2B4+EnJPTVXRIWY8lK82kvczI5V5EG aGiQM3WWTpZ6hOuBO1U3eqlekzjCUbJIq70kWauF4QztNTJMH53Bz4gczJOF6I2sGpv2 kyU/441IRQlKhsuoFLOZsLPpsWI4vZUYBvtkcr35kpfL4SjbAqoGSJ3AYS8Zby1aiUj1 ZT1g== X-Gm-Message-State: ABy/qLZ9jVDjrgvwq4wk2gSU7+XSDD0nGsKeap2hZqXxohqfJh+2m2WB qV2KgVbd1jUmpQaTYn4HiG6QeQ== X-Google-Smtp-Source: APBJJlHjQY5wS4Wm5OydaNz9HLZuUE94gA3T/csBsXJLJ9RDfVNFA2Z1ykgnyXuPvZ8PBhKd7GQcwQ== X-Received: by 2002:adf:f3c4:0:b0:313:ebf3:850e with SMTP id g4-20020adff3c4000000b00313ebf3850emr8270897wrp.37.1688380917352; Mon, 03 Jul 2023 03:41:57 -0700 (PDT) Received: from myrica ([2.219.138.198]) by smtp.gmail.com with ESMTPSA id b7-20020a5d45c7000000b003141a3c4353sm10606788wrs.30.2023.07.03.03.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 03:41:56 -0700 (PDT) Date: Mon, 3 Jul 2023 11:41:56 +0100 From: Jean-Philippe Brucker To: Mostafa Saleh Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, joro@8bytes.org, robin.murphy@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, dbrazdil@google.com, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev Subject: Re: [RFC PATCH 27/45] KVM: arm64: smmu-v3: Setup domains and page table configuration Message-ID: <20230703104156.GB2439191@myrica> References: <20230201125328.2186498-1-jean-philippe@linaro.org> <20230201125328.2186498-28-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230703_034201_803322_4E0D80ED X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mostafa, On Fri, Jun 23, 2023 at 07:12:05PM +0000, Mostafa Saleh wrote: > > +static int smmu_detach_dev(struct kvm_hyp_iommu *iommu, pkvm_handle_t domain_id, > > + struct kvm_hyp_iommu_domain *domain, u32 sid) > > +{ > > + u64 ttb; > > + u64 *dst; > > + int i, ret; > > + struct hyp_arm_smmu_v3_device *smmu = to_smmu(iommu); > > + > > + dst = smmu_get_ste_ptr(smmu, sid); > > + if (!dst) > > + return -ENODEV; > > + > > + ttb = dst[3] & STRTAB_STE_3_S2TTB_MASK; > This is unused, does detach needs to do anything with ttb? No it doesn't look like I've ever used this, I removed it Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel