From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B852FEB64DC for ; Mon, 3 Jul 2023 12:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0k2h1hdw3REBvy26IoeAJdUgx+j579qeM+1UYrsx6t4=; b=Rmor7wu2QSjlis dj18DhDq8wDu1gTveLWUSPm9X+8xvlpLKAdHcCrncBp1Z8U3E0gi9a5mxkc3ZnRRHJ46gojJ9njhp 5KRgetYwFmEGSWXlYJtmcjFQsCBeT//IP2+H4YWGEWaTpkdYW+ZtxaIMl3KJzXh61Hp4AKS7srmyM BlTfgsL0Q0rAdM9APfQ5Ajdu2lDUM7rm/JSZ94svLQGaLA+48dUcTllVIps5t006niytmnS52taPR HDWk7Sg0fHrcTaFIMn5cFjcqnE45u2oASTsujQtzClNDSNfcYgAnWHQJN4SOfCNR3I4evvyKHjsEX WX2gyq751yIlHZTOsUOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGIM6-00ARUh-1L; Mon, 03 Jul 2023 12:08:34 +0000 Received: from mail-pl1-f170.google.com ([209.85.214.170]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGIM2-00ARTg-1X; Mon, 03 Jul 2023 12:08:32 +0000 Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b7f223994fso34554665ad.3; Mon, 03 Jul 2023 05:08:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688386108; x=1690978108; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J1RQZiBYkGXoDrkdvY5PoVYRfWP/etmDOBicF5bYDcc=; b=Oek2cPXssm8VKE4fnm0zoQz///wrpyaxjtdoYZW1o8leifalcFx4Zp3UukuV5VqI0X xJfEMmIWFRESoCeImZVgL+UaqVT5AimvcFsn7CvkefLReXZAsLJHu5mvTw4pUS7HNhf2 /eMbXN/IqPdqXxkysLFniD6mppNZKjp0n98c2jx2IEMYvY3gq++UiVePw4KbDK/xjACT Vnu6hVsKGYNoYZWmkgLk+TYW3Zo0DirUVKQClP2JTedo1TniJ13ZJalpBEs+hmi54CEa VQ4oTKipD9WAmKfzvlczzfQSnQBrwI1iLtpRETcLCXycmflAgJ06/saiLIvlcpl8AyrN jksw== X-Gm-Message-State: ABy/qLaY5+FZmTs+srAg1ZM67TJpXnq+WpBeLnI1N1dkBNhXR6NYv1FF QLl1Dn0r8OnT7LWYZpa7Iq4= X-Google-Smtp-Source: APBJJlGOY8iLOJXpaCDww1+jpxC7Nbzk13GTYXUcfYjg94j+viCwrcy8jmCZaDeEU/OOaYir/vO6/g== X-Received: by 2002:a17:902:d486:b0:1b2:fa8:d9c9 with SMTP id c6-20020a170902d48600b001b20fa8d9c9mr12966827plg.49.1688386107834; Mon, 03 Jul 2023 05:08:27 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id s12-20020a170902988c00b00198d7b52eefsm15161441plp.257.2023.07.03.05.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 05:08:27 -0700 (PDT) Date: Mon, 3 Jul 2023 21:08:25 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Robin Murphy Cc: Rick Wertenbroek , alberto.dassatti@heig-vd.ch, dlemoal@kernel.org, Dan Carpenter , stable@vger.kernel.org, Shawn Lin , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: rockchip: Use 64-bit mask on MSI 64-bit PCI address Message-ID: <20230703120825.GA2375438@rocinante> References: <20230703085845.2052008-1-rick.wertenbroek@gmail.com> <997819c6-0798-e2f9-b94b-fedfbab7fdd8@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <997819c6-0798-e2f9-b94b-fedfbab7fdd8@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230703_050830_538351_FE5713D3 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, > > A 32-bit mask was used on the 64-bit PCI address used for mapping MSIs. > > This would result in the upper 32 bits being unintentionally zeroed and > > MSIs getting mapped to incorrect PCI addresses if the address had any > > of the upper bits set. > > > > Replace 32-bit mask by appropriate 64-bit mask. [...] > > +#define PCIE_ADDR_MASK GENMASK(63, MIN_AXI_ADDR_BITS_PASSED) > > Nit: this probably wants to be GENMASK_ULL(), otherwise it might throw a > warning if compile-tested for 32-bit. I can change this to GENMASK_ULL() when I apply the patch. Unless Rick wants to send v3 - either way would be fine. :) Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel