From: Conor Dooley <conor@kernel.org>
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, jbrunet@baylibre.com,
jirislaby@kernel.org, khilman@baylibre.com,
martin.blumenstingl@googlemail.com, kelvin.zhang@amlogic.com,
xianwei.zhao@amlogic.com, kernel@sberdevices.ru,
rockosov@gmail.com, linux-amlogic@lists.infradead.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string
Date: Tue, 4 Jul 2023 18:02:58 +0100 [thread overview]
Message-ID: <20230704-cannabis-cannon-19397cd806bc@spud> (raw)
In-Reply-To: <20230704135936.14697-6-ddrokosov@sberdevices.ru>
[-- Attachment #1.1: Type: text/plain, Size: 1666 bytes --]
On Tue, Jul 04, 2023 at 04:59:36PM +0300, Dmitry Rokosov wrote:
> In the current implementation, the meson-a1 configuration incorporates a
> unique compatibility tag "amlogic,meson-a1-uart' within the meson-uart
> driver due to its usage of the new console device name "ttyS".
> Consequently, the previous compatibility tag designated for the
> 'amlogic,meson-gx-uart' configuration has become obsolete and is no
> longer relevant to the current setup.
I don't really see why you would remove the gx-uart to be honest, and
not use it as a fallback. Neil's platform though, so his call :)
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index c5567031ba12..6273b9c862b3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -344,7 +344,7 @@ mux {
> };
>
> uart_AO: serial@1c00 {
> - compatible = "amlogic,meson-gx-uart",
> + compatible = "amlogic,meson-a1-uart",
> "amlogic,meson-ao-uart";
> reg = <0x0 0x1c00 0x0 0x18>;
> interrupts = <GIC_SPI 25 IRQ_TYPE_EDGE_RISING>;
> @@ -354,7 +354,7 @@ uart_AO: serial@1c00 {
> };
>
> uart_AO_B: serial@2000 {
> - compatible = "amlogic,meson-gx-uart",
> + compatible = "amlogic,meson-a1-uart",
> "amlogic,meson-ao-uart";
> reg = <0x0 0x2000 0x0 0x18>;
> interrupts = <GIC_SPI 26 IRQ_TYPE_EDGE_RISING>;
> --
> 2.36.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-04 17:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 13:59 [PATCH v1 0/5] tty: serial: meson: support ttyS devname Dmitry Rokosov
2023-07-04 13:59 ` [PATCH v1 1/5] tty: serial: meson: use dev_err_probe Dmitry Rokosov
2023-07-04 13:59 ` [PATCH v1 2/5] tty: serial: meson: redesign the module to platform_driver Dmitry Rokosov
2023-07-04 14:46 ` neil.armstrong
2023-07-04 15:19 ` Dmitry Rokosov
2023-07-04 17:06 ` Dmitry Rokosov
2023-07-04 13:59 ` [PATCH v1 3/5] tty: serial: meson: apply ttyS devname instead of ttyAML for new SoCs Dmitry Rokosov
2023-07-04 14:42 ` neil.armstrong
2023-07-04 14:59 ` Dmitry Rokosov
2023-07-04 15:29 ` neil.armstrong
2023-07-04 16:00 ` Dmitry Rokosov
2023-07-04 16:57 ` Conor Dooley
2023-07-04 17:13 ` Dmitry Rokosov
2023-07-04 19:14 ` Conor Dooley
2023-07-04 13:59 ` [PATCH v1 4/5] dt-bindings: serial: amlogic,meson-uart: support Amlogic A1 Dmitry Rokosov
2023-07-05 19:00 ` Rob Herring
2023-07-04 13:59 ` [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string Dmitry Rokosov
2023-07-04 17:02 ` Conor Dooley [this message]
2023-07-04 17:08 ` Dmitry Rokosov
2023-07-04 17:10 ` Conor Dooley
2023-07-04 17:19 ` Dmitry Rokosov
2023-07-05 9:46 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704-cannabis-cannon-19397cd806bc@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=ddrokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=kelvin.zhang@amlogic.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox