From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6877EB64DA for ; Tue, 4 Jul 2023 07:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KjaM81MSPNKLLf6kT+jz4KsYto0PmDjLRRy+DLnHdR8=; b=wYZ4SR9V/7ggDx zTuxLJT8c1J1f3WIi/D0Gj32yr8CfJvnkr3UiYkC7pQBcbpJmdPqMP1Om6onytInzWHWHCqG/LLh0 h42sCb5ihoHbModxH+X9rF6+Knk5lr7IROfry0tqFfe78ksWb0Yp2LwkAL0yDv370X3kNSon1keR6 428RPj6jDH3kZnmyfGKGHZTnd+Egndm6F6TNcE2aRc4GJmFdkteqwnXcO7X0IcS2s/Bko58Cv1vn6 dSmLCOQkJp9lCX+Z/M1/lFPBSpZwM/erpSWi0/+bAeUnKrExRVOcZslv8TSDTea3gWeY0RZrYva/0 u65/M1Xa458KXuBwn5ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGab8-00CRrJ-1W; Tue, 04 Jul 2023 07:37:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGab5-00CRqK-2r for linux-arm-kernel@lists.infradead.org; Tue, 04 Jul 2023 07:37:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 391CD6117C; Tue, 4 Jul 2023 07:37:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCEEEC433C7; Tue, 4 Jul 2023 07:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688456234; bh=TjQKVS/MYAqAE08Ju3kcT2k6jvr4wFWPxTscLwLQRYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cXmh01IaT1vSo+ZNtz4ALoaysw5naI4kBl13FlMYUut8yiJax6k2gpdpluabxDa4L oCsNHzZBW42w/ZxyFw1+FoCiYTvFNCGbYKbbK5tVyw4vPvikvR4yZpJT7lw1UMMAML vfU5aWDF1hQJrVCwagt6O0innmme9spkMuVi/BYjR4QvEf2opDJNiBmqGRacCrVmQJ JYNbS6ajLKdu1h02iLoyaQs+A8pCXVsq6PPFYp0xPMmS64dZ2jItZhpaR2U9czNdnE RrPHPmEXZG4aPWR6mtT891xxa+QVeil0OFs8e9uQM7gLurvcSuL02wrKKgnywU/f36 SpzZJCcO/57aw== Date: Tue, 4 Jul 2023 09:37:09 +0200 From: Andi Shyti To: Dan Carpenter Cc: Christophe JAILLET , wsa@kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v2] i2c: busses: i2c-nomadik: Remove a useless call in the remove function Message-ID: <20230704073709.dzne7vcnsrksio2f@intel.intel> References: <62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr> <885ee9fa-f56c-4e21-b648-866dd4e1dc0f@kadam.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <885ee9fa-f56c-4e21-b648-866dd4e1dc0f@kadam.mountain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_003715_961628_8365431A X-CRM114-Status: GOOD ( 20.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Jul 03, 2023 at 03:54:42PM +0300, Dan Carpenter wrote: > On Fri, Jun 30, 2023 at 11:23:28PM +0200, Christophe JAILLET wrote: > > Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of > > git://git.pengutronix.de/git/wsa/linux"), there is no more > > request_mem_region() call in this driver. > > > > So remove the release_mem_region() call from the remove function which is > > likely a left over. > > > > There is no details in the above commit log, but at its end we can read: > > Conflicts: > > drivers/i2c/busses/i2c-nomadik.c > > > > This may explain why this call has been left here. > > > > Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux > > The reason why you're so confused about this Merge commit is because > it's completely unrelated to the bug. :P It should be: > > Fixes: 235602146ec9 (i2c-nomadik: turn the platform driver to an amba driver) > > When you look at that commit, you'll see that your patch is correct. Yes, indeed I noticed the same but did not investigate further. Please, also add: Cc: # v3.6+ Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel