From: Rouven Czerwinski <rcz@pengutronix.de>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwrng: imx-rngc - use dev_err_probe
Date: Wed, 5 Jul 2023 07:14:31 +0200 [thread overview]
Message-ID: <20230705071431.7487e285@drumknott> (raw)
In-Reply-To: <20230704170644.69669-1-martin@kaiser.cx>
On Tue, 4 Jul 2023 19:06:44 +0200
Martin Kaiser <martin@kaiser.cx> wrote:
> Simplify the code by calling dev_err_probe instead of dev_err and
> return.
>
> While at it, use the same device for all error messages.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Rouven Czerwinski <r.czerwinskis@pengutronix.de>
> ---
> drivers/char/hw_random/imx-rngc.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/char/hw_random/imx-rngc.c
> b/drivers/char/hw_random/imx-rngc.c index bf07f17f78c8..e4b385b01b11
> 100644 --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -239,10 +239,8 @@ static int __init imx_rngc_probe(struct
> platform_device *pdev) return PTR_ERR(rngc->base);
>
> rngc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
> - if (IS_ERR(rngc->clk)) {
> - dev_err(&pdev->dev, "Can not get rng_clk\n");
> - return PTR_ERR(rngc->clk);
> - }
> + if (IS_ERR(rngc->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(rngc->clk),
> "Cannot get rng_clk\n");
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> @@ -272,24 +270,18 @@ static int __init imx_rngc_probe(struct
> platform_device *pdev)
> ret = devm_request_irq(&pdev->dev,
> irq, imx_rngc_irq, 0, pdev->name, (void
> *)rngc);
> - if (ret) {
> - dev_err(rngc->dev, "Can't get interrupt working.\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "Can't get
> interrupt working.\n");
> if (self_test) {
> ret = imx_rngc_self_test(rngc);
> - if (ret) {
> - dev_err(rngc->dev, "self test failed\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "self
> test failed\n"); }
>
> ret = devm_hwrng_register(&pdev->dev, &rngc->rng);
> - if (ret) {
> - dev_err(&pdev->dev, "hwrng registration failed\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "hwrng
> registration failed\n");
> dev_info(&pdev->dev,
> "Freescale RNG%c registered (HW revision %d.%02d)\n",
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-05 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 17:06 [PATCH] hwrng: imx-rngc - use dev_err_probe Martin Kaiser
2023-07-05 5:14 ` Rouven Czerwinski [this message]
2023-07-05 5:21 ` Rouven Czerwinski
2023-07-14 8:58 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705071431.7487e285@drumknott \
--to=rcz@pengutronix.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).