From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9C12C001DB for ; Wed, 5 Jul 2023 05:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rMncYgLerpSRJZyoiiyxjHrytd7g3zEhaK/DNXQOeGM=; b=dz5K8Tx4836Ilu +yOZFSI4s9f+lhMP22EpX0Wgq2BzyqCZ2mVZaM9xemfR6wpfcwAWz/c22nEeMrNY3DMnfb39fTQD/ m2z7LedFI49QhzCG9RGI81jkIVkjWacnj+9EeXJQsj90WNkCZQlHskIwFc0DFFzUJxo+G78/nkQPm k6yHB2sodlyigpxCC4kv/UmpW0mPMpbM+HixcolTBC73RyhHeWO9zJgEjtpmnLR65s86hLzV3G3rR z0ncUd2yTCCKcR1hDk/uxXG2Kv7YFa6NdkmxORlTJo9UYN9dLbLjE4/StANBGgBTXjKzDdAeAEclV wPd0IWQuXZP6CcVP8HXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGux5-00Enr1-0z; Wed, 05 Jul 2023 05:21:19 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGux2-00EnqI-1n for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 05:21:17 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=drumknott) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qGuwx-0000z2-Iz; Wed, 05 Jul 2023 07:21:11 +0200 Date: Wed, 5 Jul 2023 07:21:09 +0200 From: Rouven Czerwinski To: Rouven Czerwinski Cc: Martin Kaiser , Herbert Xu , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: imx-rngc - use dev_err_probe Message-ID: <20230705072109.2fc3ee95@drumknott> In-Reply-To: <20230705071431.7487e285@drumknott> References: <20230704170644.69669-1-martin@kaiser.cx> <20230705071431.7487e285@drumknott> Organization: Pengutronix e.K. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: r.czerwinski@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_222116_591209_C09C710D X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, 5 Jul 2023 07:14:31 +0200 Rouven Czerwinski wrote: > On Tue, 4 Jul 2023 19:06:44 +0200 > Martin Kaiser wrote: > > > Simplify the code by calling dev_err_probe instead of dev_err and > > return. > > > > While at it, use the same device for all error messages. > > > > Signed-off-by: Martin Kaiser > > Reviewed-by: Rouven Czerwinski Please disregard the first tag, the correct one should be Reviewed-by: Rouven Czerwinski (note the missing s), I also fixed the mail address for this new mailer. Sorry for the noise, shouldn't review before the first tea. Best regards, Rouven > > > --- > > drivers/char/hw_random/imx-rngc.c | 24 ++++++++---------------- > > 1 file changed, 8 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/char/hw_random/imx-rngc.c > > b/drivers/char/hw_random/imx-rngc.c index bf07f17f78c8..e4b385b01b11 > > 100644 --- a/drivers/char/hw_random/imx-rngc.c > > +++ b/drivers/char/hw_random/imx-rngc.c > > @@ -239,10 +239,8 @@ static int __init imx_rngc_probe(struct > > platform_device *pdev) return PTR_ERR(rngc->base); > > > > rngc->clk = devm_clk_get_enabled(&pdev->dev, NULL); > > - if (IS_ERR(rngc->clk)) { > > - dev_err(&pdev->dev, "Can not get rng_clk\n"); > > - return PTR_ERR(rngc->clk); > > - } > > + if (IS_ERR(rngc->clk)) > > + return dev_err_probe(&pdev->dev, > > PTR_ERR(rngc->clk), "Cannot get rng_clk\n"); > > irq = platform_get_irq(pdev, 0); > > if (irq < 0) > > @@ -272,24 +270,18 @@ static int __init imx_rngc_probe(struct > > platform_device *pdev) > > ret = devm_request_irq(&pdev->dev, > > irq, imx_rngc_irq, 0, pdev->name, (void > > *)rngc); > > - if (ret) { > > - dev_err(rngc->dev, "Can't get interrupt > > working.\n"); > > - return ret; > > - } > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "Can't get > > interrupt working.\n"); > > if (self_test) { > > ret = imx_rngc_self_test(rngc); > > - if (ret) { > > - dev_err(rngc->dev, "self test failed\n"); > > - return ret; > > - } > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "self > > test failed\n"); } > > > > ret = devm_hwrng_register(&pdev->dev, &rngc->rng); > > - if (ret) { > > - dev_err(&pdev->dev, "hwrng registration failed\n"); > > - return ret; > > - } > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "hwrng > > registration failed\n"); > > dev_info(&pdev->dev, > > "Freescale RNG%c registered (HW revision > > %d.%02d)\n", > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel