From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94E6AC001B0 for ; Thu, 6 Jul 2023 02:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tqKu/PHEJC2A7VM9SGsV2YWkSt6JUpsYGHfmP1HWXLk=; b=MjYi6SfSQ/pAxK arO9KhmMrs9sO+8jViqhjEJegKPPME/5/xjMskt92bD7ZLfwfS7bB4Hn2QW8CZdVkxNxgfgkBnelf M3w5FcA3gf68t0zVdyxP0E5Vn2K+KTQERg9BbAMw5KwFLC3K2ABtsCjUseWUncPznpRbmropfySf7 s83q3+U2mogli+HopaHeY07x+j35q5oL5BJQFGoa8bmbUV+w6yhqwWVpSjwG9IA/mtCxladeJcWbZ F6Sb9YjOuifRjnvESFfSW4IJHZhumFc2z4lMHSiZkBVn4fu2eXw7iUb3wDBCDzJMXnKj4v3hT110e Gnum9BbkjunhQ+GDpfYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHEI2-0003QM-1e; Thu, 06 Jul 2023 02:00:14 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHEI0-0003NP-0w for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2023 02:00:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688608812; x=1720144812; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NS28w+WymzMKhKs2KK3bH5xOvIImsi/4GcjzUcK6qWc=; b=gdyvLtULcWWUsN7p9o/XJV9uZVEVhnZxlbMvHBrqngkpqICFHiwtt/5n TAz7iIQh/bFw7uSJNDMEdCMq/eLyyt5XSVd3g2m/KmiwxcIBykpLRai5b lnsOtWG5V53VIwMyzJJ6z9+oQhairg/Ux6cdALffIhTU71DG2MoLF0iVE sXK2VslOJtuUOJzPlMrJkqyWYrBK9AUS4aDAThJp4zcsk4AiRqOmg1mRC OGPXlfqP3XdH5rDxnDayVai2REHO3KGOuzf9VAzTaGTQ+RZTofnZnOBGT FPI+p/FnHNl5zKEn0eJ8xR8g/qMN7qMeL4f51gRoGULG1ddSguNDx5sTP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="365838938" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208";a="365838938" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 00:23:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="789062435" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208";a="789062435" Received: from jialinji-mobl4.ccr.corp.intel.com (HELO localhost) ([10.255.30.200]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 00:23:29 -0700 Date: Wed, 5 Jul 2023 15:23:35 +0800 From: Yu Zhang To: David Stevens Cc: Sean Christopherson , Marc Zyngier , Michael Ellerman , Peter Xu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org Subject: Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET Message-ID: <20230705072335.xfest7csh27f67v3@linux.intel.com> References: <20230704075054.3344915-1-stevensd@google.com> <20230704075054.3344915-4-stevensd@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230704075054.3344915-4-stevensd@google.com> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_190012_385513_4E1D7D0E X-CRM114-Status: UNSURE ( 8.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > +void kvm_set_page_accessed(struct page *page); > +void kvm_set_page_dirty(struct page *page); > + No one calls these 2 routines in this patch. How about move this change to [PATCH v7 5/8] KVM: x86/mmu: Don't pass FOLL_GET to __kvm_follow_pfn ? ... > @@ -2930,17 +2933,19 @@ static bool kvm_is_ad_tracked_page(struct page *page) > return !PageReserved(page); > } > > -static void kvm_set_page_dirty(struct page *page) > +void kvm_set_page_dirty(struct page *page) > { > if (kvm_is_ad_tracked_page(page)) > SetPageDirty(page); > } > +EXPORT_SYMBOL_GPL(kvm_set_page_dirty); > > -static void kvm_set_page_accessed(struct page *page) > +void kvm_set_page_accessed(struct page *page) > { > if (kvm_is_ad_tracked_page(page)) > mark_page_accessed(page); > } > +EXPORT_SYMBOL_GPL(kvm_set_page_accessed); Same here. B.R. Yu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel