From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25536EB64DA for ; Wed, 5 Jul 2023 19:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lzOmWa4bSFoFrwWq4ELq3PTNvyTij2nErNwFdi6Siwg=; b=iXgY/xYNhNL5Pe SUTjRtQFESNAhZoRW54stdazSW5NwxmBIaFhCmxckRNHWfJvTgn52tupO0KWaR3PQz3Ug1PnsisPs 4SvYp9Wx84veBTYyNUhFJ4GEAEOJN0BRBc8gpuNnJN4qpqfLQOiEeGyFnIbC3zT4mDPeMdhsX6+i5 a08m6E8ih9aagtR0AeRbZgjdfywx/HwLf0mTD5KvoyuV5rT05WuBozqQqTf/UMCTW1RQsEw1jYsvz oxH4cdB8TJhlIYiVsDjR8hYuurRRK5vEOvgDPPjVN9TRYB2jSD8qxhQURpYcPJwoQqua2q8dPImwU 0NC61H7dnuERCP36XGeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qH8Ci-00Gtz6-1C; Wed, 05 Jul 2023 19:30:20 +0000 Received: from mail-io1-f42.google.com ([209.85.166.42]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qH8Cf-00GtyB-2T for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 19:30:19 +0000 Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-7835ae70e46so269732739f.3 for ; Wed, 05 Jul 2023 12:30:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688585415; x=1691177415; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zr8NlcrVZF+DGU6x6DDrs6qz+39jnm7/l7Zp+WArtPU=; b=FYRpPn3QVBiEO6p28wbSMNgm68K50Xlh4X2aCHKAoImJaIicorOsEQveey4mbyzZSD NA85mbM6YlATmBwIq+jiPbZ26JtsK1fnDmmGARToGadhVHxUYGCKeZSOWlXm3jNIRwKU nfZ9mLANMbVyjld4VYFeR/j5upR3Fn7uUaOCTOlO965U1FMPlK5UUW7GAtAi8gMcmh8w 251p9D5IbKfp7bv5DC+cA3PE15JpMTga4Uvlyl0fNVxKbJh8YTHmJIKSlen6K6hP82je Yprd3JgJg82mtx9erYqqhzPiiqdl0gGIKPCvhJ+2kuBfEGibRXJmxqYMdKZw+CElp7tB anFg== X-Gm-Message-State: ABy/qLbDa9Mz5abB7AEEMU62xP6E5xc0N+WJVahVGkhAaycOv6A0FsBx RObyK5L9OdVq16YRWQE85w== X-Google-Smtp-Source: APBJJlF22tTHKhJlfwbm/7ASMiZpp4lqbi2HXqFLRetXvka2tgu9d9LnOVgkTLLTi1mnXArtTSerBg== X-Received: by 2002:a05:6602:29bb:b0:783:7193:b019 with SMTP id u27-20020a05660229bb00b007837193b019mr102895ios.4.1688585415242; Wed, 05 Jul 2023 12:30:15 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id z1-20020a02cea1000000b0042b61a5087csm966034jaq.132.2023.07.05.12.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 12:30:14 -0700 (PDT) Received: (nullmailer pid 1701874 invoked by uid 1000); Wed, 05 Jul 2023 19:30:12 -0000 Date: Wed, 5 Jul 2023 13:30:12 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak Subject: Re: [PATCH V7 1/2] dt-bindings: firmware: bootstats: Add the dtschema Message-ID: <20230705193012.GA1642540-robh@kernel.org> References: <968fb5d3-6cd8-7850-47e7-682e26f9ee5f@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_123017_808943_450AB8F5 X-CRM114-Status: GOOD ( 30.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 05, 2023 at 11:34:35AM +0200, Krzysztof Kozlowski wrote: > On 05/07/2023 10:33, Souradeep Chowdhury wrote: > >>> + $ref: /schemas/types.yaml#/definitions/string-array > >>> + > >>> + abl-time: > >>> + description: The property to store the duration of abl in ms. > >>> + $ref: /schemas/types.yaml#/definitions/string-array > >> > >> I have no clue what this entire binding is about. Nothing can bind to > >> it, no usage explained. Properties are not used to "store the duration". > >> This does not look like suitable for DT, drop entire binding. > > > > This binding was created as per the suggestion on version 6 of the patch > > by Arnd. The idea was that these 2 devicetree properties will be used to > > populate the bootstat values from the bootloader and exposed to the user > > via /sys/firmware/devicetree/ directly. > > > > Details in the link below:- > > > > https://lore.kernel.org/lkml/7d397e67-5d56-4975-98af-1ac9746c07f4@app.fastmail.com/T/#mbdc9ad95fcbb5ad7b56c6996a3933899b42d982c > > > > Can you suggest any alternative way to represent this as a binding? > > Then you should clearly state in the binding how this is going to be > used and who is going to populate it. Not only in the binding but also > in commit msg which currently has 0 rationale and answers to "why". Your > commit msg explained only "what", which is usually obvious and much less > important. Your commit should stand on its own and should clearly > explain why we need this feature at all, what problem it solves. > > And before you claim that there is some discussion under link or some > cover letter - these do not matter. Commit and bindings matter. > > What's more, I don't think that Arnd's advice is correct here - DT is > suppose to describe hardware or firmware. These properties are coming > from firmware but they are not describing any firmware or hardware > characteristics. Instead they are debugging of current boot status. > > I will leave the decision on that for Rob, however anyway binding is > very vague and incorrect, so I would expect he will come with the same > concerns regardless whether it is suitable to DT or is not. My main concern here is not so much having this info in DT, but whether it's just the start of various properties. Either because there's already more data and these are just the 2 things you care about now, or because once we enable this it's an invitation to add more properties. Boot timing information seems like something multiple platforms might want and only having 2 stages isn't extensible. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel