From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2F11EB64DD for ; Thu, 6 Jul 2023 15:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+36XHF4yI2HM7JdJ4A14IuciWcguNTDVMAi7gvCsCNE=; b=Ea/ucCZgpyMJwl 6JMGKuSvMnCyW+kwsq7l7aCXxBfbxPIX+8n4C7seT8avzMaLowteawzIZrn9yYWUNf4sXNY/3/xIg gJJCwd6c51UMio7CvkdWbJQPMS9v/PWBHneos3bt1PifhxtrcFkfIpB8Ol3mo4gnvftpc62CC/006 4usu4aioerZN+ZyKz4lAUBCqe7tKuiwtKE6UDFGl7DLPPEeImzIuXuwnoO4iXAYChHheTwHQo5FI4 Ml287Y4czyljnfCb/GHsjxHjXGMl7LLqBEzzEoip4FDVJz3IghdMx+Y5W0vqwbToWddFUc1SL+cgg /Ve0C3s+UkG+QlHnANHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHRDB-0023ob-0e; Thu, 06 Jul 2023 15:48:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHRD8-0023nw-1z for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2023 15:48:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E47B160C1C; Thu, 6 Jul 2023 15:48:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BDC3C433C7; Thu, 6 Jul 2023 15:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688658481; bh=4ASIsjcCMXJ6y3BmrH23jMs2Uiv/tnU9i09G/DMp9i8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PsUdJCiPG2ZCBQJG2eka4OFYlYQdogV7Ar1J3g9NEI4VfTjSoAJIf2dOK1IqK95mh I6iP+r5jNWf0hUmQPPtTotHi0NUu3m6MhV17q9t9Kc/8r/RBzehV4vqneSrlBRN4hx V/0CTuE9xT4Zi89Tn0ntAd+l8vI13+yuRfUqJ1iMik7xwSVVzDkbWx22XOlbiCK+ab h74R6h3/AfHD3ybFrrBLc/nK6GimGlcfzUtEMQdUKqnKoPIKioiD0ZyJbVFBgMSO7E isukZTMpyXvCbBlvwNjdcqWyyc8nFqXbLQ3y6nItWHjnjyTu2kir8us3LIvhc514Dd 5bJ5BFF0jG0Yg== Date: Thu, 6 Jul 2023 08:48:00 -0700 From: Jakub Kicinski To: Wang Ming Cc: Sunil Goutham , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, simon.horman@corigine.com Subject: Re: [PATCH net v2] net:thunder:Fix resource leaks in device_for_each_child_node() loops Message-ID: <20230706084800.579bd030@kernel.org> In-Reply-To: <20230706123021.8174-1-machel@vivo.com> References: <20230706123021.8174-1-machel@vivo.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_084802_697574_96B9B24C X-CRM114-Status: UNSURE ( 8.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 6 Jul 2023 20:30:11 +0800 Wang Ming wrote: > The device_for_each_child_node() loop in > bgx_init_of_phy() function should have > fwnode_handle_put() before break > which could avoid resource leaks. > This patch could fix this bug. Don't ignore previous feedback -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel