* [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()
@ 2023-07-06 12:08 Yangtao Li
2023-07-06 12:29 ` Alexander Lobakin
2023-07-06 15:48 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Yangtao Li @ 2023-07-06 12:08 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Michal Simek
Cc: Yangtao Li, netdev, linux-arm-kernel, linux-kernel
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index ad2c30d9a482..3cba947e4cbd 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1114,8 +1114,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
ndev->irq = rc;
- res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
- lp->base_addr = devm_ioremap_resource(&ofdev->dev, res);
+ lp->base_addr = devm_platform_get_and_ioremap_resource(ofdev, 0, &res);
if (IS_ERR(lp->base_addr)) {
rc = PTR_ERR(lp->base_addr);
goto error;
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()
2023-07-06 12:08 [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource() Yangtao Li
@ 2023-07-06 12:29 ` Alexander Lobakin
2023-07-06 15:48 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Lobakin @ 2023-07-06 12:29 UTC (permalink / raw)
To: Yangtao Li
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Michal Simek, netdev, linux-arm-kernel, linux-kernel
From: Yangtao Li <frank.li@vivo.com>
Date: Thu, 6 Jul 2023 20:08:47 +0800
> [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()
Please clearly specify the target tree (net or net-next) in the subject
prefix. Since your series is cleanups, it should be "PATCH net-next".
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index ad2c30d9a482..3cba947e4cbd 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1114,8 +1114,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
>
> ndev->irq = rc;
>
> - res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
> - lp->base_addr = devm_ioremap_resource(&ofdev->dev, res);
> + lp->base_addr = devm_platform_get_and_ioremap_resource(ofdev, 0, &res);
> if (IS_ERR(lp->base_addr)) {
> rc = PTR_ERR(lp->base_addr);
> goto error;
Thanks,
Olek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()
2023-07-06 12:08 [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-06 12:29 ` Alexander Lobakin
@ 2023-07-06 15:48 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-07-06 15:48 UTC (permalink / raw)
To: Yangtao Li
Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Michal Simek, netdev,
linux-arm-kernel, linux-kernel
On Thu, 6 Jul 2023 20:08:47 +0800 Yangtao Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
## Form letter - net-next-closed
The merge window for v6.5 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after July 10th.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-06 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06 12:08 [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-06 12:29 ` Alexander Lobakin
2023-07-06 15:48 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).