From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00228EB64DA for ; Sat, 8 Jul 2023 16:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZUyxrQEe3NRBLzbI1UUhIAyOm62PT41T3xCZJJmbEbQ=; b=VtW78qRpV/I2XH WNf5oNhtM2AbgVRTvGIQMjaoe67FBCUAtvTGTuDPTf3NcqQFTKRK3hmg+3GcSyUL6tcx1VQjrOLuN E3DrRBgTER8mqvHDUdIYYmx1ox5lHtNjWtdM5Y/SlW3qYqWZ+0NJfcPeL+Scg20oWMTubcPXpZ25L b5u0a3UKLrIYmvsNyQfgSGOeRI4kosxAhRGmFGFB3FCboO5FZQMoL8N/ibOsh2Z/+DVuZNaV2CtsI cemwo8DqYjs2Vw26CK6RjgrYnrGnCoJOy6Ak9e8nN3HlYkbD9hvspXqvIOQq2L4ZDPM0k5+hNaukp D1yOk9WwtuZyOrZQ+YuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIAQ4-007WJU-1u; Sat, 08 Jul 2023 16:04:24 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIAQ1-007WIM-05; Sat, 08 Jul 2023 16:04:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7385F60B72; Sat, 8 Jul 2023 16:04:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7644C433C7; Sat, 8 Jul 2023 16:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688832258; bh=MRhyEB9kNam7Mn6pjt39h7NCBpwSVZ2sV/31d3TWsT8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WBaBCvfJ5SZxWZmS9gM8T+dgSVlm4vLE3uBMNDOqq2zASPQR+rY+l7MghHzeIGjdM z1VenmrZMJzOtg5TOYgvz2oB30fKJaTFIQhFxEgLxZtbUVf45bhw0c7faV4TYycqp1 ySjMrO+8Pw3P5Pm6Koa6QssrkFH6HFQj6Bp2znW3WA/exIx2qKDOL8acWNXRpcXGGD I6ykfPYexuooDFVSOqNrMaTZ4MK62k9gQXH5hCCiyZ8tARRssjE41UPCu8CrrVx+aH ZvBHtVbSNFuloNmy5T55piakA71M8YhMc9elgzDTuYDoPS/OzKJcnc5Nz3PZaCOity HqVcUxQzkerPA== Date: Sat, 8 Jul 2023 17:04:10 +0100 From: Jonathan Cameron To: George Stark Cc: , , , , , , , , , , , Subject: Re: [PATCH v4 0/6] iio: adc: meson: add iio channels to read channel 7 mux inputs Message-ID: <20230708170410.0885b8e4@jic23-huawei> In-Reply-To: <20230707153322.114302-1-gnstark@sberdevices.ru> References: <20230707153322.114302-1-gnstark@sberdevices.ru> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230708_090421_152900_9704F919 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 Jul 2023 18:27:37 +0300 George Stark wrote: > From: George Stark All looks fine to me. However, given earlier versions had various other reviewers I'd like to leave it on list a little longer. Jonathan > > Changelog: > > v1->v2: > split refactoring patch [1] into 4 smaller patches, fix comment style > > [1] https://lore.kernel.org/lkml/20230621062715.455652-2-gnstark@sberdevices.ru/ > > v2->v3: > remove patch 'meson saradc: unite iio channel array definitions' [1] after discussion > > patch 'meson saradc: add enum for iio channel array indexes' > - change enum items prefix from INDEX_ to NUM_ since name 'channel index' is > more relevant to channel array index in iio world and with 2 tables our array index is > not always equal to channel number > - resolve conflicts after deleting [1] > - update commit message, previous patch [2] > - return channel number for temp channel. It wasn't used and isn't used currently > but may need later > > patch meson saradc: support reading from channel 7 mux inputs > - resolve conflicts after deleting [1] > - update commit message, previous patch [3] > - add routine find_channel_by_num to get channel by channel number > > [1] https://lore.kernel.org/lkml/20230623022334.791026-4-gnstark@sberdevices.ru/ > [2] https://lore.kernel.org/lkml/20230623022334.791026-5-gnstark@sberdevices.ru/ > [3] https://lore.kernel.org/lkml/20230623022334.791026-7-gnstark@sberdevices.ru/ > > v3->v4: > add new patch 'iio: adc: meson: remove unused timestamp channel' [1] > > patch 'iio: adc: meson: move enums declaration before' > update commit message, previous patch [2] > patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux' > update commit message, previous patch [3] > patch 'iio: adc: meson: add enum for iio channel numbers' > update commit message, previous patch [4] > patch 'iio: adc: meson: add channel labels' > update commit message, previous patch [5] > change sprintf(label, "%s\n", "temp-sensor") to sprintf(label, "temp-sensor\n") > patch 'iio: adc: meson: support reading from channel 7 mux' > rewrite enum meson_sar_adc_chan7_mux_sel definition and > read_label routine proposed by Andy [7], previous patch [6] > > [1] https://lore.kernel.org/lkml/20230705160413.000062e7@Huawei.com/ > [2] https://lore.kernel.org/lkml/20230627224017.1724097-2-gnstark@sberdevices.ru/ > [3] https://lore.kernel.org/lkml/20230627224017.1724097-3-gnstark@sberdevices.ru/ > [4] https://lore.kernel.org/lkml/20230627224017.1724097-4-gnstark@sberdevices.ru/ > [5] https://lore.kernel.org/lkml/20230627224017.1724097-5-gnstark@sberdevices.ru/ > [6] https://lore.kernel.org/lkml/20230627224017.1724097-6-gnstark@sberdevices.ru/ > [7] https://lore.kernel.org/lkml/ZJwGCNA+ZURri24i@smile.fi.intel.com/ > > George Stark (6): > iio: adc: meson: remove unused timestamp channel > iio: adc: meson: move enums declaration before variables declaration > iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper > iio: adc: meson: add enum for iio channel numbers > iio: adc: meson: add channel labels > iio: adc: meson: support reading from channel 7 mux inputs > > drivers/iio/adc/meson_saradc.c | 173 +++++++++++++++++++++++++-------- > 1 file changed, 134 insertions(+), 39 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel