From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB102EB64DA for ; Mon, 10 Jul 2023 06:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A1iw0q4i4IoSyfPBcfQ3dXlSi9N+3hE4JNEvCvMCE5E=; b=njxQ9v4geZjig0 09AZhIbSCmRlSWe/s8tEkpQ1fSEuWM9bCcUrEothoj7IjycVaIcz1x2p+g5Pbg31lYeDe4nche01W rfzuZ1gVooGiTYVMqFAQY6d5dBUEFb/92wTaLotDN6PSGmQu532TefiRvWkS/HY0/tiuO1FUE8WmN I0e+oT2xlZnS3A0pwDeAKVYW6KaUwhC7MgySoSVfYHHcTAB6b89gujf+RML+zAwrpi+q5CSgXUFGb Tmqe8OdWF0mqve6RCHSZohHStKfK7bxBqMW0V3J9L0pFKFOB3VVdj54ull5IhUjDOmjRLAneqPKFK 9lp9n2EIRFFgHeoyMeHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIkLa-00AZBc-03; Mon, 10 Jul 2023 06:26:10 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIkLW-00AZ7C-2U; Mon, 10 Jul 2023 06:26:09 +0000 X-GND-Sasl: herve.codina@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688970360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17ZTBQO+oBIkGul7D/WlB+X7l0VA0KwA6SIv/f89u7w=; b=pIXKjmxfNRP61MN4/M43OLwfOt2eCDwrovK9XTBHcMsO31DUfzfvU6suXBII6V3BYD44tR 1mHUSXcarif+DmleFeC9TIxyD7nNl1T41VZjSwY7CXiuBrPAlN5Hh2AZurhW0lfoaIyaG5 1xj9DgiPLk6f94v/WTAJotVjCsOM/bLTjoFOkYdiI7MGQh0PG2TadiZdbDX2vvcGjEVoMy Y6ydVdRi0Wl/yf0D0ZYMmrGNKOvbYzS6k7Hs5BRQ+B9VLx7sKjZaYgHKg7rFl3+2dErdzm 67ihNd2LivbVVOQPKvRAjm1saYUzLjcHXhq8Y0FLBarhLR+/fRYqKqDr5sOzuA== X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id D7416C0005; Mon, 10 Jul 2023 06:25:58 +0000 (UTC) Date: Mon, 10 Jul 2023 08:25:58 +0200 From: Herve Codina To: Yu Hao Cc: chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel Subject: Re: [PATCH] usb: mtu3: Fix possible use-before-initialization bug Message-ID: <20230710082558.2f82d607@bootlin.com> In-Reply-To: References: <20230705080625.02b2bac5@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230709_232607_278083_EF095BC2 X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgWXUsCgpPbiBTdW4sIDkgSnVsIDIwMjMgMTc6NDg6MTUgLTA3MDAKWXUgSGFvIDx5aGFvMDE2 QHVjci5lZHU+IHdyb3RlOgoKPiBIaSBIZXJ2w6ksCj4gCj4gVGhhbmtzIGZvciB0aGUgY29tbWVu dHMuIEhvdyBhYm91dCB0aGlzIHBhdGNoPwo+IC0tLQo+ICBkcml2ZXJzL3VzYi9tdHUzL210dTNf Z2FkZ2V0X2VwMC5jIHwgMTEgKysrKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvbXR1 My9tdHUzX2dhZGdldF9lcDAuYwo+IGIvZHJpdmVycy91c2IvbXR1My9tdHUzX2dhZGdldF9lcDAu Ywo+IGluZGV4IGU0ZmQxYmIxNGE1NS4uYWYyODg0OTQzYzJhIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvdXNiL210dTMvbXR1M19nYWRnZXRfZXAwLmMKPiArKysgYi9kcml2ZXJzL3VzYi9tdHUzL210 dTNfZ2FkZ2V0X2VwMC5jCj4gQEAgLTYwMCw3ICs2MDAsNyBAQCBzdGF0aWMgdm9pZCBlcDBfdHhf c3RhdGUoc3RydWN0IG10dTMgKm10dSkKPiAgICAgICAgIG10dTNfcmVhZGwobXR1LT5tYWNfYmFz ZSwgVTNEX0VQMENTUikpOwo+ICB9Cj4gCj4gLXN0YXRpYyB2b2lkIGVwMF9yZWFkX3NldHVwKHN0 cnVjdCBtdHUzICptdHUsIHN0cnVjdCB1c2JfY3RybHJlcXVlc3QgKnNldHVwKQo+ICtzdGF0aWMg aW50IGVwMF9yZWFkX3NldHVwKHN0cnVjdCBtdHUzICptdHUsIHN0cnVjdCB1c2JfY3RybHJlcXVl c3QgKnNldHVwKQo+ICB7Cj4gICAgIHN0cnVjdCBtdHUzX3JlcXVlc3QgKm1yZXE7Cj4gICAgIHUz MiBjb3VudDsKPiBAQCAtNjA4LDYgKzYwOCw4IEBAIHN0YXRpYyB2b2lkIGVwMF9yZWFkX3NldHVw KHN0cnVjdCBtdHUzICptdHUsCj4gc3RydWN0IHVzYl9jdHJscmVxdWVzdCAqc2V0dXApCj4gCj4g ICAgIGNzciA9IG10dTNfcmVhZGwobXR1LT5tYWNfYmFzZSwgVTNEX0VQMENTUikgJiBFUDBfVzFD X0JJVFM7Cj4gICAgIGNvdW50ID0gbXR1M19yZWFkbChtdHUtPm1hY19iYXNlLCBVM0RfUlhDT1VO VDApOwo+ICsgICBpZiAoY291bnQgPT0gMCkKPiArICAgICAgIHJldHVybiAtRUlOVkFMOwoKJ2Nv dW50JyBzaG91bGQgYmUgdGVzdGVkIGFnYWluc3Qgc2l6ZW9mKCpzZXR1cCkuIEluZGVlZCwgd2Ug bmVlZCB0byBoYXZlIGEKc2V0dXAgZGF0YSBwYWNrZXQgaW4gdGhlIGZpZm8uCgpXaGF0IGRvIHlv dSB0aGluayBhYm91dDoKaWYgKGNvdW50IDwgc2l6ZWYoKnNldHVwKSkKCXJldHVybiAtRUlOVkFM OwoKPiAKPiAgICAgZXAwX3JlYWRfZmlmbyhtdHUtPmVwMCwgKHU4ICopc2V0dXAsIGNvdW50KTsK PiAKPiBAQCAtNjQyLDcgKzY0NCw4IEBAIF9fYWNxdWlyZXMobXR1LT5sb2NrKQo+ICAgICBzdHJ1 Y3QgbXR1M19yZXF1ZXN0ICptcmVxOwo+ICAgICBpbnQgaGFuZGxlZCA9IDA7Cj4gCj4gLSAgIGVw MF9yZWFkX3NldHVwKG10dSwgJnNldHVwKTsKPiArICAgaWYgKGVwMF9yZWFkX3NldHVwKG10dSwg JnNldHVwKSkKPiArICAgICAgIHJldHVybiAtRUlOVkFMOwoKRm9yd2FyZCB0aGUgZXJyb3IgY29k ZSB0byB0aGUgY2FsbGVyID8KCnJldCA9IGVwMF9yZWFkX3NldHVwKG10dSwgJnNldHVwKQppZiAo cmV0IDwgMCkKCXJldHVybiByZXQ7CgoKPiAgICAgdHJhY2VfbXR1M19oYW5kbGVfc2V0dXAoJnNl dHVwKTsKPiAKPiAgICAgaWYgKChzZXR1cC5iUmVxdWVzdFR5cGUgJiBVU0JfVFlQRV9NQVNLKSA9 PSBVU0JfVFlQRV9TVEFOREFSRCkKPiBAQCAtNzY0LDcgKzc2Nyw5IEBAIGlycXJldHVybl90IG10 dTNfZXAwX2lzcihzdHJ1Y3QgbXR1MyAqbXR1KQo+ICAgICAgICAgICAgIGJyZWFrOwo+ICAgICAg ICAgfQo+IAo+IC0gICAgICAgZXAwX2hhbmRsZV9zZXR1cChtdHUpOwo+ICsgICAgICAgaWYgKGVw MF9oYW5kbGVfc2V0dXAobXR1KSkKPiArICAgICAgICAgICBicmVhazsKPiArCgpPawoKPiAgICAg ICAgIHJldCA9IElSUV9IQU5ETEVEOwo+ICAgICAgICAgYnJlYWs7Cj4gICAgIGRlZmF1bHQ6CgpC ZSBjYXJlZnVsLCB5b3VyIHBhdGNoIGlzIHdyb25nbHkgaW5kZW50ZWQuCnRhYnMgcmVwbGFjZWQg YnkgNCBzcGFjZXMuIFlvdSBuZWVkIHRvIGtlZXAgdGFicy4KClJlZ2FyZHMsCkhlcnbDqSBDb2Rp bmEKCi0tIApIZXJ2w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwg ZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=