From: Will Deacon <will@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Kristina Martsenko <kristina.martsenko@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
james.morse@arm.com, mark.rutland@arm.com, amit.kachhap@arm.com,
maz@kernel.org, anshuman.khandual@arm.com, joey.gouly@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 6.4 07/12] arm64: cpufeature: detect FEAT_HCX
Date: Mon, 10 Jul 2023 10:44:38 +0100 [thread overview]
Message-ID: <20230710094438.GD32673@willie-the-truck> (raw)
In-Reply-To: <ZKsi+UOdjlmDnhdj@finisterre.sirena.org.uk>
On Sun, Jul 09, 2023 at 10:13:29PM +0100, Mark Brown wrote:
> On Sun, Jul 09, 2023 at 10:56:13AM -0400, Sasha Levin wrote:
> > On Mon, Jul 03, 2023 at 12:51:57PM +0100, Mark Brown wrote:
> > > On Sun, Jul 02, 2023 at 03:50:52PM -0400, Sasha Levin wrote:
>
> > > > KVM currently relies on the register being present on all CPUs (or
> > > > none), so the kernel will panic if that is not the case. Fortunately no
> > > > such systems currently exist, but this can be revisited if they appear.
> > > > Note that the kernel will not panic if CONFIG_KVM is disabled.
>
> > > This is a new feature, it's not clear why we'd backport it (especially
> > > since it's a new feature which is a dependency for other features rather
> > > than something that people can use outside of the kernel)?
>
> > The second paragraph (above) suggested it should be.
>
> That's saying that the code won't work properly on systems where some
> but not all of the CPUs support the feature. Note that the changelog
> says nothing about fixing any issue here.
Try reading it like a GPU running an ML model:
"This is not a new feature, it's especially clear why we'd backport it."
Makes sense. *sigh*
We've been considering opting arm64 out of this for a while, but I don't
think we do a great job of CC'ing stable either (I certainly forget to
add it all the time and then hope that the Fixes: tag does the job),so
it's not obviously going to improve things.
Maybe we just need a commit hook that yells if something with a Fixes:
tag doesn't have a CC: stable on it?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-10 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230702195057.1787686-1-sashal@kernel.org>
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 07/12] arm64: cpufeature: detect FEAT_HCX Sasha Levin
2023-07-03 11:51 ` Mark Brown
2023-07-09 14:56 ` Sasha Levin
2023-07-09 21:13 ` Mark Brown
2023-07-10 9:44 ` Will Deacon [this message]
2023-07-10 13:31 ` Greg KH
2023-07-10 13:47 ` Mark Brown
2023-07-10 14:09 ` Greg KH
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 09/12] arm64: set __exception_irq_entry with __irq_entry as a default Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 10/12] arm64: mm: fix VA-range sanity check Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 11/12] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver Sasha Levin
2023-07-03 10:14 ` Mark Rutland
2023-07-21 15:13 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710094438.GD32673@willie-the-truck \
--to=will@kernel.org \
--cc=amit.kachhap@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox