From: Martin Kaiser <martin@kaiser.cx>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: aric.pzqi@ingenic.com, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 6/7] hwrng: ingenic - don't disable the rng in ingenic_trng_remove
Date: Mon, 10 Jul 2023 22:27:32 +0200 [thread overview]
Message-ID: <20230710202733.116133-7-martin@kaiser.cx> (raw)
In-Reply-To: <20230710202733.116133-1-martin@kaiser.cx>
There's no need to disable the rng in ingenic_trng_remove.
The driver's init function sets the CFG_GEN_EN bit to enable the
rng. The cleanup function clears CFG_GEN_EN to revert this.
The remove function calls hwrng_unregister. If the ingenic-trng is not
the current rng at this point, CFG_GEN_EN has already been cleared. If
the ingenic-trng is the current rng, drop_current_rng will call the
cleanup function.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/char/hw_random/ingenic-trng.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/char/hw_random/ingenic-trng.c b/drivers/char/hw_random/ingenic-trng.c
index cc88a941c929..9c54721f8399 100644
--- a/drivers/char/hw_random/ingenic-trng.c
+++ b/drivers/char/hw_random/ingenic-trng.c
@@ -111,14 +111,9 @@ static int ingenic_trng_probe(struct platform_device *pdev)
static int ingenic_trng_remove(struct platform_device *pdev)
{
struct ingenic_trng *trng = platform_get_drvdata(pdev);
- unsigned int ctrl;
hwrng_unregister(&trng->rng);
- ctrl = readl(trng->base + TRNG_REG_CFG_OFFSET);
- ctrl &= ~CFG_GEN_EN;
- writel(ctrl, trng->base + TRNG_REG_CFG_OFFSET);
-
return 0;
}
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-10 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 20:27 hwrng: ingenic: simplify the code Martin Kaiser
2023-07-10 20:27 ` [PATCH 1/7] hwrng: ingenic - enable compile testing Martin Kaiser
2023-07-10 20:27 ` [PATCH 2/7] hwrng: ingenic - remove two unused defines Martin Kaiser
2023-07-10 20:27 ` [PATCH 3/7] hwrng: ingenic - remove dead assignments Martin Kaiser
2023-07-10 20:27 ` [PATCH 4/7] hwrng: ingenic - use devm_clk_get_enabled Martin Kaiser
2023-07-10 20:27 ` [PATCH 5/7] hwrng: ingenic - use dev_err_probe in error paths Martin Kaiser
2023-07-10 20:27 ` Martin Kaiser [this message]
2023-07-10 20:27 ` [PATCH 7/7] hwrng: ingenic - switch to device managed registration Martin Kaiser
2023-07-22 2:13 ` hwrng: ingenic: simplify the code Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710202733.116133-7-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=aric.pzqi@ingenic.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).