From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91E8FEB64DC for ; Tue, 11 Jul 2023 09:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YV+tT8cgyecUkwFLS28XaIv+7L4lWugGTn/4j14SjzE=; b=zcbXIRSMAPdgFn F7VPxAdTzOpQe6bWLuK7YD/QS0AUrfsCasS0N5eLLUSbL32WV8VsVn7X91AEyYMayFZeN9fVAETjt MZefhVZPPJoLooQNCJNSDYo7eBDT8xNLPC2b0mPrVU2AYnUOZsDIJiudH6awfRPP3C4SyKHgZA5zs xyK+DaEc9NLAfkC/pnKmRwCcP4r91Q1Jr7g50a3bJO2/RphQnlu5CV6zxizIO6PLy8Nf6Aw2QYh31 dQSqmYEnAjemfVxP6c5Q3Ag94MWcgq6iGBNLl2IEjrceZa0p46kYbKGayRTmX8WKzu1wseOTuC+nE NSFlRMQoaRh4LuAy7PCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJ9sq-00EKel-0P; Tue, 11 Jul 2023 09:42:12 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJ9sm-00EKaT-0v; Tue, 11 Jul 2023 09:42:10 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6C38D20008; Tue, 11 Jul 2023 09:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689068517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1mQpjvbXTqSZMh2oqXJLwIPvBh65UpQSNz+TWmuX7pg=; b=J0IPQRNMF4rW2vhHO+MYH6DbHjXzguu5d4CblnTphTAbz9ZHmZ8RKYVpLXShsypPVO7j6N LYIc1MsuzN/0rKV95AwKrjMPziCl43osWurZYVBCqlwo2TdBB8aEX5PQTCS5AGn50ZwmVL NTk/4ViLGUGU5qLaKuzX8Ib9PeofopHsvXevdHx5GDuHYF0bvSswTu9giUyFQtqS/YpbaK FvIou48O/Tbv0p4Kuv01/RRyikSfEnqANaZHaheeak+lCFg1RslpA9s4A6rqxdFdALqKXN FgIQbgkJJ+fVrlUVqyoL8iUiKDvvHr+9Xgt6QwIxvaipNaeSZgstvccv138LAg== Date: Tue, 11 Jul 2023 11:41:55 +0200 From: Herve Codina To: "Chunfeng Yun (=?UTF-8?B?5LqR5pil5bOw?=)" Cc: "yhao016@ucr.edu" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH] usb: mtu3: Fix possible use-before-initialization bug Message-ID: <20230711114155.4a000704@bootlin.com> In-Reply-To: <29a71cbb61148d2085cc08da681526c4e20d31b9.camel@mediatek.com> References: <20230705080625.02b2bac5@bootlin.com> <20230710082558.2f82d607@bootlin.com> <29a71cbb61148d2085cc08da681526c4e20d31b9.camel@mediatek.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230711_024208_584183_437B662A X-CRM114-Status: GOOD ( 29.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2h1bmZlbmcsCgpPbiBUdWUsIDExIEp1bCAyMDIzIDA4OjQ4OjM1ICswMDAwCkNodW5mZW5n IFl1biAo5LqR5pil5bOwKSA8Q2h1bmZlbmcuWXVuQG1lZGlhdGVrLmNvbT4gd3JvdGU6Cgo+IE9u IE1vbiwgMjAyMy0wNy0xMCBhdCAwODoyNSArMDIwMCwgSGVydmUgQ29kaW5hIHdyb3RlOgo+ID4g IAkgCj4gPiBFeHRlcm5hbCBlbWFpbCA6IFBsZWFzZSBkbyBub3QgY2xpY2sgbGlua3Mgb3Igb3Bl biBhdHRhY2htZW50cyB1bnRpbAo+ID4geW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBvciB0 aGUgY29udGVudC4KPiA+ICBIaSBZdSwKPiA+IAo+ID4gT24gU3VuLCA5IEp1bCAyMDIzIDE3OjQ4 OjE1IC0wNzAwCj4gPiBZdSBIYW8gPHloYW8wMTZAdWNyLmVkdT4gd3JvdGU6Cj4gPiAgIAo+ID4g PiBIaSBIZXJ2w6ksCj4gPiA+IAo+ID4gPiBUaGFua3MgZm9yIHRoZSBjb21tZW50cy4gSG93IGFi b3V0IHRoaXMgcGF0Y2g/Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy91c2IvbXR1My9tdHUzX2dh ZGdldF9lcDAuYyB8IDExICsrKysrKysrLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdXNiL210dTMvbXR1M19nYWRnZXRfZXAwLmMKPiA+ID4gYi9kcml2ZXJzL3VzYi9tdHUzL210 dTNfZ2FkZ2V0X2VwMC5jCj4gPiA+IGluZGV4IGU0ZmQxYmIxNGE1NS4uYWYyODg0OTQzYzJhIDEw MDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL3VzYi9tdHUzL210dTNfZ2FkZ2V0X2VwMC5jCj4gPiA+ ICsrKyBiL2RyaXZlcnMvdXNiL210dTMvbXR1M19nYWRnZXRfZXAwLmMKPiA+ID4gQEAgLTYwMCw3 ICs2MDAsNyBAQCBzdGF0aWMgdm9pZCBlcDBfdHhfc3RhdGUoc3RydWN0IG10dTMgKm10dSkKPiA+ ID4gICAgICAgICBtdHUzX3JlYWRsKG10dS0+bWFjX2Jhc2UsIFUzRF9FUDBDU1IpKTsKPiA+ID4g IH0KPiA+ID4gCj4gPiA+IC1zdGF0aWMgdm9pZCBlcDBfcmVhZF9zZXR1cChzdHJ1Y3QgbXR1MyAq bXR1LCBzdHJ1Y3QgIAo+ID4gdXNiX2N0cmxyZXF1ZXN0ICpzZXR1cCkgIAo+ID4gPiArc3RhdGlj IGludCBlcDBfcmVhZF9zZXR1cChzdHJ1Y3QgbXR1MyAqbXR1LCBzdHJ1Y3QgdXNiX2N0cmxyZXF1 ZXN0ICAKPiA+ICpzZXR1cCkgIAo+ID4gPiAgewo+ID4gPiAgICAgc3RydWN0IG10dTNfcmVxdWVz dCAqbXJlcTsKPiA+ID4gICAgIHUzMiBjb3VudDsKPiA+ID4gQEAgLTYwOCw2ICs2MDgsOCBAQCBz dGF0aWMgdm9pZCBlcDBfcmVhZF9zZXR1cChzdHJ1Y3QgbXR1MyAqbXR1LAo+ID4gPiBzdHJ1Y3Qg dXNiX2N0cmxyZXF1ZXN0ICpzZXR1cCkKPiA+ID4gCj4gPiA+ICAgICBjc3IgPSBtdHUzX3JlYWRs KG10dS0+bWFjX2Jhc2UsIFUzRF9FUDBDU1IpICYgRVAwX1cxQ19CSVRTOwo+ID4gPiAgICAgY291 bnQgPSBtdHUzX3JlYWRsKG10dS0+bWFjX2Jhc2UsIFUzRF9SWENPVU5UMCk7Cj4gPiA+ICsgICBp ZiAoY291bnQgPT0gMCkKPiA+ID4gKyAgICAgICByZXR1cm4gLUVJTlZBTDsgIAo+ID4gCj4gPiAn Y291bnQnIHNob3VsZCBiZSB0ZXN0ZWQgYWdhaW5zdCBzaXplb2YoKnNldHVwKS4gSW5kZWVkLCB3 ZSBuZWVkIHRvCj4gPiBoYXZlIGEKPiA+IHNldHVwIGRhdGEgcGFja2V0IGluIHRoZSBmaWZvLgo+ ID4gCj4gPiBXaGF0IGRvIHlvdSB0aGluayBhYm91dDoKPiA+IGlmIChjb3VudCA8IHNpemVmKCpz ZXR1cCkpCj4gPiByZXR1cm4gLUVJTlZBTDsgIAo+IGJlZm9yZSBjYWxsIHRoaXMgZnVuY3Rpb24s IGFscmVhZHkgY2hlY2sgdGhlIGRhdGEgbGVuZ3RoIGluIGZpZm8sIGl0Cj4gc2hvdWxkIGJlIDgg Ynl0ZXMuCj4gc2VlIG10dTNfZXAwX2lzcigpLCBhYm91dCBsaW5lIDc2MS4KCkluZGVlZCwgSSBt aXNzZWQgdGhhdCBwb2ludC4KVGhhbmtzIGZvciBwb2ludGluZyBpdC4KClJlZ2FyZHMsCkhlcnbD qQoKPiAKPiBJIHRoaW5rIG5vIG5lZWQgdGhpcyBwYXRjaAo+IAo+IFRoYW5rcyBhIGxvdAo+IAo+ ID4gICAKPiA+ID4gCj4gPiA+ICAgICBlcDBfcmVhZF9maWZvKG10dS0+ZXAwLCAodTggKilzZXR1 cCwgY291bnQpOwo+ID4gPiAKPiA+ID4gQEAgLTY0Miw3ICs2NDQsOCBAQCBfX2FjcXVpcmVzKG10 dS0+bG9jaykKPiA+ID4gICAgIHN0cnVjdCBtdHUzX3JlcXVlc3QgKm1yZXE7Cj4gPiA+ICAgICBp bnQgaGFuZGxlZCA9IDA7Cj4gPiA+IAo+ID4gPiAtICAgZXAwX3JlYWRfc2V0dXAobXR1LCAmc2V0 dXApOwo+ID4gPiArICAgaWYgKGVwMF9yZWFkX3NldHVwKG10dSwgJnNldHVwKSkKPiA+ID4gKyAg ICAgICByZXR1cm4gLUVJTlZBTDsgIAo+ID4gCj4gPiBGb3J3YXJkIHRoZSBlcnJvciBjb2RlIHRv IHRoZSBjYWxsZXIgPwo+ID4gCj4gPiByZXQgPSBlcDBfcmVhZF9zZXR1cChtdHUsICZzZXR1cCkK PiA+IGlmIChyZXQgPCAwKQo+ID4gcmV0dXJuIHJldDsKPiA+IAo+ID4gICAKPiA+ID4gICAgIHRy YWNlX210dTNfaGFuZGxlX3NldHVwKCZzZXR1cCk7Cj4gPiA+IAo+ID4gPiAgICAgaWYgKChzZXR1 cC5iUmVxdWVzdFR5cGUgJiBVU0JfVFlQRV9NQVNLKSA9PSBVU0JfVFlQRV9TVEFOREFSRCkKPiA+ ID4gQEAgLTc2NCw3ICs3NjcsOSBAQCBpcnFyZXR1cm5fdCBtdHUzX2VwMF9pc3Ioc3RydWN0IG10 dTMgKm10dSkKPiA+ID4gICAgICAgICAgICAgYnJlYWs7Cj4gPiA+ICAgICAgICAgfQo+ID4gPiAK PiA+ID4gLSAgICAgICBlcDBfaGFuZGxlX3NldHVwKG10dSk7Cj4gPiA+ICsgICAgICAgaWYgKGVw MF9oYW5kbGVfc2V0dXAobXR1KSkKPiA+ID4gKyAgICAgICAgICAgYnJlYWs7Cj4gPiA+ICsgIAo+ ID4gCj4gPiBPawo+ID4gICAKPiA+ID4gICAgICAgICByZXQgPSBJUlFfSEFORExFRDsKPiA+ID4g ICAgICAgICBicmVhazsKPiA+ID4gICAgIGRlZmF1bHQ6ICAKPiA+IAo+ID4gQmUgY2FyZWZ1bCwg eW91ciBwYXRjaCBpcyB3cm9uZ2x5IGluZGVudGVkLgo+ID4gdGFicyByZXBsYWNlZCBieSA0IHNw YWNlcy4gWW91IG5lZWQgdG8ga2VlcCB0YWJzLgo+ID4gCj4gPiBSZWdhcmRzLAo+ID4gSGVydsOp IENvZGluYQo+ID4gICAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==