From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24ABFEB64DC for ; Tue, 11 Jul 2023 20:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HhshpVsJx4c4hxhtMOBofpn7Im/yqm4gYHzXCrrYOBM=; b=3u7eQRhz37vzwr crtPHeXhlnRd7m6Ve5gKTufhHPu15Qlcl+0OJzI+Idu5/qjX+Nuv4GnTQpm8dJYjK4MD+BzHIxOBZ kb8RLUtM+6KAHt/J+n4Vfa+E8C5YkbTPHEuYpRGIXsXbzzMJA7AUiwHd1+o6SOBhVL/eNE8asMf5T autIiRA417b2sc0bEzWPAapI1tsvMLjfX3M2FlyE8sM/aexSbe0KVmsQPzaFyGtekaPZnSUa+iAT2 phxsO4uSMoY4Zg+uPTcbD+FBR0zE6FB/z6a4MZghZmoWKPgibMOuiM7tRBLOVKg41Tj07r/NNNopp Mdeeb3lbU7ExEFkof/zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJJfn-00FomC-2W; Tue, 11 Jul 2023 20:09:23 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJJfk-00Foku-2a for linux-arm-kernel@lists.infradead.org; Tue, 11 Jul 2023 20:09:22 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6682909acadso3436547b3a.3 for ; Tue, 11 Jul 2023 13:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689106157; x=1691698157; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0AjrurSLjCfnq22wQVPyzNWuhvJYbXtr4WWuyj0oB9s=; b=smN2+HX0faRVYygGOZFPccaAota1KFLmMs1jQjvZhI3B9d8PAf3rFlwY9kdCT7kktV UunleB1j7AOzmZkoPtTcx496fwQsKRkLhmGIwiWAAofX0QAAMMQagFRvWkv2x+KBc9kE pnTrvemOtC5P2PNJfBaTY64JKpZcwmT9foE0IoyBrAPGhszG2fXx6uS7QOMmFRY5D7Yw TORYFr/ThLsC6nQaD2VxzuzAyE5eYf4rCJrCoBwUIDySEKc0lRkGNJG8wSZ2mFcFFLNz GdAMrAiVgGFanSg/x/8WnpLC8OTL6cpjVGhtA2YaaHiDcJSxIl8BoShUuMCChsvWdAxd WOuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689106157; x=1691698157; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0AjrurSLjCfnq22wQVPyzNWuhvJYbXtr4WWuyj0oB9s=; b=MyKRDNjet4ks+L8OZp7Nip0SDGln8TwRcfVF+Xwyf/AdfrIJuUsZhiOLzxpkGaq9eN 767nYCmiiZtEvEed6nja6vSDPG7eLksj901SbzqgAS+6VSsh6Wyz8hCj/QCg4fN9Q+vR Jsw8o5fzboBAEAq4VdDe9nyjrw+oCACOso0MF/UiSNGAeB2dQ0OTF/TnSfpeUnmDCV4K aLkSG3f+8qQCyZYlPHL4TY0Yy5Z3NpO3HboL4EfHBYQKYdKbHAgfujAp/1rwZlV0L8lP 28DoPpVZcyzqmuCmRVkdUOR1bgucnVNhp5IBvxeVSSgSzcHd/53VK/gbQxJ+UQzu+yo/ ahiA== X-Gm-Message-State: ABy/qLakIInn1EEy3appqBnvOCA5iArEVYXUrRq5BnqrWgLyu1ub30y5 eX7BadzwtkC3nKEZSsgfFLM= X-Google-Smtp-Source: APBJJlGDQu2odG6nQ82sJP4Hvl6xC0g6W/0X6YKALLPC2oPn9xZJg+vaExMRgdxQvRyTgsW8Dx4LMQ== X-Received: by 2002:a05:6a00:1745:b0:67a:c810:3cb0 with SMTP id j5-20020a056a00174500b0067ac8103cb0mr15187493pfc.3.1689106157228; Tue, 11 Jul 2023 13:09:17 -0700 (PDT) Received: from localhost.localdomain ([113.103.7.132]) by smtp.gmail.com with ESMTPSA id j6-20020a633c06000000b0051b36aee4f6sm1964047pga.83.2023.07.11.13.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 13:09:16 -0700 (PDT) From: Guiting Shen To: claudiu.beznea@microchip.com Subject: [PATCH v3] pwm: atmel: Enable clk when pwm already enabled in bootloader Date: Wed, 12 Jul 2023 04:09:05 +0800 Message-Id: <20230711200905.6464-1-aarongt.shen@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230711_130920_857753_712F32E6 X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, alexandre.belloni@bootlin.com, Guiting Shen , linux-kernel@vger.kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver would never call clk_enable() if the PWM channel was already enabled in bootloader which lead to dump the warning message "the PWM clock already disabled" when turning off the PWM channel. Add atmel_pwm_enable_clk_if_on() in probe function to enable clock if the PWM channel was already enabled in bootloader. Signed-off-by: Guiting Shen --- drivers/pwm/pwm-atmel.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index cdbc23649032..f8f1fbb8732d 100644 --- a/drivers/pwm/pwm-atmel.c +++ b/drivers/pwm/pwm-atmel.c @@ -464,6 +464,31 @@ static const struct of_device_id atmel_pwm_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, atmel_pwm_dt_ids); +static int atmel_pwm_enable_clk_if_on(struct atmel_pwm_chip *atmel_pwm) +{ + unsigned int i; + int err; + u32 sr; + + sr = atmel_pwm_readl(atmel_pwm, PWM_SR); + if (!sr) + return 0; + + for (i = 0; i < atmel_pwm->chip.npwm; i++) { + if (!(sr & (1 << i))) + continue; + + err = clk_enable(atmel_pwm->clk); + if (err) { + dev_err(atmel_pwm->chip.dev, + "failed to enable clock: %pe\n", ERR_PTR(err)); + return err; + } + } + + return 0; +} + static int atmel_pwm_probe(struct platform_device *pdev) { struct atmel_pwm_chip *atmel_pwm; @@ -504,8 +529,15 @@ static int atmel_pwm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, atmel_pwm); + ret = atmel_pwm_enable_clk_if_on(atmel_pwm); + if (ret < 0) + goto remove_pwmchip; + return ret; +remove_pwmchip: + pwmchip_remove(&atmel_pwm->chip); + unprepare_clk: clk_unprepare(atmel_pwm->clk); return ret; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel