From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guiting Shen <aarongt.shen@gmail.com>
Cc: linux-pwm@vger.kernel.org, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
claudiu.beznea@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] pwm: atmel: Enable clk when pwm already enabled in bootloader
Date: Tue, 11 Jul 2023 22:30:17 +0200 [thread overview]
Message-ID: <20230711203017.cdfe2nrjx7lt25tm@pengutronix.de> (raw)
In-Reply-To: <20230711200905.6464-1-aarongt.shen@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 858 bytes --]
Hello,
On Wed, Jul 12, 2023 at 04:09:05AM +0800, Guiting Shen wrote:
> +static int atmel_pwm_enable_clk_if_on(struct atmel_pwm_chip *atmel_pwm)
> +{
> + unsigned int i;
> + int err;
> + u32 sr;
> +
> + sr = atmel_pwm_readl(atmel_pwm, PWM_SR);
> + if (!sr)
> + return 0;
> +
> + for (i = 0; i < atmel_pwm->chip.npwm; i++) {
> + if (!(sr & (1 << i)))
> + continue;
> +
> + err = clk_enable(atmel_pwm->clk);
> + if (err) {
> + dev_err(atmel_pwm->chip.dev,
> + "failed to enable clock: %pe\n", ERR_PTR(err));
Here you leak possibly a few enables. While it's not likely that the
(say) third enable goes wrong, it's also not that hard to handle?!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-11 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 20:09 [PATCH v3] pwm: atmel: Enable clk when pwm already enabled in bootloader Guiting Shen
2023-07-11 20:30 ` Uwe Kleine-König [this message]
2023-07-12 1:45 ` Guiting Shen
2023-07-12 10:00 ` Uwe Kleine-König
2023-07-12 12:31 ` Thierry Reding
2023-07-12 12:47 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711203017.cdfe2nrjx7lt25tm@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=aarongt.shen@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox