From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4812EEB64D9 for ; Wed, 12 Jul 2023 13:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Szo1CX8smB2aGBV2Wlx6RuFrcSgXvTdX1XSgRfvHw/8=; b=cMAkA8Ze4Hb960 9/lX4AdCQdgM06DEBWH9rI+c06R//gujeCvHyVwILVeGQMLGUxWHRn14BerpsjnfVvmOVYGD/m03E q6hObvZ+DFiduOLaE6EzVbeUIZX/WzXNyp5Xa39UsmeaNe+tFBfaCtDASAbD9f36wtE7Nk8f9K4CU LMdxEiLx3+pkuTcA1IUwCvpO60juxJUqUtfm+6KqMyh/dOtivYrHImN9mU61JmizQLh//EDkjiUiL sazyAXuodOwz51NYbazN7zJVBhX98mQE7MFBbCapbdzvlIoJq92KBbL/nNjON3H5lBUGVlvHdaR3g m856FYlRc3EmbRYFWTsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJa8X-00062x-22; Wed, 12 Jul 2023 13:44:09 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJa8V-00062T-0o for linux-arm-kernel@lists.infradead.org; Wed, 12 Jul 2023 13:44:08 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-68336d06620so480440b3a.1 for ; Wed, 12 Jul 2023 06:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689169446; x=1691761446; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q9/dLQLgKmsLxbd3aGxhVA74ctHdZI0VI9d8S6+Rzsw=; b=mryBbePbwMBVx6XGrEXzXAOuHLh3UqdMw2WuA+6wIgGA/md7XMF35wZg3SodGqNqiL mGoA2T44pMO+KhpVvMgq+ThpLjCcQlA0RqJ3dnEoD7m8S4+LmshSNmGjBDFeWnnxJFWY UwRwq5/ZKqJ2H7b73YoB3fZKN35IEUNucCWhwe3FdzVI81TWEwWdBvTob7ztjYidCAYu lL/qSNW6pqCaV3HvhA9rB7nxLv/+MxwNqjld9rX5OVnMue2gNLAlvVqrRhEbXNZfExtJ RXR10sbFrRjfPDYh70iQt64CkjcVwo/sDmpvMxw+cS29hpSGNRhbs2VXvGex+fi/6Jrk wXGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689169446; x=1691761446; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q9/dLQLgKmsLxbd3aGxhVA74ctHdZI0VI9d8S6+Rzsw=; b=PXW2iKJaCImrckAfKbrtqt/kB8Q6zHWJT7dgVoMTkrgQLOvle4pzGUM3duC4rbC9XM pDQVmg61EpxAwF9xkOtqJT9nKHw/DSKCO7QV6r8rv4MAYDX2cvq1vhfutUBL4Rwf1v9U ByfJ7fUoQ6ieEx/SiX5JKRJNHjgAitMWcMw/Gmqe7UUwqKmUN+VXXyqmZXtrorITQ+AP C5+7j1H8YZMhu50ZhYsAfHoquQOgDyMIGhTkQmwKQz0Fq2cKlxmC7TFHJV/WlTEcHSI/ wJ8dwZIRlOOkb7e7hZT5SAWdnPHuD+Q4UoRzbbMF4tR/ZkzZpgBiNDaB495vbkGuJyOG xLCA== X-Gm-Message-State: ABy/qLZlmk4oHlI/sadPdEyUgrPkUGSVTQOQXNG3UIDNV+kqsELcAuTt 1JHQMhi/+OiSnf4x2Acd0SU= X-Google-Smtp-Source: APBJJlFqHYLPdidDJKh9YQWr3Pa5Bs3cdRBuunViOZ2SQO2tSMkp40pycRZcxbqDjBdj+InFa7/FaA== X-Received: by 2002:a05:6a00:b51:b0:668:8545:cbeb with SMTP id p17-20020a056a000b5100b006688545cbebmr26295423pfo.15.1689169445774; Wed, 12 Jul 2023 06:44:05 -0700 (PDT) Received: from localhost.localdomain ([113.103.7.132]) by smtp.gmail.com with ESMTPSA id c3-20020aa781c3000000b0067978a01246sm3775641pfn.14.2023.07.12.06.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 06:44:05 -0700 (PDT) From: Guiting Shen To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de Subject: [PATCH v4] pwm: atmel: Enable clk when pwm already enabled in bootloader Date: Wed, 12 Jul 2023 21:43:47 +0800 Message-Id: <20230712134347.14897-1-aarongt.shen@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_064407_289807_A1F0C409 X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, alexandre.belloni@bootlin.com, Guiting Shen , linux-kernel@vger.kernel.org, claudiu.beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver would never call clk_enable() if the PWM channel was already enabled in bootloader which lead to dump the warning message "the PWM clock already disabled" when turning off the PWM channel. Add atmel_pwm_enable_clk_if_on() in probe function to enable clock if the PWM channel was already enabled in bootloader. Signed-off-by: Guiting Shen --- drivers/pwm/pwm-atmel.c | 40 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index cdbc23649032..28ea0f7267ca 100644 --- a/drivers/pwm/pwm-atmel.c +++ b/drivers/pwm/pwm-atmel.c @@ -36,7 +36,7 @@ #define PWM_SR 0x0C #define PWM_ISR 0x1C /* Bit field in SR */ -#define PWM_SR_ALL_CH_ON 0x0F +#define PWM_SR_ALL_CH_MASK 0x0F /* The following register is PWM channel related registers */ #define PWM_CH_REG_OFFSET 0x200 @@ -464,6 +464,37 @@ static const struct of_device_id atmel_pwm_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, atmel_pwm_dt_ids); +static int atmel_pwm_enable_clk_if_on(struct atmel_pwm_chip *atmel_pwm) +{ + unsigned int i; + int err; + u32 sr; + + sr = atmel_pwm_readl(atmel_pwm, PWM_SR); + if (!(sr & PWM_SR_ALL_CH_MASK)) + return 0; + + for (i = 0; i < atmel_pwm->chip.npwm; i++) { + if (!(sr & (1 << i))) + continue; + + err = clk_enable(atmel_pwm->clk); + if (err) { + dev_err(atmel_pwm->chip.dev, + "failed to enable clock for pwm #%d: %pe\n", + i, ERR_PTR(err)); + + while (i--) { + if (sr & (1 << i)) + clk_disable(atmel_pwm->clk); + } + return err; + } + } + + return 0; +} + static int atmel_pwm_probe(struct platform_device *pdev) { struct atmel_pwm_chip *atmel_pwm; @@ -504,8 +535,15 @@ static int atmel_pwm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, atmel_pwm); + ret = atmel_pwm_enable_clk_if_on(atmel_pwm); + if (ret < 0) + goto remove_pwmchip; + return ret; +remove_pwmchip: + pwmchip_remove(&atmel_pwm->chip); + unprepare_clk: clk_unprepare(atmel_pwm->clk); return ret; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel