* [PATCH linux-next] ARM: unwind: use ex_frame with CONFIG_UNWINDER_FRAME_POINTER
@ 2023-05-18 8:58 guo.ziliang
2023-05-29 9:46 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: guo.ziliang @ 2023-05-18 8:58 UTC (permalink / raw)
To: linux, rmk+kernel
Cc: linus.walleij, lihuafei1, broonie, linux-arm-kernel, linux-kernel
From: guo ziliang <guo.ziliang@zte.com.cn>
We define ex_frame with CONFIG_UNWINDER_FRAME_POINTER in struct stackframe,
struct stackframe
{
......
#ifdef CONFIG_UNWINDER_FRAME_POINTER
bool ex_frame;
#endif
};
but we just use ex_frame without CONFIG_UNWINDER_FRAME_POINTER in
return_address() and unwind_frame().
Maybe we should fix it.
Signed-off-by: guo ziliang <guo.ziliang@zte.com.cn>
---
arch/arm/kernel/return_address.c | 2 ++
arch/arm/kernel/stacktrace.c | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c
index ac15db6..dae49e7 100644
--- a/arch/arm/kernel/return_address.c
+++ b/arch/arm/kernel/return_address.c
@@ -47,7 +47,9 @@ void *return_address(unsigned int level)
frame.kr_cur = NULL;
frame.tsk = current;
#endif
+#ifdef CONFIG_UNWINDER_FRAME_POINTER
frame.ex_frame = false;
+#endif
walk_stackframe(&frame, save_return_addr, &data);
diff --git a/arch/arm/kernel/stacktrace.c b/arch/arm/kernel/stacktrace.c
index 620aa82..338f552 100644
--- a/arch/arm/kernel/stacktrace.c
+++ b/arch/arm/kernel/stacktrace.c
@@ -82,6 +82,7 @@ int notrace unwind_frame(struct stackframe *frame)
if (frame_pointer_check(frame))
return -EINVAL;
+#ifdef CONFIG_UNWINDER_FRAME_POINTER
/*
* When we unwind through an exception stack, include the saved PC
* value into the stack trace.
@@ -102,6 +103,7 @@ int notrace unwind_frame(struct stackframe *frame)
frame->ex_frame = false;
return 0;
}
+#endif
/* restore the registers from the stack frame */
#ifdef CONFIG_CC_IS_CLANG
@@ -119,8 +121,10 @@ int notrace unwind_frame(struct stackframe *frame)
(void *)frame->fp, &frame->kr_cur);
#endif
+#ifdef CONFIG_UNWINDER_FRAME_POINTER
if (in_entry_text(frame->pc))
frame->ex_frame = true;
+#endif
return 0;
}
--
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] ARM: unwind: use ex_frame with CONFIG_UNWINDER_FRAME_POINTER
2023-05-18 8:58 guo.ziliang
@ 2023-05-29 9:46 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-05-29 9:46 UTC (permalink / raw)
To: guo.ziliang
Cc: linux, rmk+kernel, lihuafei1, broonie, linux-arm-kernel,
linux-kernel
On Thu, May 18, 2023 at 10:58 AM <guo.ziliang@zte.com.cn> wrote:
> From: guo ziliang <guo.ziliang@zte.com.cn>
>
> We define ex_frame with CONFIG_UNWINDER_FRAME_POINTER in struct stackframe,
> struct stackframe
> {
> ......
> #ifdef CONFIG_UNWINDER_FRAME_POINTER
> bool ex_frame;
> #endif
> };
> but we just use ex_frame without CONFIG_UNWINDER_FRAME_POINTER in
> return_address() and unwind_frame().
> Maybe we should fix it.
>
> Signed-off-by: guo ziliang <guo.ziliang@zte.com.cn>
Looks reasonable:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Is it possible to create a .config which expose this problem?
Then mention in the commit message "if you select A and B
then compilation fails..."
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH linux-next] ARM: unwind: use ex_frame with CONFIG_UNWINDER_FRAME_POINTER
@ 2023-07-12 7:56 guo.ziliang
0 siblings, 0 replies; 3+ messages in thread
From: guo.ziliang @ 2023-07-12 7:56 UTC (permalink / raw)
To: linus.walleij, linux, rmk+kernel
Cc: lihuafei1, broonie, linux-arm-kernel, linux-kernel
From: guo ziliang <guo.ziliang@zte.com.cn>
We define ex_frame with CONFIG_UNWINDER_FRAME_POINTER in struct stackframe,
struct stackframe
{
......
#ifdef CONFIG_UNWINDER_FRAME_POINTER
bool ex_frame;
#endif
};
but we just use ex_frame without CONFIG_UNWINDER_FRAME_POINTER in return_address()
and unwind_frame().
so when we config CONFIG_FRAME_POINTER=y and CONFIG_ARM_UNWIND=n, compile failed:
arch/arm/kernel/stacktrace.c: In function 'unwind_frame':
arch/arm/kernel/stacktrace.c:44:11: error: 'struct stackframe' has no member named 'ex_frame'
if (frame->ex_frame) {
^~
arch/arm/kernel/stacktrace.c:57:8: error: 'struct stackframe' has no member named 'ex_frame'
frame->ex_frame = false;
^~
arch/arm/kernel/stacktrace.c:67:8: error: 'struct stackframe' has no member named 'ex_frame'
frame->ex_frame = true;
^~
Maybe we should fix it.
Signed-off-by: guo ziliang <guo.ziliang@zte.com.cn>
---
arch/arm/kernel/return_address.c | 2 ++
arch/arm/kernel/stacktrace.c | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c
index ac15db6..dae49e7 100644
--- a/arch/arm/kernel/return_address.c
+++ b/arch/arm/kernel/return_address.c
@@ -47,7 +47,9 @@ void *return_address(unsigned int level)
frame.kr_cur = NULL;
frame.tsk = current;
#endif
+#ifdef CONFIG_UNWINDER_FRAME_POINTER
frame.ex_frame = false;
+#endif
walk_stackframe(&frame, save_return_addr, &data);
diff --git a/arch/arm/kernel/stacktrace.c b/arch/arm/kernel/stacktrace.c
index 620aa82..338f552 100644
--- a/arch/arm/kernel/stacktrace.c
+++ b/arch/arm/kernel/stacktrace.c
@@ -82,6 +82,7 @@ int notrace unwind_frame(struct stackframe *frame)
if (frame_pointer_check(frame))
return -EINVAL;
+#ifdef CONFIG_UNWINDER_FRAME_POINTER
/*
* When we unwind through an exception stack, include the saved PC
* value into the stack trace.
@@ -102,6 +103,7 @@ int notrace unwind_frame(struct stackframe *frame)
frame->ex_frame = false;
return 0;
}
+#endif
/* restore the registers from the stack frame */
#ifdef CONFIG_CC_IS_CLANG
@@ -119,8 +121,10 @@ int notrace unwind_frame(struct stackframe *frame)
(void *)frame->fp, &frame->kr_cur);
#endif
+#ifdef CONFIG_UNWINDER_FRAME_POINTER
if (in_entry_text(frame->pc))
frame->ex_frame = true;
+#endif
return 0;
}
--
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-12 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 7:56 [PATCH linux-next] ARM: unwind: use ex_frame with CONFIG_UNWINDER_FRAME_POINTER guo.ziliang
-- strict thread matches above, loose matches on Subject: below --
2023-05-18 8:58 guo.ziliang
2023-05-29 9:46 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).