From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDB54EB64DD for ; Thu, 13 Jul 2023 09:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BpdL6t5G0g9qqO5MVBR49V+EZ2MUmqCmsdXv/dBwSCo=; b=j5oBbaS26ileJRqY6EeCVPP+Bu d+AGsQPk77qH3rtCqwcxB6/J484R5toEu1MAPADl5hMvvbNYbL/Gw/x6M8j/s94bFz0PTxe2XUs7C R7Uu3iwFSX/qeANmJn5p01v3vGfV5CfxQglp4zLHSdvn0GT8aWoxXKiNlPYYVNVH85+Ouosr+bWd3 bX5UU856g1kkabnTpgSGUbKwq2Zh2/7SENJZ5/OwdHk70mvG/EZISN7EnG687cFYdpAua2AoO8NC8 EYorOj9CDm496S+51V9XDPMrDdTQqUK3lPU5twnDtYr8G/XmFKCiOgHAsqY1hQN72VZCQf65sc1mb YAMbPgPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJsDq-002XnR-2R; Thu, 13 Jul 2023 09:02:50 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJsDh-002Xcx-0d for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 09:02:42 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJsDZ-0004Hj-Dl; Thu, 13 Jul 2023 11:02:33 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qJsDX-00E4qI-So; Thu, 13 Jul 2023 11:02:31 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qJsDW-004WGM-Om; Thu, 13 Jul 2023 11:02:30 +0200 Date: Thu, 13 Jul 2023 11:02:30 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: Yangtao Li , Jaehoon Chung , Ulf Hansson , Alim Akhtar , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/58] mmc: dw_mmc: exynos: Convert to platform remove callback returning void Message-ID: <20230713090230.iwhicjbirll5icec@pengutronix.de> References: <20230713080807.69999-1-frank.li@vivo.com> <20230713080807.69999-14-frank.li@vivo.com> <75d2dc5e-4cbf-2519-cdf7-8fde374126ec@linaro.org> MIME-Version: 1.0 In-Reply-To: <75d2dc5e-4cbf-2519-cdf7-8fde374126ec@linaro.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_020241_235529_B3C20EE1 X-CRM114-Status: GOOD ( 19.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8340248759706337596==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8340248759706337596== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="d6d7itv6cdabafnt" Content-Disposition: inline --d6d7itv6cdabafnt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 13, 2023 at 10:11:15AM +0200, Krzysztof Kozlowski wrote: > On 13/07/2023 10:07, Yangtao Li wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is (mostly) ignored > > and this typically results in resource leaks. To improve here there is a > > quest to make the remove callback return void. In the first step of this > > quest all drivers are converted to .remove_new() which already returns > > void. > >=20 > > Trivially convert this driver from always returning zero in the remove > > callback to the void returning variant. >=20 > You even copied Uwe's commit msg... Aren't you duplicate his work or is > it being coordinated? We communicated and I politely asked to not interfer. This series is just what Yangtao had still pending. That's fine for me. Thanks for noticing, Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --d6d7itv6cdabafnt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSvvaUACgkQj4D7WH0S /k48vgf7B9pOCj8BEtBTeW/UjDXpN6Ydodk3PjPhDksAVMx3pfZiUm43bOVMgD/G 30npFfBBlwWgCrzx3XoBoJ2qFYHoq+pjTlH1EZcipdXN3/AONF5YUQ/OR3+CnwZd CWFxvF6RFK/LwkErVlFsrF6WBHpSkJ14lfMvSkAIPtOZ3JoykZtHd+D3YsQJvceS rikOZOHI3LJEKOmAPtfRNk+PjEfERw0T+2+/JiLIe4Cip7GZ2vOz5K+2YXRWHeRy 8vgSXOKRfegphqtSuE0qQxMrTafPsKsck4OKS5U8PC+ebYaW/MUwWTiU45RBiMiz QqeKHVZV1Vp2TKVzQSkDkGgoNkxFOw== =XV+K -----END PGP SIGNATURE----- --d6d7itv6cdabafnt-- --===============8340248759706337596== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8340248759706337596==--