From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F224C0015E for ; Thu, 13 Jul 2023 13:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UsNGAhQgIDcm63Lpcj+0l/HimfVEzfxY17mZvUVeN58=; b=PsdY/fX0WabQ6+ mFO1KX/RwUWXvfVbkNT7xxd/B9whmn7rT1pebF8Vxil1h4cMqBhcA50Se+devMlD7Cx7OYK5JieFg W1DHqrsBPROScbl62flmiDcVtQt2JsPqtp8xtyoL4tIVi/rsISnKHjC5iTa66/bK3FCeTgG/mpE8g c4lhni5ohTMBlVUbvrKX6g3eQW0kBjmSw8SK2yyBWlAfa1biKTHcyla5L3z5DHNEBEdA6WTQ3r2p7 LrU8RNsSaERSHKGg1zbGXoyXBfvz69hRLccdpP+JH6aFWt/4jCkgf48pZ81/3RnM/IWsm/zBPTfqx aXySjYVtkC1nCEuSY4WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJw0I-003LvG-01; Thu, 13 Jul 2023 13:05:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJvzt-003LTM-1X for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 13:04:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D50961570; Thu, 13 Jul 2023 06:05:17 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B3B33F73F; Thu, 13 Jul 2023 06:04:33 -0700 (PDT) Date: Thu, 13 Jul 2023 14:04:31 +0100 From: Sudeep Holla To: Yangtao Li Cc: Viresh Kumar , Sudeep Holla , "Rafael J. Wysocki" , Liviu Dudau , Lorenzo Pieralisi , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/19] cpufreq: vexpress: Convert to platform remove callback returning void Message-ID: <20230713130431.bj2p7v2hy7tt736j@bogus> References: <20230712093322.37322-1-frank.li@vivo.com> <20230712093322.37322-4-frank.li@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230712093322.37322-4-frank.li@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_060441_586831_773F7FE6 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 12, 2023 at 05:33:07PM +0800, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Cc: Uwe Kleine-K=F6nig I assume either Viresh will pick this or you are planning to group all similar changes and get it merged together. Either way, Reviewed-by: Sudeep Holla -- = Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel