From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 318D5EB64DD for ; Thu, 13 Jul 2023 13:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=doAaF9pDlfCEVEP/eYpCD0BeuDWpc13yFnD2TQtnYWk=; b=ntCXWRBs0uhy5x BLNTruyfxk50Ym0YwpHwnv66SrjfKA63gBia0uAA9oEnqXZm1FTWltSC9re6ueU7+84Rltrv/c3LP Uo/ChuykaA870rFmF9oq8kIzh4vewkL8xWzNIWvT9yPVp3mkrnJwhf5Cw6jbUU1OZ9HiZI8/N3tGK Vd83vil8wECfeLigJTGIqRFDYaum5+WOKQZOg0tfRg5IFT1dGj7GKp1IfXoKNY5C4Bn32HebKgywo EtEJvs1HPDlb0QoWGF+u4Jx/HDKfNgaD3ssHvRoXFKNyXbo9A5Dhdgieg6YF0La3vemxcqyqb7ux6 w2uIcQwLqBtYe/FDHktg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJw1t-003MZ6-0M; Thu, 13 Jul 2023 13:06:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJw1q-003MXb-0b for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 13:06:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 945161570; Thu, 13 Jul 2023 06:07:21 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9B503F73F; Thu, 13 Jul 2023 06:06:37 -0700 (PDT) Date: Thu, 13 Jul 2023 14:06:35 +0100 From: Sudeep Holla To: Yangtao Li Cc: Cristian Marussi , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/19] cpufreq: scpi: Convert to platform remove callback returning void Message-ID: <20230713130635.bxicz6vrj4gmzydl@bogus> References: <20230712093322.37322-1-frank.li@vivo.com> <20230712093322.37322-7-frank.li@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230712093322.37322-7-frank.li@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_060642_268622_4F573ECA X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 12, 2023 at 05:33:10PM +0800, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. Again I assume either Viresh will pick this or you are planning to group all similar changes and get it merged together. Either way, Reviewed-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel