From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37E2AC0015E for ; Thu, 13 Jul 2023 13:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KAnfxToJjzzyEzZ9VKwS4TO5DuTsTpKOmL+fif/nNzw=; b=ZOBN47yvedp7n9 JIvnU8pe6mLdAR6RcvOWv/5LNv1nJv2dTFKj2Dw8w5hHwQRhK0fCiklbZZ5z17eEBsAYFV5dfi0aY MLUy3knB5/M+AuDykKFUYz8HbX20Sh9sJvQzN6tCo3QIb8hzAzxsjBhuHJZqXmRwVVJcFq23paeT4 1FrVZaU6BLiXFYhHNZGdlldr2PF3tnc8+alhfd7p6G7SBKH0vZFEO5Jv8lyvSBiAh7KLXnOXhCz97 uxepWXYoSnaRu/tEv5W8s26zK4yX16i5DPBZDx4Cogmz+CDp26bAvOJJ44ihuD3zEk250Jfijgd3J jgUyxh032myjjghxwW+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJw6X-003NBD-0B; Thu, 13 Jul 2023 13:11:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJw6T-003N94-16; Thu, 13 Jul 2023 13:11:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39A1E1576; Thu, 13 Jul 2023 06:12:10 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 48A7A3F73F; Thu, 13 Jul 2023 06:11:26 -0700 (PDT) Date: Thu, 13 Jul 2023 14:11:23 +0100 From: Sudeep Holla To: Yang Li Cc: stanley.chu@mediatek.com, jejb@linux.ibm.com, martin.petersen@oracle.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-scsi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abaci Robot Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err() Message-ID: <20230713131123.uo5ofltbhvktkevd@bogus> References: <20230712064832.44188-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230712064832.44188-1-yang.lee@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_061129_425677_681A9C4D X-CRM114-Status: UNSURE ( 8.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 12, 2023 at 02:48:32PM +0800, Yang Li wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 Acked-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel