From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A090FEB64DD for ; Thu, 13 Jul 2023 13:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tOwFT8Xp6qo0JvBMnEKAoYu2FVIxvHyxaTrwtCXEulU=; b=4N9T675tx+4ucV gnTQ75pyrWaGFUGOEDRQjtQd3dTbKcvcx2DXrhIrznzuZLMGgqRqW9CP6hY0zeHGWpkOv0+AqrN1q AZmEDB5Xp59QwvZQEKclO1wcSa0q+Cg0iZD4XU3dgIyB/7y7At2qPo/npVRwjregUOT83d7JxJB8K roOx4LkKrHohohY4mCt1ZTewS++iSwcbUgpZfw3gaO5VueJNRMZUljvjVLYUut9lcgCjcxmygrQyL hW8Z0PnKBXxPHTE8i2djhT3xBhIh+xH8XfO57MfFVSdZR17Oi2vh1iKmJLNSVekJ5XqplKXYF4Bnb D0Y9lN6STOC769/V5eEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJwGY-003OoY-0v; Thu, 13 Jul 2023 13:21:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJwGR-003Okp-1M; Thu, 13 Jul 2023 13:21:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 943C01570; Thu, 13 Jul 2023 06:22:26 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3EDF3F73F; Thu, 13 Jul 2023 06:21:42 -0700 (PDT) Date: Thu, 13 Jul 2023 14:21:40 +0100 From: Sudeep Holla To: Yang Li Cc: stanley.chu@mediatek.com, jejb@linux.ibm.com, martin.petersen@oracle.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-scsi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abaci Robot Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err() Message-ID: <20230713132140.azamscgceh6yyy6j@bogus> References: <20230712064832.44188-1-yang.lee@linux.alibaba.com> <20230713131123.uo5ofltbhvktkevd@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230713131123.uo5ofltbhvktkevd@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_062147_503568_E2D511CA X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 13, 2023 at 02:11:23PM +0100, Sudeep Holla wrote: > On Wed, Jul 12, 2023 at 02:48:32PM +0800, Yang Li wrote: > > There is no need to call the dev_err() function directly to print a > > custom message when handling an error from either the platform_get_irq() > > or platform_get_irq_byname() functions as both are going to display an > > appropriate error message in case of a failure. > > > > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error > > > > Reported-by: Abaci Robot > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 > > Acked-by: Sudeep Holla > Sorry for this, I didn't mean to ack this patch, no idea how on earth I managed to do that (must be some wrong key combination in my email client) but I wanted and meant to ack only this [1]. Sorry for the noise. -- Regards, Sudeep [1] https://lore.kernel.org/r/20230712062853.11007-9-frank.li@vivo.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel