From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEE98C001B0 for ; Thu, 13 Jul 2023 18:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mjcC7fx7isyM8PkB6hiAykDOcbz9+oUfES+ylkfEyw0=; b=Fz3jlnrpAdYBAd 6rUyJ+sE8WXChAYqseEOLjlMyy1VZlk8vdBu/kU2au9pAgBrrPs43B8vol7brbHGhHw+YfiWgNBQg 1Zlp360J6tjVtXPWC/HiR0sUbg6xxOwSgafTjzMp41Bl/OCMYmn5suYZMn0fXl1SqKYnONJSjnC6y 2r9m9tmDgN9HFvLcygYitzqtcMDj+37yQQO1LX2XxNnk//arxkimGd5ZOPrO01n0+TibHfB+BWgtt tucccg8hpsx2/1bKjGvCDSpIXk8JovW+V680v3m1E26Rl813SS/4gpehRfZ8XZhSgZmr6vmKOPuG/ m6UOW2Eso8/FP+QQp9Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qK0wJ-0047v9-2g; Thu, 13 Jul 2023 18:21:19 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qK0wG-0047u9-2G for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 18:21:18 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 36DIL7Qk083022; Thu, 13 Jul 2023 13:21:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1689272467; bh=EujEkEbqmzWpWU/kv+bpKsFhVWw8zK17xtacArJ+lhA=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=jNc0ArRmJcvP8r1r52CMUBo65vO3qIX4C3OeYrwgIB80Js5PDYBYIw+Dl2J2vx1Ii YvKfqA3taKIebSxCouq7cqxcwZDd26g9A87G0f6pNp+9mMOJ3ACYINiliZ/PtpP/qN ICL9Enf9ZXHda8obQw93Fm69F4RS/Q3g/wjoDqyc= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 36DIL7ac091856 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Jul 2023 13:21:07 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 13 Jul 2023 13:21:07 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 13 Jul 2023 13:21:07 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 36DIL7eC048060; Thu, 13 Jul 2023 13:21:07 -0500 Date: Thu, 13 Jul 2023 13:21:07 -0500 From: Nishanth Menon To: Jayesh Choudhary CC: , , , , , , , , Subject: Re: [PATCH v5 3/5] arm64: dts: ti: k3-j784s4: Add WIZ and SERDES PHY nodes Message-ID: <20230713182107.ashuygyg4x4j77s5@backboard> References: <20230710101705.154119-1-j-choudhary@ti.com> <20230710101705.154119-4-j-choudhary@ti.com> <20230712141828.lnpo4mhd5dv34rlz@census> <18310450-05f3-172c-e4bc-fda114f333a4@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <18310450-05f3-172c-e4bc-fda114f333a4@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_112116_911799_0970CDF6 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21:01-20230713, Jayesh Choudhary wrote: > > > On 12/07/23 19:48, Nishanth Menon wrote: > > On 15:47-20230710, Jayesh Choudhary wrote: > > > From: Siddharth Vadapalli > > > > > > J784S4 SoC has 4 Serdes instances along with their respective WIZ > > > instances. Add device-tree nodes for them and disable them by default. > > > > > > Signed-off-by: Siddharth Vadapalli > > > [j-choudhary@ti.com: fix serdes_wiz clock order] > > > Signed-off-by: Jayesh Choudhary > > > --- > > NAK. This patch introduces the following dtbs_check warning. > > arch/arm64/boot/dts/ti/k3-am69-sk.dtb: serdes-refclk: 'clock-frequency' is a required property > > > > Sorry for this. This property was added in the final board file. > I will fix it in the next revision. > I will add '0' as clock-property in the main file similar to j721e[1] > which will be overridden in the board file with required value to get > rid of this warning. That would follow what renesas (r8a774a1.dtsi) and imx (imx8dxl-ss-conn.dtsi) seem to be doing as well. Just make sure to add documentation to the property to indicate expectation. Unless someone has objections to this approach. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel