From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA85EC0015E for ; Thu, 13 Jul 2023 13:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gkOlZcG740Q5M1i0Zr5QiOwEhOncYG/wVtiPzrPl/+A=; b=PQ1FApv7gN4s79 TT4kBv1F7dl5y0YncaEJG9ooC0ytineR7w4ItgFtFT135OfWLCI7F53KK5USNGjevt1qFiWHenjCr p186RFsUdPFmg/8WB1igycXbh5x6vMkeXlFEoI8YxTeyEvgQuahACQwLqosn0vGdb/LiROZt562Y+ KkjFPX11Ol+nU8r+pVU9ApdKvyXhjEx/7Rb3UPnsyqNHmCjaJ3o35ZGH22UizMgpZKbs8o4kNOnIq WMhBL6pcxlUdlBZw6h356aHnARSwOm2jnOJ+H3Q/2cNZzTE+byKXL+pNNEkBi3qmx0xTvrY+gwbWi PFY7sCssLCgTwZOCYxRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJwkn-003TGh-0C; Thu, 13 Jul 2023 13:53:09 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJwkk-003TGN-0U for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 13:53:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6D6C6153B; Thu, 13 Jul 2023 13:53:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EC08C433C8; Thu, 13 Jul 2023 13:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689256383; bh=w5LLgIZiA/btIJxLrU1uFBOOrNr8csz5UTI65mS9fq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mt/jU90KgCZ+fRV/Z6tu1bSY3p4Amf7wsK4qQwPlj2t2+F4Y/puWkPD+K1WweHZh2 hhwWo2HgFZwd7Usob9eVzCCuh1B1CBJzjDmo0rOxhhgMxNvuCCcQGm3uGw+2sEbvUQ wHMhwMzn2RIho40hg6LdEGAm9dUW1lvVXLeCwyQw= Date: Thu, 13 Jul 2023 15:52:58 +0200 From: Greg KH To: Souradeep Chowdhury Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Andy Gross , Konrad Dybcio , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sibi Sankar , Rajendra Nayak Subject: Re: [PATCH V1 0/3] Add notifier call chain to Embedded USB Debug(EUD) driver Message-ID: <2023071328-siamese-brethren-0174@gregkh> References: <2023071218-woven-oversleep-444f@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_065306_253319_2B449E4A X-CRM114-Status: GOOD ( 24.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 13, 2023 at 01:55:34PM +0530, Souradeep Chowdhury wrote: > > > On 7/12/2023 10:10 PM, Greg KH wrote: > > On Wed, Jul 12, 2023 at 01:52:37PM +0530, Souradeep Chowdhury wrote: > > > This patch series adds the notifier chain to the Embedded USB Debug(EUD) driver. > > > The notifier chain is used to check the role switch status of EUD. Since EUD can > > > function only in device mode, other modules trying to do role-switch on the same > > > port have to first check the EUD status by calling this notifier chain and based > > > on the status proceed or block their role-switching step. The modules can call > > > the notifier through the call eud_notifier_call_chain and pass their own > > > role switch state as the argument. This chain will also be able to handle the > > > scenario of multiple modules switching roles on the same port since this can > > > create a priority and ordering among them for conflict resolution. > > > > You are adding a new api that no one is actually using, so why would we > > accept this at all? > > > > And how can we actually review it without any real users? > > Ack. The next version of this will be posted along with the usage > of these apis for ordering the role-switch. Also note that I hate notifier call chains, so you better have a very good reason for why they are required and can't be done in any other normal way instead :) good luck! greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel