Re: [PATCH v8 0/4] Add support for Allwinner GPADC on D1/T113s/R329/T507 SoCs

Jonathan Cameron
2023-07-08T14:06:56Z

On Mon, 19 Jun 2023 18:42:23 +0300
Maksim Kiselev <bigunclemax@gmail.com> wrote:

> This series adds support for general purpose ADC (GPADC) on new
> Allwinner's SoCs, such as D1, T113s, T507 and R329. The implemented driver
> provides basic functionality for getting ADC channels data.
Applied 1-3 to the togreg branch of iio.git which will initially be pushed out as
testing so that 0-day can see if we missed anything. I'll also be rebasing it
on rc1 once available before pushing out as togreg.

Thanks,

Jonathan

>
> Change History:
> v8:
> - Added patch that changes Kconfig description for previous Allwinner GPADC
> - Changed Kconfig description for this GPADC driver
> - Fixed 'reg' range for gpadc node in 'sunxi-d1s-t113.dtsi'
>
> v7:
> - Fixed typo in DT bindings property
>
> v6:
> - Fixed DT bindings regexp for channel properties
> - Dropped checking the max number of channels from the drivers code
> (This is redundant as we raly on DT bindings check)
>
> v5:
> - Fixed DT bindings properties for child nodes
>
> v4:
> - Fixed DT bindings warnings
> - Used GENMASK to clear the irq register
> - Minor formatting fixes
>
> v3:
> - Added DT bindings dual license, fixed property order and example formatting
> - Added explanations comments for timeout and mutex
> - Dropped unnecessary regmap and used readl/writel instead
> - Added error message about getting channel number
> - Renamed labels and variables to make them self-explanatory
>
> v2:
> - Added lastch flag to avoid addition work for already selected channel
> - Added reset assertion on module remove
> - Added dynamic channel allocation and dropped iio_chan_spec arrays
> - Changed IIO_CHAN_INFO_SCALE type to FRACTIONAL_LOG2
> - Dropped separate compatible strings and configs for T113s and R329
> - Fixed includes
> - Fixed Kconfig description
> - Removed duplicate probe error messages
> - Used FIELD_PREP for bit setup
>
> v1:
> - Initial version
>
> Maksim Kiselev (4):
> iio: adc: Kconfig change description for Allwinner GPADC
> iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC
> dt-bindings: iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC
> riscv: dts: allwinner: d1: Add GPADC node
>
> .../iio/adc/allwinner,sun20i-d1-gpadc.yaml | 91 ++++++
> .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 10 +
> drivers/iio/adc/Kconfig | 12 +-
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/sun20i-gpadc-iio.c | 276 ++++++++++++++++++
> 5 files changed, 389 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
> create mode 100644 drivers/iio/adc/sun20i-gpadc-iio.c