From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Date: Sun, 16 Jul 2023 17:11:34 +0100 From: Jonathan Cameron Subject: Re: [PATCH v1 0/3] iio: adc: meson: tune init sequence Message-ID: <20230716171134.43d05c45@jic23-huawei> In-Reply-To: <20230715110654.6035-1-gnstark@sberdevices.ru> References: <20230715110654.6035-1-gnstark@sberdevices.ru> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+lwn-linux-arm-kernel=archive.lwn.net@lists.infradead.org List-Archive: To: George Stark Cc: lars@metafoo.de, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, andriy.shevchenko@linux.intel.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@sberdevices.ru On Sat, 15 Jul 2023 14:05:57 +0300 George Stark wrote: > This patch is a part of effort to support meson a1 SoC and make meson saradc driver > independent from vendor boot code initialization in common. > > Information was taken from vendor kernel 5.4, 4.19 and vendor uboot 2019. > Most of the bits are undocumented at all or it's not said how they affect measuring. > > All those bits are already initialized in bl* code and since kernel driver dosn't > rewrite or reset any registers but only changes some bits at init stage everything > works fine. > > Test procedure is rather simple - one can change those bits in runtime > (e.g. using devmem) and try to read channels (cat /sys/bus/platform/drivers/meson-saradc/.../iio:device0/*) > changing some of those bits leads to measure procedure errors or abnormal results. > Another test is build meson saradc as module, reset adc by reset bit, reload module > and compare measure results to those got before reset. > > George Stark (3): > iio: adc: meson: init channels 0,1 input muxes > iio: adc: meson: init internal continuous ring counter > iio: adc: meson: init voltage control bits > > drivers/iio/adc/meson_saradc.c | 73 ++++++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > These look fine to me, but I'd like them to sit on list a little while on off chance anyone else has feedback on them. Thanks, Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel