linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: keystone: Drop unused includes
@ 2023-07-17 22:56 Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-07-17 22:56 UTC (permalink / raw)
  To: Bartosz Golaszewski, Russell King; +Cc: linux-arm-kernel, linux-kernel

of_platform.h include is not needed, so drop it. It implicitly includes
of.h (for now) which is needed.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/mach-davinci/pdata-quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
index b8b5f1a5e092..b5b5c7bda61e 100644
--- a/arch/arm/mach-davinci/pdata-quirks.c
+++ b/arch/arm/mach-davinci/pdata-quirks.c
@@ -5,7 +5,7 @@
  * Copyright (C) 2016 BayLibre, Inc
  */
 #include <linux/kernel.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <media/i2c/tvp514x.h>
 #include <media/i2c/adv7343.h>
-- 
2.40.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: keystone: Drop unused includes
@ 2023-07-17 22:56 Rob Herring
       [not found] ` <169028492642.1718138.9430735746671016845.b4-ty@ti.com>
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2023-07-17 22:56 UTC (permalink / raw)
  To: Nishanth Menon, Santosh Shilimkar, Russell King
  Cc: linux-arm-kernel, linux-kernel

Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h
(for now) which is needed.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/mach-keystone/keystone.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
index 68039aad3014..e0ca26182e0b 100644
--- a/arch/arm/mach-keystone/keystone.c
+++ b/arch/arm/mach-keystone/keystone.c
@@ -7,12 +7,10 @@
  *	Santosh Shilimkar <santosh.shillimkar@ti.com>
  */
 #include <linux/io.h>
-#include <linux/of.h>
 #include <linux/dma-map-ops.h>
 #include <linux/init.h>
-#include <linux/of_platform.h>
-#include <linux/of_address.h>
 #include <linux/memblock.h>
+#include <linux/platform_device.h>
 
 #include <asm/setup.h>
 #include <asm/mach/map.h>
-- 
2.40.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: keystone: Drop unused includes
       [not found] ` <169028492642.1718138.9430735746671016845.b4-ty@ti.com>
@ 2023-08-22 22:28   ` Rob Herring
  2023-08-22 23:03     ` Nishanth Menon
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2023-08-22 22:28 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Santosh Shilimkar, Russell King, linux-arm-kernel, linux-kernel

On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote:
>
> Hi Rob Herring,
>
> On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> > Several includes are not needed, so drop them.
> >
> > of_platform.h is not needed, but it implicitly includes platform_device.h
> > (for now) which is needed.
> >
> >
>
> I have applied the following to branch ti-keystone-next on [1].
> Thank you!
>
> [1/1] ARM: keystone: Drop unused includes
>       commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

Did you really? Doesn't look like this is in linux-next.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: keystone: Drop unused includes
  2023-08-22 22:28   ` Rob Herring
@ 2023-08-22 23:03     ` Nishanth Menon
  2023-08-23 16:53       ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Nishanth Menon @ 2023-08-22 23:03 UTC (permalink / raw)
  To: Rob Herring
  Cc: Santosh Shilimkar, Russell King, linux-arm-kernel, linux-kernel

On 17:28-20230822, Rob Herring wrote:
> On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote:
> >
> > Hi Rob Herring,
> >
> > On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> > > Several includes are not needed, so drop them.
> > >
> > > of_platform.h is not needed, but it implicitly includes platform_device.h
> > > (for now) which is needed.
> > >
> > >
> >
> > I have applied the following to branch ti-keystone-next on [1].
> > Thank you!
> >
> > [1/1] ARM: keystone: Drop unused includes
> >       commit: 630c191b3396c6aaccab1234f8834848a2c42e8a
> 
> Did you really? Doesn't look like this is in linux-next.

Seems to have been there for a while?

https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/log/?h=ti-keystone-next

https://patchwork.kernel.org/project/linux-soc/patch/20230814160702.6l2fcujbx33eogap@junction/

$ git tag --contains 630c191b3396c6aaccab1234f8834848a2c42e8a
next-20230801
next-20230802
next-20230804
next-20230807
next-20230808
next-20230809
next-20230816
next-20230817
next-20230818
next-20230821
next-20230822
ti-keystone-soc-for-v6.6


Did I miss something?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: keystone: Drop unused includes
  2023-08-22 23:03     ` Nishanth Menon
@ 2023-08-23 16:53       ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-08-23 16:53 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Santosh Shilimkar, Russell King, linux-arm-kernel, linux-kernel

On Tue, Aug 22, 2023 at 6:03 PM Nishanth Menon <nm@ti.com> wrote:
>
> On 17:28-20230822, Rob Herring wrote:
> > On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote:
> > >
> > > Hi Rob Herring,
> > >
> > > On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> > > > Several includes are not needed, so drop them.
> > > >
> > > > of_platform.h is not needed, but it implicitly includes platform_device.h
> > > > (for now) which is needed.
> > > >
> > > >
> > >
> > > I have applied the following to branch ti-keystone-next on [1].
> > > Thank you!
> > >
> > > [1/1] ARM: keystone: Drop unused includes
> > >       commit: 630c191b3396c6aaccab1234f8834848a2c42e8a
> >
> > Did you really? Doesn't look like this is in linux-next.
>
> Seems to have been there for a while?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/log/?h=ti-keystone-next
>
> https://patchwork.kernel.org/project/linux-soc/patch/20230814160702.6l2fcujbx33eogap@junction/
>
> $ git tag --contains 630c191b3396c6aaccab1234f8834848a2c42e8a
> next-20230801
> next-20230802
> next-20230804
> next-20230807
> next-20230808
> next-20230809
> next-20230816
> next-20230817
> next-20230818
> next-20230821
> next-20230822
> ti-keystone-soc-for-v6.6
>
>
> Did I miss something?

Sorry, I sent the davinci changes also with 'keystone' in the subject
by mistake and confused myself...

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-08-23 16:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 22:56 [PATCH] ARM: keystone: Drop unused includes Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2023-07-17 22:56 Rob Herring
     [not found] ` <169028492642.1718138.9430735746671016845.b4-ty@ti.com>
2023-08-22 22:28   ` Rob Herring
2023-08-22 23:03     ` Nishanth Menon
2023-08-23 16:53       ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).