From: Conor Dooley <conor@kernel.org>
To: Durai Manickam KR <durai.manickamkr@microchip.com>
Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com,
devicetree@vger.kernel.org, jerry.ray@microchip.com,
Hari.PrasathGE@microchip.com, varshini.rajendran@microchip.com,
Horatiu.Vultur@microchip.com, manikandan.m@microchip.com,
jesper.nilsson@axis.com, balamanikandan.gunasundar@microchip.com,
michael@walle.cc, dharma.b@microchip.com,
linux-serial@vger.kernel.org, cristian.birsan@microchip.com,
nayabbasha.sayed@microchip.com, conor+dt@kernel.org,
arnd@arndb.de, andre.przywara@arm.com, radu_nicolae.pirea@upb.ro,
soc@kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
balakrishnan.s@microchip.com, ada@thorsis.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, richard.genoud@gmail.com,
krzysztof.kozlowski@linaro.org, Kavyasree.Kotagiri@microchip.com,
olof@lixom.net, davem@davemloft.net
Subject: Re: [PATCHv3 1/2] dt-bindings: serial: atmel,at91-usart: update compatible for sam9x60
Date: Tue, 18 Jul 2023 12:12:50 +0100 [thread overview]
Message-ID: <20230718-confidant-good-b85bad860beb@spud> (raw)
In-Reply-To: <20230718065735.10187-2-durai.manickamkr@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 1946 bytes --]
On Tue, Jul 18, 2023 at 12:27:34PM +0530, Durai Manickam KR wrote:
> There is only one debug unit in the sam9x60 SOC and it has the chipid
> register. So, the dbgu compatible strings are valid only for debug usart.
> Defining these dbgu compatible strings are not valid for flexcom usart.
> So adding the items which is valid only for flexcom usart and removing
> the microchip,sam9x60-usart compatible string from the enum list as no
> usart node defines only this specific compatible string.
It may have been worth pointing out that had any DTS used the compatible
that is being disallowed in isolation after this change, no driver in
Linux would have bound to it anyway.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
>
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
> ---
> .../devicetree/bindings/serial/atmel,at91-usart.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> index 30b2131b5860..65cb2e5c5eee 100644
> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> @@ -16,13 +16,15 @@ properties:
> - enum:
> - atmel,at91rm9200-usart
> - atmel,at91sam9260-usart
> - - microchip,sam9x60-usart
> - items:
> - const: atmel,at91rm9200-dbgu
> - const: atmel,at91rm9200-usart
> - items:
> - const: atmel,at91sam9260-dbgu
> - const: atmel,at91sam9260-usart
> + - items:
> + - const: microchip,sam9x60-usart
> + - const: atmel,at91sam9260-usart
> - items:
> - const: microchip,sam9x60-dbgu
> - const: microchip,sam9x60-usart
> --
> 2.25.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-19 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 6:57 [PATCHv3 0/2] update at91 usart compatible for sam9x60 Durai Manickam KR
2023-07-18 6:57 ` [PATCHv3 1/2] dt-bindings: serial: atmel,at91-usart: update " Durai Manickam KR
2023-07-18 11:12 ` Conor Dooley [this message]
2023-07-18 6:57 ` [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection Durai Manickam KR
2023-07-31 13:35 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718-confidant-good-b85bad860beb@spud \
--to=conor@kernel.org \
--cc=Hari.PrasathGE@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=ada@thorsis.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=balakrishnan.s@microchip.com \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=conor+dt@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dharma.b@microchip.com \
--cc=durai.manickamkr@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jerry.ray@microchip.com \
--cc=jesper.nilsson@axis.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=manikandan.m@microchip.com \
--cc=michael@walle.cc \
--cc=nayabbasha.sayed@microchip.com \
--cc=olof@lixom.net \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox