* [PATCH] arm64: dts: imx8mn-evk: Pass GPIO_OPEN_DRAIN flag
@ 2023-06-21 17:37 Fabio Estevam
2023-07-18 2:48 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2023-06-21 17:37 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
scl-gpios and sda-gpios need GPIO_OPEN_DRAIN flag, otherwise the
following run-time warning is seen:
gpio-144 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
gpio-146 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
index 1443857bfa5f..f48f854c3768 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
@@ -163,8 +163,8 @@ &i2c2 {
pinctrl-names = "default", "gpio";
pinctrl-0 = <&pinctrl_i2c2>;
pinctrl-1 = <&pinctrl_i2c2_gpio>;
- scl-gpios = <&gpio5 16 GPIO_ACTIVE_HIGH>;
- sda-gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>;
+ scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
status = "okay";
ptn5110: tcpc@50 {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: imx8mn-evk: Pass GPIO_OPEN_DRAIN flag
2023-06-21 17:37 [PATCH] arm64: dts: imx8mn-evk: Pass GPIO_OPEN_DRAIN flag Fabio Estevam
@ 2023-07-18 2:48 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2023-07-18 2:48 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, Fabio Estevam
On Wed, Jun 21, 2023 at 02:37:11PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> scl-gpios and sda-gpios need GPIO_OPEN_DRAIN flag, otherwise the
> following run-time warning is seen:
>
> gpio-144 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
> gpio-146 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-19 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 17:37 [PATCH] arm64: dts: imx8mn-evk: Pass GPIO_OPEN_DRAIN flag Fabio Estevam
2023-07-18 2:48 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).