From: Tony Lindgren <tony@atomide.com>
To: "guomengqi (A)" <guomengqi3@huawei.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
haojian.zhuang@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] pinctrl: single: Fix memleak in pcs_dt_node_to_map
Date: Tue, 18 Jul 2023 08:29:20 +0300 [thread overview]
Message-ID: <20230718052920.GG5194@atomide.com> (raw)
In-Reply-To: <7b9d0af0-6990-9696-0dc2-acef2543b2a8@huawei.com>
Hi,
* guomengqi (A) <guomengqi3@huawei.com> [230712 10:00]:
> 在 2023/7/6 12:07, Tony Lindgren 写道:
> > Thanks for looking into it. I wonder if we can rely on naming for
> > pinmux_func_name_to_selector() though. Can things change in a way where
> > we need to release everything and reparse? Mostly wondering what happens
> > with DT overlays?
>
> Let me confirm, you mean when the pin controller dtsi changed at runtime,
> some functions and groups can change silently while the dt-node name remains
> same, so the old data needs to be released and reparsed, right?
>
> I don't know much about DT overlays. I can look deeper into revelant codes,
> maybe do some experiments too.
>
> My guess now is DT overlay will first remove the old parsed nodes, then
> create new ones. If so, the modification to pcs_dt_node_to_map() in this
> patch is not affected.
OK yeah good to check it to confirm.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-07-19 5:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 8:17 [PATCH] pinctrl: single: Fix memleak in pcs_dt_node_to_map Guo Mengqi
2023-07-03 12:32 ` kernel test robot
2023-07-03 14:59 ` kernel test robot
2023-07-04 9:18 ` Linus Walleij
2023-07-06 3:21 ` guomengqi (A)
2023-07-06 4:07 ` Tony Lindgren
2023-07-12 10:00 ` guomengqi (A)
2023-07-18 5:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718052920.GG5194@atomide.com \
--to=tony@atomide.com \
--cc=guomengqi3@huawei.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).