* [PATCH] ARM64: dts: freescale: Fix VPU G2 clock
@ 2023-07-07 9:42 Benjamin Gaignard
2023-07-07 10:08 ` Markus Elfring
2023-07-18 7:08 ` [PATCH] " Shawn Guo
0 siblings, 2 replies; 6+ messages in thread
From: Benjamin Gaignard @ 2023-07-07 9:42 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, linux-imx, ezequiel, aford173
Cc: devicetree, linux-arm-kernel, linux-kernel, kernel,
Benjamin Gaignard
Set VPU G2 clock to 300MHz like described in documentation.
This fix pixels error occurring with large resolution ( >= 2560x1600)
HEVC test stream when using the postprocessor to produce NV12.
Fixes: 4ac7e4a81272 ("arm64: dts: imx8mq: Enable both G1 and G2 VPU's with vpu-blk-ctrl")
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 0492556a10db..345c70c6c697 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -770,7 +770,7 @@ pgc_vpu: power-domain@6 {
<&clk IMX8MQ_SYS1_PLL_800M>,
<&clk IMX8MQ_VPU_PLL>;
assigned-clock-rates = <600000000>,
- <600000000>,
+ <300000000>,
<800000000>,
<0>;
};
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM64: dts: freescale: Fix VPU G2 clock
2023-07-07 9:42 [PATCH] ARM64: dts: freescale: Fix VPU G2 clock Benjamin Gaignard
@ 2023-07-07 10:08 ` Markus Elfring
2023-07-18 7:06 ` Shawn Guo
2023-07-18 7:08 ` [PATCH] " Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2023-07-07 10:08 UTC (permalink / raw)
To: Benjamin Gaignard, devicetree, kernel-janitors, linux-arm-kernel,
linux-imx, kernel, kernel
Cc: LKML, Adam Ford, Conor Dooley, Ezequiel Garcia, Fabio Estevam,
Krzysztof Kozlowski, Rob Herring, Sascha Hauer, Shawn Guo
> Set VPU G2 clock to 300MHz like described in documentation.
> This fix pixels error …
Would you like to avoid typos in such a change description?
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM64: dts: freescale: Fix VPU G2 clock
2023-07-07 10:08 ` Markus Elfring
@ 2023-07-18 7:06 ` Shawn Guo
2023-07-18 8:03 ` Markus Elfring
2023-07-18 8:15 ` Markus Elfring
0 siblings, 2 replies; 6+ messages in thread
From: Shawn Guo @ 2023-07-18 7:06 UTC (permalink / raw)
To: Markus Elfring
Cc: Benjamin Gaignard, devicetree, kernel-janitors, linux-arm-kernel,
linux-imx, kernel, kernel, LKML, Adam Ford, Conor Dooley,
Ezequiel Garcia, Fabio Estevam, Krzysztof Kozlowski, Rob Herring,
Sascha Hauer
On Fri, Jul 07, 2023 at 12:08:34PM +0200, Markus Elfring wrote:
> > Set VPU G2 clock to 300MHz like described in documentation.
> > This fix pixels error …
>
> Would you like to avoid typos in such a change description?
I assume you are suggesting s/fix/fixes? I can fix it up when applying.
Thanks!
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM64: dts: freescale: Fix VPU G2 clock
2023-07-07 9:42 [PATCH] ARM64: dts: freescale: Fix VPU G2 clock Benjamin Gaignard
2023-07-07 10:08 ` Markus Elfring
@ 2023-07-18 7:08 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2023-07-18 7:08 UTC (permalink / raw)
To: Benjamin Gaignard
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, s.hauer, kernel,
festevam, linux-imx, ezequiel, aford173, devicetree,
linux-arm-kernel, linux-kernel, kernel
On Fri, Jul 07, 2023 at 11:42:00AM +0200, Benjamin Gaignard wrote:
> Set VPU G2 clock to 300MHz like described in documentation.
> This fix pixels error occurring with large resolution ( >= 2560x1600)
> HEVC test stream when using the postprocessor to produce NV12.
>
> Fixes: 4ac7e4a81272 ("arm64: dts: imx8mq: Enable both G1 and G2 VPU's with vpu-blk-ctrl")
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
We use prefix "arm64: dts: ..." for arm64 DTS changes. I fixed it up
and applied the patch.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM64: dts: freescale: Fix VPU G2 clock
2023-07-18 7:06 ` Shawn Guo
@ 2023-07-18 8:03 ` Markus Elfring
2023-07-18 8:15 ` Markus Elfring
1 sibling, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2023-07-18 8:03 UTC (permalink / raw)
To: Shawn Guo, Benjamin Gaignard, devicetree, kernel-janitors,
linux-arm-kernel, linux-imx, kernel, kernel
Cc: LKML, Adam Ford, Conor Dooley, Ezequiel Garcia, Fabio Estevam,
Krzysztof Kozlowski, Rob Herring, Sascha Hauer
>>> Set VPU G2 clock to 300MHz like described in documentation.
>>> This fix pixels error …
>>
>> Would you like to avoid typos in such a change description?
>
> I assume you are suggesting s/fix/fixes?
Probably, yes.
> I can fix it up when applying.
How do you think about to reconsider also the word combination “pixels error”?
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ARM64: dts: freescale: Fix VPU G2 clock
2023-07-18 7:06 ` Shawn Guo
2023-07-18 8:03 ` Markus Elfring
@ 2023-07-18 8:15 ` Markus Elfring
1 sibling, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2023-07-18 8:15 UTC (permalink / raw)
To: Shawn Guo, Benjamin Gaignard, devicetree, kernel-janitors,
linux-arm-kernel, linux-imx, kernel, kernel
Cc: LKML, Adam Ford, Conor Dooley, Ezequiel Garcia, Fabio Estevam,
Krzysztof Kozlowski, Rob Herring, Sascha Hauer
>>> Set VPU G2 clock to 300MHz like described in documentation.
>>> This fix pixels error …
>>
>> Would you like to avoid typos in such a change description?
>
> … I can fix it up when applying.
Can a specification like “300 MHz” be nicer?
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-19 6:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-07 9:42 [PATCH] ARM64: dts: freescale: Fix VPU G2 clock Benjamin Gaignard
2023-07-07 10:08 ` Markus Elfring
2023-07-18 7:06 ` Shawn Guo
2023-07-18 8:03 ` Markus Elfring
2023-07-18 8:15 ` Markus Elfring
2023-07-18 7:08 ` [PATCH] " Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).