From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 172F2EB64DA for ; Wed, 19 Jul 2023 06:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5EXdX4HaS6+tDknt2guchiQQO6gtGWqD5ygkNx2bob4=; b=pZAmoTR7D7TONr /2CCiYHqu0OyrELlHkN2imM2YXzc8glbzqFEtIqfWqCD3w2ASOR6UGbDDsr0jxNb/hZ+MMImb8VG4 KS2xKbfu7sXLUMYF8ydTiPZ2S2qWqH0o5pgCq/jLeV8L4hzsLLoBbceTG060HTqeYq2cZF41oryVL SxQVogU4lFsqTV0PD8zouZMO3SxEAwwwAJNIqIm/4mlALL+tqDFT+DlnnIyIreDJ9T20j0qhOcK1w wdo06dPtb1vh3DXW4xZa8LLQnHCn3zd8HyYxHqdat21eGADU8CbU77Ga3OsixNaz/fo+BV5VSmkS4 4oWsIVuC0qvjRSMX3AAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM0QG-005b3S-1X; Wed, 19 Jul 2023 06:12:28 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM0QE-005b1p-2M for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 06:12:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=jL6T6zUPXE3CCWce7xEIKEuuvu+FT0vtNSNDLrKiyG4=; b=T5IfFATjBbk9XpfNPi4wHeqeEj 1l5+gVa1rPMTrvDfC4RhUgRcC9Ge6k20+wa9cGrho5e85FRf/1gME+JUeLWz1i1pmpuEp38fm07G0 bT7n/8QlNe0VmvjKHPxTGhNgibPUKEeN2i/zH4+d3n4UkOHteS7heOrig6zLSXavfuwaXXsO9lt82 oob939wiPu33usjGZ0YjKRwCmDwEwOmOj1P6HDIJn6lJytcu65a4mJHFLmpWY/og5A8OkUxZEGL4P Byooq4vKcmppCsyKi6hSmy6izgeszeevK6q8OBU0i/F8qa8vK8fMflbzfyMWD0fVhuToO1Y+7KpXM lWj81BxA==; Received: from mail-pf1-f172.google.com ([209.85.210.172]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLgUd-00BKMX-0O for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 08:55:41 +0000 Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-666ecf9a081so5464805b3a.2 for ; Tue, 18 Jul 2023 01:55:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689670533; x=1692262533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jL6T6zUPXE3CCWce7xEIKEuuvu+FT0vtNSNDLrKiyG4=; b=epo1SrsFzRgmOZ5dVx6C0f0XvfdmUbCp9QFcvki4jB0GnqOtSbxzDj/p3T6G9+k4i/ vnczNKu6EE1o7xJOefITfJjzPFfzqbtf8ijrxoi5st2ppgRElxjC8mk6Brcdakr5o7lk 1oiXf4VWX/5e347zVDjqQPZ1Ztzg3DayZnjn6K2dX4RADeGrpd9e2F2ZL1TpNTDtQzvJ m36MckF4DqdTTDZQITuL0+NOHQED8umKnWHNLkxzZ0/tErNcqC2Mj2+05oNwZAmEVPyb od6XE8oFlH9/nuLyP3F2AYJk8dk5rJ7Pl5VpQpQBRQDhh/VE0gDrIweXPcoirY6YO8yh g0uw== X-Gm-Message-State: ABy/qLZTFHxCAR4jCppW/mMvdmqacs/b9EANNxiDXMAZ8d2J3dslBr/0 RxQf4I8MnySSHfyo+DnwbaCTzkVyz2W0HQ== X-Google-Smtp-Source: APBJJlEXVOfK+Oz77sy2Agp3i5Bz0sg+YTaUgKgUKZikigImO+hddycG37H2R6gvmih7I+qe4ag0jg== X-Received: by 2002:a05:6a20:d9:b0:134:4f86:7990 with SMTP id 25-20020a056a2000d900b001344f867990mr7635622pzh.3.1689670533336; Tue, 18 Jul 2023 01:55:33 -0700 (PDT) Received: from dev-linux.lan (cpe-70-95-21-110.san.res.rr.com. [70.95.21.110]) by smtp.gmail.com with ESMTPSA id s1-20020a62e701000000b00678159eacecsm1073860pfh.121.2023.07.18.01.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 01:55:33 -0700 (PDT) From: Sukrut Bellary To: Sudeep Holla , Cristian Marussi Cc: Sukrut Bellary , Dan Carpenter , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] firmware: arm_scmi: Fix signed error return values handling Date: Tue, 18 Jul 2023 01:55:29 -0700 Message-Id: <20230718085529.258899-1-sukrut.bellary@linux.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_095539_326150_970A840B X-CRM114-Status: GOOD ( 12.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Handle signed error return values returned by simple_write_to_buffer(). In case of an error, return the error code. Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support") Reported-by: Dan Carpenter Signed-off-by: Sukrut Bellary --- This is based on static analysis. Compilation tested. --- drivers/firmware/arm_scmi/raw_mode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/raw_mode.c b/drivers/firmware/arm_scmi/raw_mode.c index 6971dcf72fb9..0493aa3c12bf 100644 --- a/drivers/firmware/arm_scmi/raw_mode.c +++ b/drivers/firmware/arm_scmi/raw_mode.c @@ -818,10 +818,13 @@ static ssize_t scmi_dbg_raw_mode_common_write(struct file *filp, * before sending it with a single RAW xfer. */ if (rd->tx_size < rd->tx_req_size) { - size_t cnt; + ssize_t cnt; cnt = simple_write_to_buffer(rd->tx.buf, rd->tx.len, ppos, buf, count); + if (cnt < 0) + return cnt; + rd->tx_size += cnt; if (cnt < count) return cnt; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel