From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8163AC0015E for ; Wed, 19 Jul 2023 05:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Mime-Version:References: In-Reply-To:Message-Id:Cc:To:From:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=5Z6+KV1DFiypyoxhAMz5NMG2WU7qNJ4V8g3+aU5nKio=; b=4RHpQJG9m5paFRbtAHLafLMnDq RXdq/RoBDsCQJj3CZq/KNGvI47L2WkH/KitFhX6eH0hNlsEYoueHgxk7GRRUannKhHsdsy8EJlN/1 SwzcIu9CgryNJjlzbN5oVK6VngCuXemq8Fye9S/nBCdj/8uZOPyO3JpKhM2jeSPTC423L9fqfIuVv lhRuzraUjnySxxDgd53dq4dUdi/O+8/WwYMGBr9MKIZ4NnryUY3f6T+7j+FGKf82ZN0mhgoC5Bo39 t8PKfQ2Wi36dC/hP10iRHcII9FOMXfSQzZEBNFelzjCmksSsQ5Z0Z1WYYnrhg2igTx9Lod+cmLo7Y O7T3pzFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qLzIo-00576Q-0Z; Wed, 19 Jul 2023 05:00:42 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLzIn-00575X-00 for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 05:00:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Subject:Content-Transfer-Encoding: Content-Type:Mime-Version:References:In-Reply-To:Message-Id:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=DjU8QbWwoYzSGBCbnklVIsE6FxMt00a2BFKbWomZUJc=; b=q+8qbWWAzL+oGluYlhxeyBLbUZ PMkTSb9ZMQrzONZECJQpu8/H+UEQG6wfg2nJa+5+r69N1JyFxc7wPp2kSlMH7MdcwtqnNkdGvHvNE QCl9OLUxnbJjHCYs2PUoZsl4NsJc3D2tVBycWotTd+A/bM1Yfxep/o6iJ9NmxgAZLWG2tBbJN+u8z c8x6GSRe8ZX/WlD20G+0gNFGqMQHytIM2IOLPIBoi1J969yr4UDDpmjIq0/AErvgkYTc2IcmmkZly MURoHN1b3Ua+s0N2Izkt9OSbLwIqn2heKYYA0wAir1OJ0womAK8lL7P5qMSP2wnT2ebZb4oD4wQS9 Pj0uU7Gg==; Received: from mail.hugovil.com ([162.243.120.170]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLlJJ-00Bcmb-0X for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 14:04:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DjU8QbWwoYzSGBCbnklVIsE6FxMt00a2BFKbWomZUJc=; b=LnRMIpe7rVTL9UeO05+vSQqoSd K0jcAOh+HhQNmQ5+PyRUU76awBMAhKxcK6Lrk+mzJVOXaKGrGDKP6dWKTbnQ4EJFQCgh/2mpszRt1 p9v9wBd4hq7IqnZjhPT2ym2L10N0kB+crm6AEYrpaG78+tumxZx6fSR1PUtdDGDjOC6Q=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:53212 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qLlIm-0004C8-Rm; Tue, 18 Jul 2023 10:03:45 -0400 Date: Tue, 18 Jul 2023 10:03:44 -0400 From: Hugo Villeneuve To: Shawn Guo Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Hugo Villeneuve , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: <20230718100344.ebeae4ee79c299bcd6fee733@hugovil.com> In-Reply-To: <20230718063715.GL9559@dragon> References: <20230705174932.3652479-1-hugo@hugovil.com> <20230718063715.GL9559@dragon> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH v2] arm64: dts: imx8mn-var-som-symphony: fix USB OTG X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_150417_516034_37BED4D1 X-CRM114-Status: GOOD ( 32.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Jul 2023 14:37:15 +0800 Shawn Guo wrote: > On Wed, Jul 05, 2023 at 01:49:32PM -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > > > USB OTG is currently broken on the Variscite Symphony EVK and imx8mn > > nano SOM. > > > > The PTN5150 circuitry on newer versions of the Symphony EVK board has > > a non-standard configuration in which the PTN5150 IRQ pin is left > > unconnected, and the PTN5150 ID pin is connected to GPIO1_IO11. This > > requires changes to the ptn5150 driver to support this new mode. > > Variscite have indicated their intention to submit those changes > > upstream. > > > > In the meantime, import device tree changes from linux-5.15 branch of > > varigit repos to at least make the USB OTG port operate correctly in > > host mode. > > > > Fixes: 7358e05bddca ("arm64: dts: imx8mn-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MN") > > Has USB OTG been ever worked at all? If the answer is no, it's not > a fix but a new feature, and I would suggest you rework the patch > subject and drop the Fixes tag. Hi Shawn, it never worked for me since commit 7358e05bddca, but it may have something to do with the new hardware board version (>=1.4a) that I have. It probably worked for older boards (< 1.4a) altough I cannot confirm it without old hardware. Let me know if you want me to remove the Fixes tag. Hugo. > > Shawn > > > Signed-off-by: Hugo Villeneuve > > --- > > Link: [v1] https://lkml.org/lkml/2023/7/4/702 > > > > Changes from v1: > > - Add comments about PTN5150 IRQ/ID line connections > > - Remove "typec1_con: connector" node > > - Change IRQ type to IRQ_TYPE_EDGE_FALLING > > > > .../dts/freescale/imx8mn-var-som-symphony.dts | 32 +++++++++++++++++-- > > 1 file changed, 30 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > > index 406a711486da..a7a57442cb81 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > > @@ -1,11 +1,14 @@ > > // SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > /* > > + * Supports Symphony evaluation board versions >= 1.4a. > > + * > > * Copyright 2019-2020 Variscite Ltd. > > * Copyright (C) 2020 Krzysztof Kozlowski > > */ > > > > /dts-v1/; > > > > +#include > > #include "imx8mn-var-som.dtsi" > > > > / { > > @@ -100,14 +103,26 @@ enet-sel-hog { > > }; > > }; > > > > + /* > > + * For Symphony board version <= 1.4, the PTN5150 IRQ pin is connected > > + * to GPIO1_IO11 on the SoM (R106 present, R132 absent). From Symphony > > + * board version >= 1.4a, the PTN5150 ID pin is connected to GPIO1_IO11 > > + * on the SoM (R106 absent, R132 present). > > + */ > > extcon_usbotg1: typec@3d { > > compatible = "nxp,ptn5150"; > > reg = <0x3d>; > > interrupt-parent = <&gpio1>; > > - interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > > + interrupts = <11 IRQ_TYPE_EDGE_FALLING>; > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_ptn5150>; > > status = "okay"; > > + > > + port { > > + typec1_dr_sw: endpoint { > > + remote-endpoint = <&usb1_drd_sw>; > > + }; > > + }; > > }; > > }; > > > > @@ -148,8 +163,21 @@ &uart3 { > > }; > > > > &usbotg1 { > > + dr_mode = "otg"; > > + hnp-disable; > > + srp-disable; > > + adp-disable; > > + usb-role-switch; > > disable-over-current; > > - extcon = <&extcon_usbotg1>, <&extcon_usbotg1>; > > + samsung,picophy-pre-emp-curr-control = <3>; > > + samsung,picophy-dc-vol-level-adjust = <7>; > > + status = "okay"; > > + > > + port { > > + usb1_drd_sw: endpoint { > > + remote-endpoint = <&typec1_dr_sw>; > > + }; > > + }; > > }; > > > > &iomuxc { > > > > base-commit: d528014517f2b0531862c02865b9d4c908019dc4 > > -- > > 2.30.2 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel