From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAE55C001B0 for ; Wed, 19 Jul 2023 05:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YCHHsjd00ZAWNBLEEK7xN9wu58DNtt6hER8ss1qo+vA=; b=tBrf2UMmN3/3Sv Ri6rpocQUhPRl18OJ+Ewjxw2ao9yZI9ffZRlSURx/WAQdEcROG5/Ci/LOz6j+D6ZZa26+Hb1TAWyj yeNFZoAUWralyJNMipeotF7C+eSrOk9DAZEYIQnPosZPg3OGBqbPTxc9mje46g+nfNq/xms7lnE0q dezoX4P0UGitSqAoxzSvJg73U4B+AZIfuGqjwT+ufbNZcDXG0l0iWziTisDXjA3qfBjOqWU23LUT2 VlE9ZAzX/DxOSMUdLq6qyaa5ozse2MX9ZNe4k+QT+hBJaHugi1xmCrK2AujHUI2DIzbsDa6HD7IWZ m3HTl3n4fPCaUpWo4PYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM055-005QyE-39; Wed, 19 Jul 2023 05:50:35 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM053-005QxK-1A for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 05:50:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :Mime-Version:References:In-Reply-To:Message-Id:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=jYSPh1HqTa1Mmt1zonFerUrCN5745Tn8Vat/FJeFoEs=; b=qPly7+Uv7k6/g1KdeiVDxsSAWo 2m3j5oaZ5oLCGOS0o6/wgaR60GUgLXkEtcm3CWhrWb1ERmdcLDfowbX84cR/w2hdmbnaTZXiLMmmy 9Dll5UEJ2xSZx3uIYaNehD9y5Do5LgLuPOS+oyT91o93jh0H12BYw20Q1veXNdmBxjKLquA6e3hbP lNTR/UWOmC89Ct1xwLAQa/b/TvzlQ0+nGTmPxUK7glEMnghO9+vWgZ+Klnv3V108OlsLNdwSMRx9x yfdGs0MtCiAPWD3qz77KHaGzxyC85YayV27Wm18UtCRUBjInLZi+dg5MMsNtOVoYQ758MhOgPqJyN nm8w+Keg==; Received: from dfw.source.kernel.org ([139.178.84.217]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLpYr-00Bsga-2V for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 18:36:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33063616A8; Tue, 18 Jul 2023 18:36:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE9F2C433C8; Tue, 18 Jul 2023 18:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689705381; bh=JgrHe5DZ5UnZ31Le+DdrjV7UqhJAEhx+BMwzO0I0pyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rSwv4V3DUswnOOwtuqviHoHg8mtQl8Mycp8naGrr017s7gsEUs+LUFgW78b59OlD6 RJ07+aYugwPVV2ffN02N+TbXLoW/RPNxLL/RW1q/hReBJmWPBWvyF6ARM4VWnVkHi/ WwOrnVSIGZK5bXjK7yuuDSaj1cyDMcQJVsSO4MIU= Date: Tue, 18 Jul 2023 11:36:20 -0700 From: Andrew Morton To: Jason Gunthorpe Cc: Alistair Popple , ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com Subject: Re: [PATCH 1/4] mm_notifiers: Rename invalidate_range notifier Message-Id: <20230718113620.fb29217344238307c3be76d7@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_193638_021363_22FB4444 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Jul 2023 14:57:12 -0300 Jason Gunthorpe wrote: > On Tue, Jul 18, 2023 at 05:56:15PM +1000, Alistair Popple wrote: > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > > index b466172..48c81b9 100644 > > --- a/include/asm-generic/tlb.h > > +++ b/include/asm-generic/tlb.h > > @@ -456,7 +456,7 @@ static inline void tlb_flush_mmu_tlbonly(struct mmu_gather *tlb) > > return; > > > > tlb_flush(tlb); > > - mmu_notifier_invalidate_range(tlb->mm, tlb->start, tlb->end); > > + mmu_notifier_invalidate_secondary_tlbs(tlb->mm, tlb->start, tlb->end); > > __tlb_reset_range(tlb); > > Does this compile? I don't see > "mmu_notifier_invalidate_secondary_tlbs" ? Seems this call gets deleted later in the series. > But I think the approach in this series looks fine, it is so much > cleaner after we remove all the cruft in patch 4, just look at the > diffstat.. I'll push this into -next if it compiles OK for me, but yes, a redo is desirable please. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel